asan builder failing in UnitTest stage: authpolicy package failing to build |
||||
Issue descriptionStarting around Nov. 21, the asan builder started failing in the UnitTest stage, failing to build authpolicy. An example log can be found here. Please fix this asap. https://luci-logdog.appspot.com/logs/chromeos/buildbucket/cr-buildbucket.appspot.com/8929056462642132240/+/steps/UnitTest/0/stdout
,
Nov 28
He is. Taking a look.
,
Nov 28
,
Nov 28
This test checks whether seccomp filtering works, but minijail disables that for asan builds. The test just needs to be disabled for asan. manojgupta@, is there some recommended way to disable specific tests when running under asan?
,
Nov 28
I had to disable a unit test for asan in libbrillo last year, you should be able to do something similar. Those are the CLs: https://chromium-review.googlesource.com/c/aosp/platform/external/libbrillo/+/898605 https://chromium-review.googlesource.com/c/aosp/platform/external/libbrillo/+/889659/
,
Dec 3
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/c6c4fb2dde34c65968cf4a8f08bb82390ad5f118 commit c6c4fb2dde34c65968cf4a8f08bb82390ad5f118 Author: Lutz Justen <ljusten@chromium.org> Date: Mon Dec 03 20:43:36 2018 authpolicy: Disable test under ASAN Disable AuthPolicyTest.SeccompFiltersEnabled under ASAN. This test checks whether seccomp filtering works, but minijail disables that for ASAN builds, so the test fails. BUG= chromium:908140 TEST=Checked that test still runs when not under ASAN cros tryjob -g 1356740 betty-asan-tryjob Change-Id: I969a051409672bc312212e869957d9b8d66cb04d Reviewed-on: https://chromium-review.googlesource.com/1356740 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> [modify] https://crrev.com/c6c4fb2dde34c65968cf4a8f08bb82390ad5f118/authpolicy/authpolicy_unittest.cc
,
Dec 4
cmtice@, could you please verify the fix?
,
Dec 15
is there any need for manual verification?
,
Dec 17
|
||||
►
Sign in to add a comment |
||||
Comment 1 by llozano@chromium.org
, Nov 27Status: Assigned (was: Untriaged)