New issue
Advanced search Search tips

Issue 908139 link

Starred by 2 users
Status: Assigned
Owner:
lfg@chromium.org
Cc:
jam@chromium.org
alex...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

content/public API should not use const interfaces

Project Member Reported by lfg@chromium.org, Nov 23 
The content API design explicitly mentions that we shouldn't have const interfaces in the public API: https://www.chromium.org/developers/content-module/content-api. The reasoning is that "For interfaces implemented by the embedder, we can't make assumptions about what the embedder needs to implement it. For interfaces implemented by content, the implementation details doesn't have to be exposed."

This isn't a rule we've been enforcing, which causes confusion for both developers and reviewers touching code in that API surface.

We should fix the existing use cases, and start enforcing that rule with a PRESUBMIT rule.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1c5dfdaff5d1b774b612b246c6407310c5892f8

commit e1c5dfdaff5d1b774b612b246c6407310c5892f8
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Thu Nov 29 17:57:41 2018

Remove const interfaces from content::WebContents.

Bug: 908139
Change-Id: I678dc64c18e78392493c2fc3acba974b3b6a28f8
Reviewed-on: https://chromium-review.googlesource.com/c/1349466
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612261}
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/android_webview/browser/state_serializer.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/android_webview/browser/state_serializer.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/android/contextualsearch/contextual_search_ranker_logger_impl.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/android/contextualsearch/contextual_search_ranker_logger_impl.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/chromeos/file_system_provider/request_manager.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/chromeos/login/signin_partition_manager.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/chromeos/login/signin_partition_manager.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/download/download_permission_request.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/extensions/activity_log/activity_log.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/extensions/activity_log/activity_log.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/interstitials/enterprise_util.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/permissions/permission_uma_util.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/renderer_context_menu/context_menu_content_type_platform_app.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/renderer_context_menu/context_menu_content_type_platform_app.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/resource_coordinator/tab_metrics_logger.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/resource_coordinator/tab_metrics_logger.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/safe_browsing/chrome_password_protection_service.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/safe_browsing/download_protection/download_protection_service.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/safe_browsing/trigger_creator.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/safe_browsing/ui_manager.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/safe_browsing/ui_manager.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/search/iframe_source.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/search/search.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/search/search.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/search/search_unittest.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/sessions/session_restore.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/sessions/session_restore_browsertest.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/translate/chrome_translate_client.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/ash/assistant/assistant_context_util.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/ash/tablet_mode_page_behavior_browsertest.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/browser_tabrestore_browsertest.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/chrome_pages.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/extensions/hosted_app_browser_controller.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/search/search_ipc_router_policy_impl.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/search/search_ipc_router_policy_impl.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/search/search_ipc_router_policy_unittest.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/search/search_tab_helper.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/settings_window_manager_chromeos.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/views/translate/translate_language_browsertest.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/webui/chromeos/login/discover/discover_window_manager.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/webui/settings/custom_home_pages_table_model.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/ui/webui/settings/custom_home_pages_table_model.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/web_applications/bookmark_apps/bookmark_app_install_manager.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/web_applications/bookmark_apps/bookmark_app_install_manager.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/web_applications/components/install_manager.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/web_applications/web_app_install_manager.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/web_applications/web_app_install_manager.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/web_applications/web_app_provider.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chrome/browser/web_applications/web_app_provider.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/chromecast/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/components/renderer_context_menu/context_menu_content_type.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/components/safe_browsing/base_ui_manager.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/components/safe_browsing/base_ui_manager.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/components/safe_browsing/triggers/ad_sampler_trigger.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/components/safe_browsing/triggers/suspicious_site_trigger.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/components/safe_browsing/triggers/trigger_manager.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/components/safe_browsing/triggers/trigger_manager.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/components/safe_browsing/triggers/trigger_manager_unittest.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/components/sessions/content/content_live_tab.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/components/sessions/content/content_live_tab.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/components/sessions/core/live_tab.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/components/sessions/ios/ios_live_tab.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/components/sessions/ios/ios_live_tab.mm
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/components/zoom/zoom_controller.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/components/zoom/zoom_controller.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/browser/frame_host/interstitial_page_impl.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/browser/frame_host/interstitial_page_impl.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/browser/frame_host/navigation_controller_delegate.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/browser/frame_host/navigator_delegate.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/browser/frame_host/render_frame_host_delegate.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/browser/host_zoom_map_impl.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/browser/host_zoom_map_impl.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/browser/media/media_internals.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/browser/renderer_host/render_widget_host_delegate.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/public/browser/host_zoom_map.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/public/browser/web_contents.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/test/mock_render_widget_host_delegate.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/test/mock_render_widget_host_delegate.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/test/test_web_contents.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/content/test/test_web_contents.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/extensions/browser/process_manager.cc
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/extensions/browser/process_manager.h
[modify] https://crrev.com/e1c5dfdaff5d1b774b612b246c6407310c5892f8/extensions/browser/script_executor.h
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d51ff5d6f3d174327fed6e4598e32cba7c6122f4

commit d51ff5d6f3d174327fed6e4598e32cba7c6122f4
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Fri Dec 07 21:26:49 2018

Remove const interfaces from content/public/renderer/.

This CL also adds a presubmit enforcement that ensures that no const
interfaces are added, following the content API design.

Bug: 908139
Change-Id: Iee5b3d4d13a775462db1742cb1ff5e9d1b960001
Reviewed-on: https://chromium-review.googlesource.com/c/1357461
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614818}
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/chrome/renderer/content_settings_observer.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/chrome/renderer/extensions/extension_localization_peer.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/chrome/renderer/extensions/extension_localization_peer.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/chrome/renderer/extensions/extension_localization_peer_unittest.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/chrome/renderer/security_filter_peer.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/chrome/renderer/security_filter_peer.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/components/pdf/renderer/pdf_accessibility_tree_browsertest.cc
[add] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/public/renderer/PRESUBMIT.py
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/public/renderer/fixed_received_data.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/public/renderer/fixed_received_data.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/public/renderer/media_stream_audio_renderer.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/public/renderer/pepper_plugin_instance.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/public/renderer/plugin_instance_throttler.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/public/renderer/render_frame.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/public/renderer/render_thread.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/public/renderer/render_view.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/public/renderer/renderer_ppapi_host.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/public/renderer/request_peer.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/public/renderer/v8_value_converter.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/public/test/mock_render_thread.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/public/test/mock_render_thread.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/java/gin_java_bridge_value_converter.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/java/gin_java_bridge_value_converter.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/loader/resource_dispatcher_unittest.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/loader/shared_memory_data_consumer_handle.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/loader/shared_memory_data_consumer_handle_unittest.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/loader/sync_load_context.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/loader/sync_load_context.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/loader/test_request_peer.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/loader/test_request_peer.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/loader/url_response_body_consumer.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/loader/url_response_body_consumer_unittest.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/media/stream/track_audio_renderer.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/media/stream/track_audio_renderer.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/media/webrtc/webrtc_audio_renderer.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/media/webrtc/webrtc_audio_renderer.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/pepper/content_renderer_pepper_host_factory.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/pepper/fake_pepper_plugin_instance.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/pepper/fake_pepper_plugin_instance.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/pepper/mock_renderer_ppapi_host.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/pepper/mock_renderer_ppapi_host.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/pepper/pepper_plugin_instance_impl.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/pepper/plugin_instance_throttler_impl.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/pepper/plugin_instance_throttler_impl.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/pepper/renderer_ppapi_host_impl.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/pepper/renderer_ppapi_host_impl.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/render_frame_impl.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/render_thread_impl.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/render_view_impl.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/render_view_impl.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/v8_value_converter_impl.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/v8_value_converter_impl.h
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/content/renderer/v8_value_converter_impl_unittest.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/extensions/renderer/activity_log_converter_strategy.cc
[modify] https://crrev.com/d51ff5d6f3d174327fed6e4598e32cba7c6122f4/extensions/renderer/activity_log_converter_strategy.h
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79951a21bbbd785a7b485cce2fdad7a4fe8d7892

commit 79951a21bbbd785a7b485cce2fdad7a4fe8d7892
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Wed Dec 12 18:16:02 2018

Remove const interfaces from content::RenderProcessHost.

Bug: 908139
Change-Id: Ie328baa725217abe3dbbb144d166671f2933403b
Reviewed-on: https://chromium-review.googlesource.com/c/1356004
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615965}
[modify] https://crrev.com/79951a21bbbd785a7b485cce2fdad7a4fe8d7892/chrome/browser/media/webrtc/webrtc_event_log_manager_unittest.cc
[modify] https://crrev.com/79951a21bbbd785a7b485cce2fdad7a4fe8d7892/chrome/browser/prerender/prerender_contents.cc
[modify] https://crrev.com/79951a21bbbd785a7b485cce2fdad7a4fe8d7892/chrome/browser/search/search.cc
[modify] https://crrev.com/79951a21bbbd785a7b485cce2fdad7a4fe8d7892/chrome/browser/task_manager/providers/web_contents/renderer_task.cc
[modify] https://crrev.com/79951a21bbbd785a7b485cce2fdad7a4fe8d7892/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/79951a21bbbd785a7b485cce2fdad7a4fe8d7892/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/79951a21bbbd785a7b485cce2fdad7a4fe8d7892/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/79951a21bbbd785a7b485cce2fdad7a4fe8d7892/content/public/browser/render_process_host.h
[modify] https://crrev.com/79951a21bbbd785a7b485cce2fdad7a4fe8d7892/content/public/test/mock_render_process_host.cc
[modify] https://crrev.com/79951a21bbbd785a7b485cce2fdad7a4fe8d7892/content/public/test/mock_render_process_host.h
[modify] https://crrev.com/79951a21bbbd785a7b485cce2fdad7a4fe8d7892/extensions/browser/guest_view/web_view/web_view_guest.cc
[modify] https://crrev.com/79951a21bbbd785a7b485cce2fdad7a4fe8d7892/extensions/browser/guest_view/web_view/web_view_guest.h
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/309cd09ff629bcbaca1acae45360a7f0bf56b5e9

commit 309cd09ff629bcbaca1acae45360a7f0bf56b5e9
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Mon Jan 07 18:01:52 2019

Remove const interfaces from NavigationController and NavigationEntry.

Bug: 908139
Change-Id: Ic47f47ba0a5a7fabbeb2f0f9942e2269a783833c
Reviewed-on: https://chromium-review.googlesource.com/c/1372472
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620375}
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/android_webview/browser/aw_settings.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/android_webview/browser/state_serializer.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/android_webview/browser/state_serializer.h
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/android/tab_state.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/android/tab_web_contents_delegate_android.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/browsing_data/navigation_entry_remover.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/dom_distiller/tab_utils.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/download/download_request_limiter.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/extensions/active_tab_permission_granter.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/extensions/app_process_apitest.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/favicon/favicon_utils.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/media/webrtc/tab_desktop_media_list_unittest.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/offline_pages/offline_page_info_handler.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/offline_pages/offline_page_info_handler.h
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/offline_pages/offline_page_utils.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/offline_pages/offline_page_utils.h
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/offline_pages/offline_page_utils_unittest.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/permissions/permission_context_base.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/safe_browsing/browser_feature_extractor.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/search/iframe_source.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/search/search.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/search/search.h
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/sessions/session_common_utils_unittest.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/sessions/session_restore_browsertest.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/sessions/session_service.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/sessions/session_tab_helper.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/ssl/ssl_browsertest_util.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/supervised_user/supervised_user_interstitial.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/supervised_user/supervised_user_navigation_observer.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/task_manager/providers/web_contents/tab_contents_tag_browsertest.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/translate/chrome_translate_client.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/ui/browser.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/ui/search/ntp_user_data_logger.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/ui/search/search_tab_helper.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/ui/search_engines/search_engine_tab_helper.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/components/favicon/content/content_favicon_driver.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/components/sessions/content/content_live_tab.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/components/sessions/content/content_record_password_state.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/components/sessions/content/content_record_password_state.h
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/components/sessions/content/content_serialized_navigation_builder.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/components/sessions/content/content_serialized_navigation_builder.h
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/components/sessions/content/content_serialized_navigation_builder_unittest.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/components/sessions/content/extended_info_handler.h
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/browser/cross_site_transfer_browsertest.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/browser/frame_host/navigation_controller_impl.h
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/browser/frame_host/navigation_entry_impl.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/browser/frame_host/navigation_entry_impl.h
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/browser/frame_host/navigation_request.h
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/browser/frame_host/render_frame_host_manager_unittest.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/browser/host_zoom_map_impl.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/browser/web_contents/aura/gesture_nav_simple.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/public/browser/host_zoom_map.h
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/public/browser/navigation_controller.h
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/public/browser/navigation_details.h
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/public/browser/navigation_entry.h
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/test/test_render_frame_host.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/content/test/test_web_contents.cc
[modify] https://crrev.com/309cd09ff629bcbaca1acae45360a7f0bf56b5e9/extensions/browser/process_manager.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f860d0cef9c03ed8edba477b23299a4be2b77514

commit f860d0cef9c03ed8edba477b23299a4be2b77514
Author: Xida Chen <xidachen@chromium.org>
Date: Mon Jan 07 18:43:52 2019

Revert "Remove const interfaces from NavigationController and NavigationEntry."

This reverts commit 309cd09ff629bcbaca1acae45360a7f0bf56b5e9.

Reason for revert:
causing compilation failure:
https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/42854

Original change's description:
> Remove const interfaces from NavigationController and NavigationEntry.
> 
> Bug: 908139
> Change-Id: Ic47f47ba0a5a7fabbeb2f0f9942e2269a783833c
> Reviewed-on: https://chromium-review.googlesource.com/c/1372472
> Commit-Queue: Lucas Gadani <lfg@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#620375}

TBR=jam@chromium.org,lfg@chromium.org

Change-Id: I64a1a71701707973d093ee0ca77b23b8803f2730
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 908139
Reviewed-on: https://chromium-review.googlesource.com/c/1398516
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620396}
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/android_webview/browser/aw_settings.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/android_webview/browser/state_serializer.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/android_webview/browser/state_serializer.h
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/android/tab_state.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/android/tab_web_contents_delegate_android.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/browsing_data/navigation_entry_remover.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/dom_distiller/tab_utils.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/download/download_request_limiter.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/extensions/active_tab_permission_granter.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/extensions/app_process_apitest.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/favicon/favicon_utils.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/media/webrtc/tab_desktop_media_list_unittest.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/offline_pages/offline_page_info_handler.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/offline_pages/offline_page_info_handler.h
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/offline_pages/offline_page_utils.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/offline_pages/offline_page_utils.h
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/offline_pages/offline_page_utils_unittest.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/permissions/permission_context_base.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/safe_browsing/browser_feature_extractor.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/search/iframe_source.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/search/search.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/search/search.h
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/sessions/session_common_utils_unittest.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/sessions/session_restore_browsertest.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/sessions/session_service.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/sessions/session_tab_helper.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/ssl/ssl_browsertest_util.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/supervised_user/supervised_user_interstitial.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/supervised_user/supervised_user_navigation_observer.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/task_manager/providers/web_contents/tab_contents_tag_browsertest.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/translate/chrome_translate_client.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/ui/browser.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/ui/search/ntp_user_data_logger.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/ui/search/search_tab_helper.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/ui/search_engines/search_engine_tab_helper.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/components/favicon/content/content_favicon_driver.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/components/sessions/content/content_live_tab.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/components/sessions/content/content_record_password_state.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/components/sessions/content/content_record_password_state.h
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/components/sessions/content/content_serialized_navigation_builder.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/components/sessions/content/content_serialized_navigation_builder.h
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/components/sessions/content/content_serialized_navigation_builder_unittest.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/components/sessions/content/extended_info_handler.h
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/browser/cross_site_transfer_browsertest.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/browser/frame_host/navigation_controller_impl.h
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/browser/frame_host/navigation_entry_impl.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/browser/frame_host/navigation_entry_impl.h
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/browser/frame_host/navigation_request.h
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/browser/frame_host/render_frame_host_manager_unittest.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/browser/host_zoom_map_impl.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/browser/web_contents/aura/gesture_nav_simple.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/public/browser/host_zoom_map.h
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/public/browser/navigation_controller.h
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/public/browser/navigation_details.h
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/public/browser/navigation_entry.h
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/test/test_render_frame_host.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/content/test/test_web_contents.cc
[modify] https://crrev.com/f860d0cef9c03ed8edba477b23299a4be2b77514/extensions/browser/process_manager.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5553a1588f5fbf1bd7f6047102f1446f26ee3172

commit 5553a1588f5fbf1bd7f6047102f1446f26ee3172
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Tue Jan 08 18:55:57 2019

Reland "Remove const interfaces from NavigationController and NavigationEntry."

This is a reland of 309cd09ff629bcbaca1acae45360a7f0bf56b5e9

Original change's description:
> Remove const interfaces from NavigationController and NavigationEntry.
>
> Bug: 908139
> Change-Id: Ic47f47ba0a5a7fabbeb2f0f9942e2269a783833c
> Reviewed-on: https://chromium-review.googlesource.com/c/1372472
> Commit-Queue: Lucas Gadani <lfg@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#620375}

TBR=jam@chromium.org

Bug: 908139
Change-Id: Ieb0fec43244b6cf2cb60bfbeafaeb0e5199d43df
Reviewed-on: https://chromium-review.googlesource.com/c/1398517
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620820}
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/android_webview/browser/aw_settings.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/android_webview/browser/state_serializer.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/android_webview/browser/state_serializer.h
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/android/tab_state.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/android/tab_web_contents_delegate_android.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/browsing_data/navigation_entry_remover.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/dom_distiller/tab_utils.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/download/download_request_limiter.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/extensions/active_tab_permission_granter.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/extensions/app_process_apitest.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/favicon/favicon_utils.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/media/webrtc/tab_desktop_media_list_unittest.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/offline_pages/offline_page_info_handler.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/offline_pages/offline_page_info_handler.h
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/offline_pages/offline_page_utils.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/offline_pages/offline_page_utils.h
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/offline_pages/offline_page_utils_unittest.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/permissions/permission_context_base.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/rlz/chrome_rlz_tracker_delegate.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/safe_browsing/browser_feature_extractor.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/search/iframe_source.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/search/search.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/search/search.h
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/sessions/session_common_utils_unittest.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/sessions/session_restore_browsertest.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/sessions/session_service.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/sessions/session_tab_helper.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/ssl/ssl_browsertest_util.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/supervised_user/supervised_user_interstitial.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/supervised_user/supervised_user_navigation_observer.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/task_manager/providers/web_contents/tab_contents_tag_browsertest.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/translate/chrome_translate_client.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/ui/bookmarks/bookmark_tab_helper.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/ui/browser.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/ui/search/ntp_user_data_logger.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/ui/search/search_tab_helper.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/ui/search_engines/search_engine_tab_helper.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/ui/sync/tab_contents_synced_tab_delegate.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/components/favicon/content/content_favicon_driver.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/components/sessions/content/content_live_tab.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/components/sessions/content/content_record_password_state.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/components/sessions/content/content_record_password_state.h
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/components/sessions/content/content_serialized_navigation_builder.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/components/sessions/content/content_serialized_navigation_builder.h
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/components/sessions/content/content_serialized_navigation_builder_unittest.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/components/sessions/content/extended_info_handler.h
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/browser/cross_site_transfer_browsertest.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/browser/frame_host/navigation_controller_impl.h
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/browser/frame_host/navigation_controller_impl_browsertest.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/browser/frame_host/navigation_controller_impl_unittest.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/browser/frame_host/navigation_entry_impl.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/browser/frame_host/navigation_entry_impl.h
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/browser/frame_host/navigation_request.h
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/browser/frame_host/render_frame_host_manager_unittest.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/browser/host_zoom_map_impl.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/browser/web_contents/aura/gesture_nav_simple.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/public/browser/host_zoom_map.h
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/public/browser/navigation_controller.h
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/public/browser/navigation_details.h
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/public/browser/navigation_entry.h
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/test/test_render_frame_host.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/content/test/test_web_contents.cc
[modify] https://crrev.com/5553a1588f5fbf1bd7f6047102f1446f26ee3172/extensions/browser/process_manager.cc
►

Sign in to add a comment