New issue
Advanced search Search tips

Issue 908138 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

asan builder failing with memory leaks in vm_host_tools package (in Chrome OS)

Project Member Reported by cmtice@google.com, Nov 23

Issue description

Starting around Nov. 21, the asan builder is detecting leaks in the vm_host_tools package in ChOSrome OS.

Please fix this.

Example log can be found here:

https://luci-logdog.appspot.com/logs/chromeos/buildbucket/cr-buildbucket.appspot.com/8929056462642132240/+/steps/UnitTest/0/stdout

(search for "detected memory leaks")
 
Nov. 21 lines up with the libchrome uprev: https://chromium-review.googlesource.com/1239834

I don't see anything else relevant in platform2/vm_tools around that time.
Ping?  Is anyone working on this (the memory leaks are still happening).
Labels: M-73
Owner: chirantan@chromium.org
Status: Assigned (was: Untriaged)
Cc: hidehiko@chromium.org
The stack traces for all the leaks show base::Histogram followed by tracked_objects::ThreadData::InitializeThreadContext followed by base::PlatformThread::SetName.  None of the stack traces show any code from the actual vm_host_tools programs.


Combined with the fact that this started happening at the same time as the libchrome uprev suggests that this is actually a leak in libchrome.  It's likely only triggering for vm_host_tools because we actually spawn new threads.  Most system daemons are single-threaded.


I tried checking to see if this was already reported and fixed upstream in chrome but I wasn't able to find anything and chrome completely removed tracked_objects in September 2017: https://chromium-review.googlesource.com/c/chromium/src/+/665969/


The leak was likely fixed when the code was deleted but I'm not sure what we can do about this other than waiting for a libchrome uprev.  Just another reason to stop using libchrome on chrome os.

Sign in to add a comment