New issue
Advanced search Search tips

Issue 908123 link

Starred by 2 users
Status: Fixed
Owner:
droger@chromium.org
Closed: Nov 26
Cc:
msarda@chromium.org
tangltom@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

UnifiedConsentServiceFactory should be registered

Project Member Reported by droger@google.com, Nov 23 
It should be added in:

1) EnsureBrowserContextKeyedServiceFactoriesBuilt()
chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc

2) ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm

This is especially important because it depends on other services, and other services depend on it.

Comment 1 by droger@google.com, Nov 23

Components: Services>SignIn

Comment 2 by droger@google.com, Nov 23 

Actually, it is already registered on desktop, sending a CL to add it on iOS:
https://chromium-review.googlesource.com/c/chromium/src/+/1349655/

Comment 3 by tangltom@chromium.org, Nov 25

Cc: tangltom@chromium.org
Labels: OS-iOS
Owner: droger@chromium.org
Status: Started (was: Assigned)
Thanks David!
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de60a40ba7b83771f6c79ef3b15a1529cd1db356

commit de60a40ba7b83771f6c79ef3b15a1529cd1db356
Author: David Roger <droger@chromium.org>
Date: Mon Nov 26 10:47:05 2018

[iOS] Register UnifiedConsentServiceFactory

Bug:  908123 
Change-Id: I721da9b87f677f4e68c255537dd67436d5316721
Reviewed-on: https://chromium-review.googlesource.com/c/1349655
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610804}
[modify] https://crrev.com/de60a40ba7b83771f6c79ef3b15a1529cd1db356/ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm

Comment 5 by droger@chromium.org, Nov 26

Status: Fixed (was: Started)
►

Sign in to add a comment