TracingPreferencesTest#testSelectCategories flaky on KitKat phone tester |
||||||
Issue descriptionhttps://ci.chromium.org/p/chromium/builders/luci.chromium.ci/KitKat%20Phone%20Tester%20%28dbg%29 e.g. builds #10526, #10523 example from https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8929053109883052832/+/steps/chrome_public_test_apk_on_Android_device_Nexus_5/0/stdout : C 725.247s Main [FAILURE] org.chromium.chrome.browser.preferences.developer.TracingPreferencesTest#testSelectCategories: C 725.248s Main java.lang.AssertionError: Could not find fragment class android.preference.PreferenceFragment C 725.248s Main at org.junit.Assert.fail(Assert.java:88) C 725.248s Main at org.junit.Assert.assertTrue(Assert.java:41) C 725.248s Main at org.chromium.content_public.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:92) C 725.248s Main at org.chromium.chrome.test.util.ActivityUtils.waitForFragmentToAttach(ActivityUtils.java:207) C 725.248s Main at org.chromium.chrome.browser.preferences.developer.TracingPreferencesTest.testSelectCategories(TracingPreferencesTest.java:314) C 725.248s Main at java.lang.reflect.Method.invokeNative(Native Method)
,
Nov 23
,
Nov 23
oh, thanks Eric was just about to assign to you )
,
Nov 26
Looks like the creation of the categories preferences activity is still flaky. I'll try to use startActivitySync instead of clicking the categories pref in the test. If that still doesn't work reliably, maybe we just leave the test disabled on kitkat.
,
Nov 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a9bfe407be6e865d73e6be7e653cb7be59ea0f4 commit 7a9bfe407be6e865d73e6be7e653cb7be59ea0f4 Author: Eric Seckler <eseckler@chromium.org> Date: Mon Nov 26 12:33:07 2018 tracing: Deflake TracingPreferencesTest#testSelectCategories further Previous attempts to deflake this test weren't successful yet, so here's another one. Replaces actually clicking on the categories pref and waiting for the new activity + fragment with starting it directly via startActivitySync instead. TBR=twellington@chromium.org Bug: 908118 Change-Id: I3c91dea54b8628d71bedab687e727fc791f8da6b Reviewed-on: https://chromium-review.googlesource.com/c/1350188 Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#610828} [modify] https://crrev.com/7a9bfe407be6e865d73e6be7e653cb7be59ea0f4/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/developer/TracingPreferencesTest.java
,
Nov 26
Let's monitor this for another day or so :)
,
Nov 27
Flakiness seems resolved [1]. [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.preferences.developer.TracingPreferencesTest%23testSelectCategories |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Nov 23