New issue
Advanced search Search tips

Issue 908104 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

gae: unconditionally add current branch name on non-pristine version

Project Member Reported by mar...@chromium.org, Nov 23

Issue description

This is a generalization of  issue 903947 .
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/f1e2a731cba6368d056176bc66ce19397a8a574a

commit f1e2a731cba6368d056176bc66ce19397a8a574a
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Tue Nov 27 21:09:14 2018

[client] make calculate_version unconditionally add git branch name

Strip out invalid characters automatically.

Stop throwing ValueError on long name name, simply cut the version instead,
which will cut the tag, which is now by default the branch name.

Bug: 908104
Change-Id: I7cffedc4e90f19afa800eca7b496ba2521bad30b
Reviewed-on: https://chromium-review.googlesource.com/c/1349373
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/f1e2a731cba6368d056176bc66ce19397a8a574a/appengine/components/tools/calculate_version.py
[modify] https://crrev.com/f1e2a731cba6368d056176bc66ce19397a8a574a/appengine/components/tools/calculate_version_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9df65b90cbcb9a9ea18acea4ac4ce6187b7f57f5

commit 9df65b90cbcb9a9ea18acea4ac4ce6187b7f57f5
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Wed Nov 28 18:32:45 2018

Roll infra/luci/ 430746cae..c3b934388 (17 commits)

https://chromium.googlesource.com/infra/luci/luci-py/+log/430746cae9ef..c3b934388a68

$ git log 430746cae..c3b934388 --date=short --no-merges --format='%ad %ae %s'
2018-11-27 maruel [client] check upfront for 'pool' dimension to be specified
2018-11-27 maruel [client] make calculate_version unconditionally add git branch name
2018-11-26 bradhall Make sure to setup_googletest on all slices
2018-11-26 maruel [client] Add warning about variable flags
2018-11-26 maruel [auth] Log bad request as warning
2018-11-26 maruel [swarming] Reduce error level for bad new task request
2018-11-26 sergiyb Add @chromium.org email and update my legal name
2018-11-24 maruel [swarming] Properly delete old tasks.
2018-11-24 maruel Add Intel GPU Mesa driver version on Ubuntu
2018-11-24 nodir [prpc] Implement pRPC 1.1
2018-11-21 akeshet [swarming] add external_scheduler assign and notify calls
2018-11-21 maruel [client] Stop leaking dir 'cache' when running isolateserver_test.py
2018-11-21 smut [Swarming] Add gce dimension
2018-11-20 vadimsh [auth] Add an authentication method that understands GCE VM tokens.
2018-11-20 maruel [client] internal refactoring adding ServerRef
2018-11-20 maruel [swarming] Remove forbid_unknown_pools
2018-11-20 maruel [client]: fix undefined class reference

Created with:
  roll-dep infra/luci

R=qyearsley@chromium.org

Bug: 908104
Change-Id: I2af271699f0f79d244da2996fcefe94ae6067fe3
Reviewed-on: https://chromium-review.googlesource.com/c/1351687
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19202}
[modify] https://crrev.com/9df65b90cbcb9a9ea18acea4ac4ce6187b7f57f5/DEPS

Sign in to add a comment