New issue
Advanced search Search tips

Issue 908071 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

ZipFiles/FilesAppBrowserTest.Test/zipFileOpenDownloadsEncryptedCancelPassphrase fails on linux-chromeos-rel

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Nov 23

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of futhark@google.com

browser_tests failing on chromium.chromiumos/linux-chromeos-rel

Builders failed on: 
- linux-chromeos-rel: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel


 
Components: Platform>Apps>FileManager
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9703d737459b10164a2386a4dec967592100d67e

commit 9703d737459b10164a2386a4dec967592100d67e
Author: Rune Lillesveen <futhark@chromium.org>
Date: Fri Nov 23 14:54:22 2018

Disable failing zipFileOpenDownloadsEncryptedCancelPassphrase.

linux-chromeos-rel currently fails this test.

TBR=amistry@chromium.org

Bug:  908071 
Change-Id: Iff70ff9c3cc4eb455b48f4effaa3befc441d52b4
Reviewed-on: https://chromium-review.googlesource.com/c/1349345
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610609}
[modify] https://crrev.com/9703d737459b10164a2386a4dec967592100d67e/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Labels: -Sheriff-Chromium
Owner: amistry@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/797896559c40b9184341ae0d629e33c0a43a6b67

commit 797896559c40b9184341ae0d629e33c0a43a6b67
Author: Nicolás Peña Moreno <npm@chromium.org>
Date: Fri Nov 23 15:47:53 2018

Revert "Disable failing zipFileOpenDownloadsEncryptedCancelPassphrase."

This reverts commit 9703d737459b10164a2386a4dec967592100d67e.

Reason for revert: compile failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Builder/42183

Original change's description:
> Disable failing zipFileOpenDownloadsEncryptedCancelPassphrase.
> 
> linux-chromeos-rel currently fails this test.
> 
> TBR=amistry@chromium.org
> 
> Bug:  908071 
> Change-Id: Iff70ff9c3cc4eb455b48f4effaa3befc441d52b4
> Reviewed-on: https://chromium-review.googlesource.com/c/1349345
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Commit-Queue: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610609}

TBR=amistry@chromium.org,futhark@chromium.org

Change-Id: Id22fd9c845a0656c16b939930a6ea37474eaec8a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  908071 
Reviewed-on: https://chromium-review.googlesource.com/c/1349497
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610614}
[modify] https://crrev.com/797896559c40b9184341ae0d629e33c0a43a6b67/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Labels: Sheriff-Chromium
The revert is going to make linux-chromeos-rel go red again. Adding Sheriff label.

Cc: amistry@chromium.org
Owner: mlamouri@chromium.org
Status: Started (was: Assigned)
I will attempt the CL that added the test as it landed yesterday.

Sign in to add a comment