Video corrupted after minimizing window (using Direct Composition)
Reported by
marytara...@yandex-team.ru,
Nov 23
|
||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.0 Safari/605.1.15 Example URL: https://www.twitch.tv Steps to reproduce the problem: 0. We have reproduced the bug using -video card Intel 530 -enabled Direct Composition -Overlay NOT supported -Windows 10 1. Open site with video content 2. Wait video to load 3. Minimize window 4. Hover browser icon to see preview What is the expected behavior? Preview is OK What went wrong? Video content is corrupted (has some artifacts) After maximizing the window, video is still corrupted for first moments Did this work before? N/A Is it a problem with Flash or HTML5? N/A Does this work in other browsers? N/A Chrome version: 70.0.3538.102 Channel: stable OS Version: Windows 10 x64 Flash Version: Contents of chrome://gpu: Graphics Feature Status Canvas: Hardware accelerated Flash: Hardware accelerated Flash Stage3D: Hardware accelerated Flash Stage3D Baseline profile: Hardware accelerated Compositing: Hardware accelerated Multiple Raster Threads: Enabled Native GpuMemoryBuffers: Software only. Hardware acceleration disabled Out-of-process Rasterization: Disabled Hardware Protected Video Decode: Unavailable Rasterization: Hardware accelerated Skia Deferred Display List: Disabled Skia Renderer: Disabled Surface Synchronization: Enabled Video Decode: Hardware accelerated Viz Service Display Compositor: Disabled WebGL: Hardware accelerated WebGL2: Hardware accelerated Driver Bug Workarounds clear_uniforms_before_first_program_use decode_encode_srgb_for_generatemipmap disable_accelerated_vpx_decode disable_discard_framebuffer disable_framebuffer_cmaa exit_on_context_lost force_cube_complete msaa_is_slow scalarize_vec_and_mat_constructor_args disabled_extension_GL_KHR_blend_equation_advanced disabled_extension_GL_KHR_blend_equation_advanced_coherent Problems Detected Older Intel GPUs cannot support protected video decoding in swap chains Disabled Features: protected_video_decode Some drivers are unable to reset the D3D device in the GPU process sandbox Applied Workarounds: exit_on_context_lost Clear uniforms before first program use on all platforms: 124764, 349137 Applied Workarounds: clear_uniforms_before_first_program_use Always rewrite vec/mat constructors to be consistent: 398694 Applied Workarounds: scalarize_vec_and_mat_constructor_args ANGLE crash on glReadPixels from incomplete cube map texture: 518889 Applied Workarounds: force_cube_complete On Intel GPUs MSAA performance is not acceptable for GPU rasterization: 527565 Applied Workarounds: msaa_is_slow Framebuffer discarding can hurt performance on non-tilers: 570897 Applied Workarounds: disable_discard_framebuffer Use GL_INTEL_framebuffer_CMAA on ChromeOS: 535198 Applied Workarounds: disable_framebuffer_cmaa Disable KHR_blend_equation_advanced until cc shaders are updated: 661715 Applied Workarounds: disable(GL_KHR_blend_equation_advanced), disable(GL_KHR_blend_equation_advanced_coherent) Decode and Encode before generateMipmap for srgb format textures on Windows: 634519 Applied Workarounds: decode_encode_srgb_for_generatemipmap VPx decoding is too slow on Intel Broadwell, Skylake, and CherryView: 616318 Applied Workarounds: disable_accelerated_vpx_decode Native GpuMemoryBuffers have been disabled, either via about:flags or command line. Disabled Features: native_gpu_memory_buffers Viz service display compositor is not enabled by default. Disabled Features: viz_display_compositor Skia renderer is not used by default. Disabled Features: skia_renderer Skia deferred display list is not used by default. Disabled Features: skia_deferred_display_list Version Information Data exported 2018-11-23T12:15:30.286Z Chrome version Chrome/70.0.3538.102 Operating system Windows NT 10.0.17134 Software rendering list URL https://chromium.googlesource.com/chromium/src/+/4bbeebac88fdc09c97265e47c205868bbd190497/gpu/config/software_rendering_list.json Driver bug list URL https://chromium.googlesource.com/chromium/src/+/4bbeebac88fdc09c97265e47c205868bbd190497/gpu/config/gpu_driver_bug_list.json ANGLE commit id 05c729f336ef 2D graphics backend Skia/70 8adc53ec0ee4bbafbd9925024df38437c0fcf88a- Command Line "C:\Program Files (x86)\Google\Chrome\Application\chrome.exe" --flag-switches-begin --flag-switches-end Driver Information Initialization time 227 In-process GPU false Passthrough Command Decoder false Sandboxed true GPU0 VENDOR = 0x8086 [Google Inc.], DEVICE= 0x1912 [ANGLE (Intel(R) HD Graphics 530 Direct3D11 vs_5_0 ps_5_0)] *ACTIVE* Optimus false AMD switchable false Desktop compositing Aero Glass Direct Composition true Supports overlays false Overlay capabilities Diagonal Monitor Size of \\.\DISPLAY2 23.7" Diagonal Monitor Size of \\.\DISPLAY1 23.7" Driver D3D12 feature level D3D 12.1 Driver Vulkan API version Vulkan API 1.1.0 Driver vendor Intel Corporation Driver version 25.20.100.6373 Driver date 10-31-2018 GPU CUDA compute capability major version 0 Pixel shader version 5.0 Vertex shader version 5.0 Max. MSAA samples 16 Machine model name Machine model version GL_VENDOR Google Inc. GL_RENDERER ANGLE (Intel(R) HD Graphics 530 Direct3D11 vs_5_0 ps_5_0) GL_VERSION OpenGL ES 2.0 (ANGLE 2.1.0.05c729f336ef) GL_EXTENSIONS GL_ANGLE_client_arrays GL_ANGLE_depth_texture GL_ANGLE_explicit_context GL_ANGLE_explicit_context_gles1 GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_pack_reverse_row_order GL_ANGLE_program_cache_control GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_color_buffer_float_rgb GL_CHROMIUM_color_buffer_float_rgba GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc_srgb GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_KHR_parallel_shader_compile GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_surfaceless_context GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object OES_compressed_EAC_R11_signed_texture OES_compressed_EAC_R11_unsigned_texture OES_compressed_EAC_RG11_signed_texture OES_compressed_EAC_RG11_unsigned_texture OES_compressed_ETC2_RGB8_texture OES_compressed_ETC2_RGBA8_texture OES_compressed_ETC2_punchthroughA_RGBA8_texture OES_compressed_ETC2_punchthroughA_sRGB8_alpha_texture OES_compressed_ETC2_sRGB8_alpha8_texture OES_compressed_ETC2_sRGB8_texture Disabled Extensions GL_KHR_blend_equation_advanced GL_KHR_blend_equation_advanced_coherent Disabled WebGL Extensions Window system binding vendor Google Inc. (adapter LUID: 000000000000a7bd) Window system binding version 1.4 (ANGLE 2.1.0.05c729f336ef) Window system binding extensions EGL_EXT_create_context_robustness EGL_ANGLE_d3d_share_handle_client_buffer EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_surface_d3d_texture_2d_share_handle EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_ANGLE_direct_composition EGL_NV_post_sub_buffer EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_CHROMIUM_sync_control EGL_EXT_pixel_format_float EGL_KHR_surfaceless_context EGL_ANGLE_display_texture_share_group EGL_ANGLE_create_context_client_arrays EGL_ANGLE_program_cache_control EGL_ANGLE_robust_resource_initialization EGL_ANGLE_create_context_extensions_enabled Direct rendering Yes Reset notification strategy 0x8252 GPU process crash count 0 Compositor Information Tile Update Mode One-copy Partial Raster Enabled GpuMemoryBuffers Status ATC Software only ATCIA Software only DXT1 Software only DXT5 Software only ETC1 Software only R_8 Software only R_16 Software only RG_88 Software only BGR_565 Software only RGBA_4444 Software only RGBX_8888 GPU_READ, SCANOUT RGBA_8888 GPU_READ, SCANOUT BGRX_8888 Software only BGRX_1010102 Software only RGBX_1010102 Software only BGRA_8888 Software only RGBA_F16 Software only YVU_420 Software only YUV_420_BIPLANAR Software only UYVY_422 Software only Display(s) Information Info Display[2528732444] bounds=[0,0 2048x1152], workarea=[0,0 2048x1112], scale=1.25, external. Color space information {primaries:BT709, transfer:IEC61966_2_1, matrix:RGB, range:FULL} Bits per color component 8 Bits per pixel 24 Info Display[2779098405] bounds=[2048,0 2048x1152], workarea=[2048,0 2048x1112], scale=1.25, external. Color space information {primaries:BT709, transfer:IEC61966_2_1, matrix:RGB, range:FULL} Bits per color component 8 Bits per pixel 24 Video Acceleration Information Decode h264 baseline up to 4096x2304 pixels Decode h264 baseline up to 2304x4096 pixels Decode h264 main up to 4096x2304 pixels Decode h264 main up to 2304x4096 pixels Decode h264 high up to 4096x2304 pixels Decode h264 high up to 2304x4096 pixels Encode h264 baseline up to 3840x2176 pixels and/or 30.000 fps Encode h264 main up to 3840x2176 pixels and/or 30.000 fps Encode h264 high up to 3840x2176 pixels and/or 30.000 fps Diagnostics 0 b3DAccelerationEnabled true b3DAccelerationExists true bAGPEnabled true bAGPExistenceValid true bAGPExists true bCanRenderWindow true bDDAccelerationEnabled true bDriverBeta false bDriverDebug false bDriverSigned false bDriverSignedValid false bNoHardware false dwBpp 32 dwDDIVersion 12 dwHeight 1440 dwRefreshRate 59 dwWHQLLevel 0 dwWidth 2560 iAdapter 0 lDriverSize 2576496 lMiniVddSize 0 szAGPStatusEnglish Enabled szAGPStatusLocalized Вкл szChipType Intel(R) HD Graphics Family szD3DStatusEnglish Enabled szD3DStatusLocalized Вкл szDACType Internal szDDIVersionEnglish 12 szDDIVersionLocalized 12 szDDStatusEnglish Enabled szDDStatusLocalized Вкл szDXVAHDEnglish Supported szDXVAModes ModeMPEG2_A ModeMPEG2_C ModeWMV9_C ModeVC1_C szDescription Intel(R) HD Graphics 530 szDeviceId 0x1912 szDeviceIdentifier {D7B78E66-5A52-11CF-166B-F0A6BDC2D435} szDeviceName \\.\DISPLAY1 szDisplayMemoryEnglish 8247 MB szDisplayMemoryLocalized 8247 MB szDisplayModeEnglish 2560 x 1440 (32 bit) (59Hz) szDisplayModeLocalized 2560 x 1440 (32 bit) (59Hz) szDriverAssemblyVersion 25.20.100.6373 szDriverAttributes Final Retail szDriverDateEnglish 31.10.2018 3:00:00 szDriverDateLocalized 10/31/2018 03:00:00 szDriverLanguageEnglish English szDriverLanguageLocalized Английский szDriverModelEnglish WDDM 2.1 szDriverModelLocalized WDDM 2.1 szDriverName C:\windows\System32\DriverStore\FileRepository\igdlh64.inf_amd64_6ae0ddbb4a38e23c\igdumdim64.dll,C:\windows\System32\DriverStore\FileRepository\igdlh64.inf_amd64_6ae0ddbb4a38e23c\igd10iumd64.dll,C:\windows\System32\DriverStore\FileRepository\igdlh64.inf_amd64_6ae0ddbb4a38e23c\igd10iumd64.dll,C:\windows\System32\DriverStore\FileRepository\igdlh64.inf_amd64_6ae0ddbb4a38e23c\igd12umd64.dll szDriverNodeStrongName oem7.inf:5f63e53470659c00:iSKLD_w10_DS:25.20.100.6373:pci\ven_8086&dev_1912 szDriverSignDate Unknown szDriverVersion 25.20.0100.6373 szKeyDeviceID Enum\PCI\VEN_8086&DEV_1912&SUBSYS_86941043&REV_06 szKeyDeviceKey \Registry\Machine\System\CurrentControlSet\Control\Video\{FD3A7D09-D200-11E8-AB98-80B7E82917CB}\0000 szManufacturer Intel Corporation szMiniVdd Нет данных szMiniVddDateEnglish Unknown szMiniVddDateLocalized Нет данных szMonitorMaxRes Unknown szMonitorName Generic PnP Monitor szNotesEnglish No problems found. szNotesLocalized Неполадок не найдено. szOverlayEnglish Supported szRankOfInstalledDriver 00D12001 szRegHelpText Unknown szRevision Unknown szRevisionId 0x0006 szSubSysId 0x86941043 szTestResultD3D7English Not run szTestResultD3D7Localized Не выполнена szTestResultD3D8English Not run szTestResultD3D8Localized Не выполнена szTestResultD3D9English Not run szTestResultD3D9Localized Не выполнена szTestResultDDEnglish Not run szTestResultDDLocalized Не выполнена szVdd Нет данных szVendorId 0x8086 1 b3DAccelerationEnabled true b3DAccelerationExists true bAGPEnabled true bAGPExistenceValid true bAGPExists true bCanRenderWindow true bDDAccelerationEnabled true bDriverBeta false bDriverDebug false bDriverSigned false bDriverSignedValid false bNoHardware false dwBpp 32 dwDDIVersion 12 dwHeight 1440 dwRefreshRate 59 dwWHQLLevel 0 dwWidth 2560 iAdapter 1 lDriverSize 2576496 lMiniVddSize 0 szAGPStatusEnglish Enabled szAGPStatusLocalized Вкл szChipType Intel(R) HD Graphics Family szD3DStatusEnglish Enabled szD3DStatusLocalized Вкл szDACType Internal szDDIVersionEnglish 12 szDDIVersionLocalized 12 szDDStatusEnglish Enabled szDDStatusLocalized Вкл szDXVAHDEnglish Supported szDXVAModes ModeMPEG2_A ModeMPEG2_C ModeWMV9_C ModeVC1_C szDescription Intel(R) HD Graphics 530 szDeviceId 0x1912 szDeviceIdentifier {D7B78E66-5A52-11CF-166B-F0A6BDC2D435} szDeviceName \\.\DISPLAY2 szDisplayMemoryEnglish 8247 MB szDisplayMemoryLocalized 8247 MB szDisplayModeEnglish 2560 x 1440 (32 bit) (59Hz) szDisplayModeLocalized 2560 x 1440 (32 bit) (59Hz) szDriverAssemblyVersion 25.20.100.6373 szDriverAttributes Final Retail szDriverDateEnglish 31.10.2018 3:00:00 szDriverDateLocalized 10/31/2018 03:00:00 szDriverLanguageEnglish English szDriverLanguageLocalized Английский szDriverModelEnglish WDDM 2.1 szDriverModelLocalized WDDM 2.1 szDriverName C:\windows\System32\DriverStore\FileRepository\igdlh64.inf_amd64_6ae0ddbb4a38e23c\igdumdim64.dll,C:\windows\System32\DriverStore\FileRepository\igdlh64.inf_amd64_6ae0ddbb4a38e23c\igd10iumd64.dll,C:\windows\System32\DriverStore\FileRepository\igdlh64.inf_amd64_6ae0ddbb4a38e23c\igd10iumd64.dll,C:\windows\System32\DriverStore\FileRepository\igdlh64.inf_amd64_6ae0ddbb4a38e23c\igd12umd64.dll szDriverNodeStrongName oem7.inf:5f63e53470659c00:iSKLD_w10_DS:25.20.100.6373:pci\ven_8086&dev_1912 szDriverSignDate Unknown szDriverVersion 25.20.0100.6373 szKeyDeviceID Enum\PCI\VEN_8086&DEV_1912&SUBSYS_86941043&REV_06 szKeyDeviceKey \Registry\Machine\System\CurrentControlSet\Control\Video\{FD3A7D09-D200-11E8-AB98-80B7E82917CB}\0001 szManufacturer Intel Corporation szMiniVdd Нет данных szMiniVddDateEnglish Unknown szMiniVddDateLocalized Нет данных szMonitorMaxRes Unknown szMonitorName Generic PnP Monitor szNotesEnglish No problems found. szNotesLocalized Неполадок не найдено. szOverlayEnglish Supported szRankOfInstalledDriver 00D12001 szRegHelpText Unknown szRevision Unknown szRevisionId 0x0006 szSubSysId 0x86941043 szTestResultD3D7English Not run szTestResultD3D7Localized Не выполнена szTestResultD3D8English Not run szTestResultD3D8Localized Не выполнена szTestResultD3D9English Not run szTestResultD3D9Localized Не выполнена szTestResultDDEnglish Not run szTestResultDDLocalized Не выполнена szVdd Нет данных szVendorId 0x8086 Log Messages GpuProcessHostUIShim: GpuProcessHostUIShim: Bug is not reproduced after disabling Direct Composition
,
Nov 26
Unable to reproduce the issue on chrome reported version# 70.0.3538.102 using Windows-10 with steps mentioned below: 1) Launched chrome reported version and navigated to URL: https://www.twitch.tv 2) Played a video, minimizes the browser window once video got loaded 3) Hovered the mouse over the chrome icon, in the preview window able to see the video, clicked on the preview window, able to see video playing when video got maximized @Reporter: Please find the attached screencast for your reference and GPU details. Try to test this issue on latest chrome stable# 70.0.3538.110 with no apps and extensions in it and let us know if the issue still persists. You can download latest chrome stable from URL: https://www.chromium.org/getting-involved/dev-channel. Thanks!
,
Nov 26
Note: Report from Yandex.
,
Nov 26
Video corruption for a few moments after maximizing is probably because we don't resize video swap chains for 30 frames. I'm working towards removing that workaround by using swap chain's ResizeBuffers API directly.
,
Nov 26
,
Nov 26
By the way, I also can't reproduce this issue on my Win10 laptop with Intel UHD 620, direct composition supported, hardware overlay not supported. I am not exactly the same GPU as yours, but config is similar. sunnyps@'s educated guess is likely on spot, however, I am surprised the issue is not observed everywhere. reporter: if you disconnect from the second monitor, does the issue still happen the same?
,
Nov 26
You can reproduce corruption if you resize Chrome window to a very small size while video is paused, move mouse around (or move the window), then resize to a large size quickly and don't interact with the video any more.
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d79a26ac268c66ea93b522a279f478cdea63144 commit 8d79a26ac268c66ea93b522a279f478cdea63144 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Wed Nov 28 04:05:23 2018 Remove swap chain resize delay optimization This causes video corruption when swap chain is resized to a small size and then resized back to a large size. If the swap chain doesn't update after resizing back, it will remain with the smaller size. It's also likely that this causes video corruption issues with minimize and restore, and with the Aero peek live preview Windows feature. Split out from crrev.com/1305198 because that change is more risky and we want to wait until M72 branches to land it. Bug: 908069 Change-Id: I8a3edde507bca836dbf321b8ebc4e486415d193b Reviewed-on: https://chromium-review.googlesource.com/c/1352771 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#611554} [modify] https://crrev.com/8d79a26ac268c66ea93b522a279f478cdea63144/gpu/ipc/service/direct_composition_surface_win.cc [modify] https://crrev.com/8d79a26ac268c66ea93b522a279f478cdea63144/gpu/ipc/service/direct_composition_surface_win.h [modify] https://crrev.com/8d79a26ac268c66ea93b522a279f478cdea63144/gpu/ipc/service/direct_composition_surface_win_unittest.cc
,
Dec 1
marytarasova@yandex-team.ru: I think the fix is already in the Canary. Can you confirm if the bug is no longer there?
,
Dec 4
Bug is still reproduced in Build version: 73.0.3630 - 613412
,
Dec 10
lof84@: can you try Chrome Canary? Since sunnyps@ landed a potential fix in #8.
,
Dec 12
The bug is still reproduced in Build version: 73.0.3637.0 WTR: 1) Open https://www.twitch.tv/cornerbackbread/clip/AntediluvianLittleWaspBatChest?filter=clips&range=7d&sort=time 2) Minimize the browser window. 3) Hover browser icon to see a preview. Screenshot and GPU info in attach.
,
Dec 12
I checked the chrome://gpu in this bug description. This machine has Intel 530 Graphics (Skylake) chip. But hardware overlay is NOT supported. If we want to repro this bug, we might need to find a system with the same configuration.
,
Dec 12
lol84@ can you attach the contents of chrome://version especially the "Variations" field and also the contents of chrome://media-internals while the video is playing (we want the "video_decoder" field in particular).
,
Dec 13
I am a bit confused. Original bug reports is about the minimized window's preview being corrupted, but now it seems the entire Chrome is corrupted (after un-minimize again)?
,
Dec 13
zmo@ as I said in the first report "After maximizing the window, video is still corrupted for first moments". This problem existed from the beginning.
,
Dec 13
The bug is still reproduced in Build version: 73.0.3640.0 WTR: 1) Open https://www.youtube.com/watch?v=LCx41ZcavcA 2) Minimize the browser window. 3) Hover browser icon to see a preview. Screenshot, GPU, version, media-internals in attach.
,
Dec 13
lof84@yandex-team.ru: Intel HD 530 is not uncommon, but this is the only report of such issue. I suspect it's something specific due to your machine. Since we can't reproduce it on our side, it's challenging to dig deeper. But we can work with you and see if we can pin-point what's going on there. A few things: 1) before trying anything else, please go to chrome://version/?show-variations-cmd and save the text and attach here 2) can you disconnect the second monitor and see if you still reproduce with single monitor 3) Run chrome with a clean new profile by --user-data-dir=c:\tmp\shd (some new path), and see if you can still reproduce All the above tests, please use Chrome Canary and make sure it's up to date
,
Dec 14
It's strange but on every Intel HD 530, that we have, we can reproduce this bug. Important thing: Intel drivers must be >= 24 version. Video (with the single monitor): https://yadi.sk/i/pnwThkk1bkC9xg
,
Dec 14
Gaurav: this is another instance that a Skylake device doesn't have hardware overlay support. See the attached about:gpu in #20.
,
Dec 14
More flags to try: 1) --disable-features=video-blit-color-accuracy 2) --disable_dxgi_zero_copy_video=1 3) --disable_delayed_copy_nv12=1 4) --disable_nv12_dxgi_video=1 5) --disable-accelerated-video-decode (Yes, we have lots of flags.)
,
Dec 14
Dale FYI
,
Dec 14
I tried with an Intel HD 520, where I have to disable hardware overlay support (--disable-direct-composition-layers) so Chrome runs down the same code path as your Intel HD 530, but no luck reproducing. To also make sure it's not some Chrome experiment triggering the issue, I split the Chrome variations you run with (from version.html) into four. Can you launch Chrome in "Command Prompt" with them in turn (don't use Power Shell), and each time run with a clean profile (--user-data-dir=some_new_folder). Let me know if you can reproduce the bug with all four runs or only one of them (and which one).
,
Dec 15
Also, I am curious if this has something to do with the size. Instead of minimizing the Window, could you scale the Window to the size similar to the preview Window size, go back to large Window, and go small again... a few times, and see if you can also reproduce this Window? When you get to the small size Windows, make sure stay that size a bit so Chrome can size down.
,
Dec 15
ynag.gu: I am wondering if you may have an Intel HD 530 in house that could reproduce this bug? Look very much like a driver bug to me.
,
Dec 17
I just tried a Skylake (HD 530) desktop at hand, but couldn't repro the issue. Below are my steps. 1. Use latest Chrome Canary 73.0.3642.0. 2. My hardware overlay is supported, so I added "--disable-direct-composition-layers" to disable it. 3. Open https://www.youtube.com/watch?v=LCx41ZcavcA 4. Minimize the browser window. 5. Hover browser icon to see a preview. My chrome://GPU and preview are attached. BTW, my driver is 24.20.100.6136. lof84@, could you please update to latest graphics driver to have a try (https://downloadcenter.intel.com/download/28139/Intel-Graphics-Driver-for-Windows-10?product=80939)?
,
Dec 17
yang: thanks for trying. Looking from the video in #20, you need to minimize/preview/maximize a couple times to be able to reproduce.
,
Dec 18
I gave some more tries with more minimize/preview/maximize, but still couldn't repro the issue. I'd like to know if latest driver could fix the issue, as hardware overlay should be by default supported in this device.
,
Dec 18
Driver version 25.20.100.6444 1) --disable-features=video-blit-color-accuracy - bug 2) --disable_dxgi_zero_copy_video=1 - bug 3) --disable_delayed_copy_nv12=1 - bug 4) --disable_nv12_dxgi_video=1 - bug 5) --disable-accelerated-video-decode - bug cmd_4_1 - bug cmd_4_2 - browser doesn't run. Try to change "Improved Recovery Component" to "ImprovedRecoveryComponent" - NO bug! cmd_4_3 - bug cmd_4_4 - bug
,
Dec 18
"Instead of minimizing the Window, could you scale the Window to the size similar to the preview Window size, go back to large Window, and go small again... a few times, and see if you can also reproduce this Window? When you get to the small size Windows, make sure stay that size a bit so Chrome can size down." No bug, but I will try more times.
,
Dec 18
Interesting experiments from cmd_4_2: DefaultPassthroughCommandDecoder/Enabled (--enable-features=DefaultPassthroughCommandDecoder) DirectCompositionPreferNV12Overlays/Enabled (--enable-feature=DirectCompositionPreferNV12Overlays) MojoVideoDecoderWin/DecodeSwapChainV4 (--enable-features=MojoVideoDecoder,D3D11VideoDecoder,D3D11VP9Decoder,DirectCompositionUseNV12DecodeSwapChain) I don't think these experiments are responsible though because original report was on M70 where all except MojoVideoDecoder don't apply, and MojoVideoDecoder shouldn't cause these artifacts, but it doesn't hurt to verify using --disable-features=MojoVideoDecoder.
,
Dec 19
OK, first, I have a CL ready for landing, which will turn off direct composition on HD 530 if hardware overlay support is missing: https://chromium-review.googlesource.com/c/chromium/src/+/1381832 However, lof84@yandex-team.ru, since the issue is gone with cmd_4_2, I am curious what exactly is affecting this bug. Attached are four sets of commandline switches, which I split further from cmd_4_2. This time please launch Chrome with --user-data-dir=some_new_folder and one of the sets through "Windows PowerShell". This is to work around the white space in a feature name.
,
Dec 19
1) cmd_4_2_4_1 - bug 2) cmd_4_2_4_2 - bug 3) cmd_4_2_4_3 - bug 4) cmd_4_2_4_4 - bug So we tested cmd_4_2 again and reproduced this bug, sorry :( I will wait for zmo@ CL for land.
,
Dec 19
OK, landing this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1381832
,
Dec 19
Some observations/speculation: 1) This isn't related to video decoding since lof84@ ran this with hardware video decode acceleration. Maybe we should verify this - lof84@, can you please provide chrome://gpu output when you pass the --disable-accelerated-video-decode flag and the bug reproduces? 2) This looks like a synchronization issue like GPU is not done with back buffer when we try to present. 3) Why does it only affect the video part of the Chrome window? Probably because it's the only thing updating so we pass that as the dirty rect to Present. 4) Maybe we could prevent it by waiting for GPU to finish executing commands after minimize/restore? 5) It's still unknown why the corruption happens in Windows live preview. AFAIK that rendering is done by Windows (DWM) using the front-buffer of our swap chain. Maybe what causes the corruption is that the Present happens after minimize, but DWM doesn't synchronize properly in that state.
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb4b16caf691e921c62c5dfddc092dff92b72b74 commit eb4b16caf691e921c62c5dfddc092dff92b72b74 Author: Zhenyao Mo <zmo@chromium.org> Date: Wed Dec 19 23:13:45 2018 Disable direct composition on Intel HD 530 without overlay support This is to avoid a video corruption issue which we believe is a driver bug. Note that we limit to only systems without hardware overlay support. This is because this workaround has perf regressions for playing videos in fullscreen. This is Intel SkyLake GPU, so it does have hardware overlay support in many devices, and this workaround won't apply to them, so minimizing the perf impact of this CL. BUG= 908069 TEST=gpu_unittests, bug reporter manual test R=kbr@chromium.org Change-Id: Id3075c6415c73727a7531516fb21ef3f1af63b93 Reviewed-on: https://chromium-review.googlesource.com/c/1381832 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#618000} [modify] https://crrev.com/eb4b16caf691e921c62c5dfddc092dff92b72b74/content/browser/gpu/gpu_data_manager_testing_arrays_and_structs_autogen.h [modify] https://crrev.com/eb4b16caf691e921c62c5dfddc092dff92b72b74/gpu/config/gpu_control_list.cc [modify] https://crrev.com/eb4b16caf691e921c62c5dfddc092dff92b72b74/gpu/config/gpu_control_list.h [modify] https://crrev.com/eb4b16caf691e921c62c5dfddc092dff92b72b74/gpu/config/gpu_control_list_entry_unittest.cc [modify] https://crrev.com/eb4b16caf691e921c62c5dfddc092dff92b72b74/gpu/config/gpu_control_list_format.txt [modify] https://crrev.com/eb4b16caf691e921c62c5dfddc092dff92b72b74/gpu/config/gpu_control_list_testing.json [modify] https://crrev.com/eb4b16caf691e921c62c5dfddc092dff92b72b74/gpu/config/gpu_control_list_testing_arrays_and_structs_autogen.h [modify] https://crrev.com/eb4b16caf691e921c62c5dfddc092dff92b72b74/gpu/config/gpu_control_list_testing_autogen.cc [modify] https://crrev.com/eb4b16caf691e921c62c5dfddc092dff92b72b74/gpu/config/gpu_control_list_testing_entry_enums_autogen.h [modify] https://crrev.com/eb4b16caf691e921c62c5dfddc092dff92b72b74/gpu/config/gpu_driver_bug_list.json [modify] https://crrev.com/eb4b16caf691e921c62c5dfddc092dff92b72b74/gpu/config/process_json.py
,
Dec 20
We won't take any further actions at this point, so mark this as fixed. |
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by viswa.karala@chromium.org
, Nov 25