Regression:Chrome webstore icon appears changed on zooming out on NTP
Reported by
vineetha...@etouch.net,
Nov 23
|
||||||||
Issue descriptionChrome Version: 72.0.3619.0 (Official Build) Revision c1cb2d33f1513aa3900c3fce0470cf76faad4458-refs/branch-heads/3619@{#1}(32/64-Bit) OS: Windows(7,8,8.1,10), Mac (10.13.1, 10.13.6, 10.14.2) and Linux(14.04) Pre-condition: Enable "Enable using the Google local NTP" ,"New Tab Page Background Selection" and "New Tab Page Custom Links" flags under chrome://flags. What steps will reproduce the problem? 1. Launch chrome, open NTP, observe chrome webstore shortcut is present on NTP by default. 2. Press Ctrl -- to zoom out NTP to around 50%. 3. Now remove the chrome webstore shortcut and restore it again and observe. Actual Result : Chrome webstore icon appears changed on zooming out on NTP. Expected Result: Chrome webstore icon should not get changed on zooming out on NTP This is a regression issue broken in ‘M-70’ and below is the per-revision bisect information: Good Build : 70.0.3501.0 (Revision : 577394) Bad Build : 70.0.3503.0 (Revision : 578159) You are probably looking for a change made after 577577 (known good), but no later than 577578 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/5dae36ddb2752c013b75cb63e260e090fd1aa161..d8b6230848f81a3308998bf3cf97edff2f657a09 Suspect : https://chromium.googlesource.com/chromium/src/+/d8b6230848f81a3308998bf3cf97edff2f657a09 @mathp : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank you
,
Nov 26
,
Nov 26
Noting that this is only for the default webstore tile icon. Regular favicons/fallback icons are not affected.
,
Nov 26
,
Nov 26
,
Nov 27
,
Nov 30
,
Dec 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3812b6f65b2355b5241761bcb3d018a963429d67 commit 3812b6f65b2355b5241761bcb3d018a963429d67 Author: Kristi Park <kristipark@chromium.org> Date: Mon Dec 03 15:39:03 2018 [NTP] Resize prepopulated page favicons if necessary Previously, the favicons were not resized at all. Add functionality to resize the favicons to the proper pixel width/height. Bug: 908051 Change-Id: Ie81f1675575d5d8f66be686db2d78e40124412e8 Reviewed-on: https://chromium-review.googlesource.com/c/1357570 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#613093} [modify] https://crrev.com/3812b6f65b2355b5241761bcb3d018a963429d67/chrome/browser/search/ntp_icon_source.cc
,
Dec 3
,
Dec 4
Update: Rechecked the above issue on Windows (7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2), Linux(14.04 LTS) OS using latest Canary build #73.0.3630.0 and the issue is fixed. Kindly refer attached screen cast. Thank you |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mathp@google.com
, Nov 23