TWA doesn't hide toolbar on return to verified origin when Activity is killed |
|||||||||
Issue description1. Go into Android developer options and enabled "Don't keep activities". 2. Open a TWA. 3. Leave the verified origin. 4. Switch to another app. 5. Switch back to the TWA. 6. Press the Android back button, navigating back to a page on the verified origin. Observed: 7. Toolbar is still present. Expected: 7. Toolbar is dismissed.
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c90e8c1c990f9284d77cda0816bb10a30f5be5ab commit c90e8c1c990f9284d77cda0816bb10a30f5be5ab Author: Pavel Shmakov <pshmakov@google.com> Date: Wed Dec 05 20:24:06 2018 Remove IsInVr check from render_widget_host_view_android.cc This check was reintroduced in https://crbug.com/853686 because reader mode seems to have relied on not receiving the first toolbar offset update. This, however, introduces a bug with toolbar not hiding when re-entering a Trusted Web Activity after activity re-creation (see steps in the linked bug). The original reader mode bug doesn't reproduce, so we hopefully can remove the check. Bug: 908037 Change-Id: I398e68b242b597e8e1af9acc627cc18c91c6ac4c Reviewed-on: https://chromium-review.googlesource.com/c/1363286 Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#614076} [modify] https://crrev.com/c90e8c1c990f9284d77cda0816bb10a30f5be5ab/content/browser/renderer_host/render_widget_host_view_android.cc
,
Dec 6
,
Dec 12
,
Dec 12
Marking this bug as "Started" because I think that bugs need to be marked as "Started" in order to request a merge
,
Dec 12
,
Dec 13
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 13
Pls merge your change to M72 branch 3626 ASAP. Thank you.
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5432d5f309441f6af83703fe74a845e8f1c77b02 commit 5432d5f309441f6af83703fe74a845e8f1c77b02 Author: Pavel Shmakov <pshmakov@google.com> Date: Thu Dec 13 09:57:45 2018 Remove IsInVr check from render_widget_host_view_android.cc This check was reintroduced in https://crbug.com/853686 because reader mode seems to have relied on not receiving the first toolbar offset update. This, however, introduces a bug with toolbar not hiding when re-entering a Trusted Web Activity after activity re-creation (see steps in the linked bug). The original reader mode bug doesn't reproduce, so we hopefully can remove the check. TBR: mdjones@chromium.org, kenrb@chromium.org Bug: 908037 Change-Id: I398e68b242b597e8e1af9acc627cc18c91c6ac4c Reviewed-on: https://chromium-review.googlesource.com/c/1363286 Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614076}(cherry picked from commit c90e8c1c990f9284d77cda0816bb10a30f5be5ab) Reviewed-on: https://chromium-review.googlesource.com/c/1374984 Reviewed-by: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#321} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/5432d5f309441f6af83703fe74a845e8f1c77b02/content/browser/renderer_host/render_widget_host_view_android.cc
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5432d5f309441f6af83703fe74a845e8f1c77b02 Commit: 5432d5f309441f6af83703fe74a845e8f1c77b02 Author: pshmakov@google.com Commiter: pshmakov@chromium.org Date: 2018-12-13 09:57:45 +0000 UTC Remove IsInVr check from render_widget_host_view_android.cc This check was reintroduced in https://crbug.com/853686 because reader mode seems to have relied on not receiving the first toolbar offset update. This, however, introduces a bug with toolbar not hiding when re-entering a Trusted Web Activity after activity re-creation (see steps in the linked bug). The original reader mode bug doesn't reproduce, so we hopefully can remove the check. TBR: mdjones@chromium.org, kenrb@chromium.org Bug: 908037 Change-Id: I398e68b242b597e8e1af9acc627cc18c91c6ac4c Reviewed-on: https://chromium-review.googlesource.com/c/1363286 Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614076}(cherry picked from commit c90e8c1c990f9284d77cda0816bb10a30f5be5ab) Reviewed-on: https://chromium-review.googlesource.com/c/1374984 Reviewed-by: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#321} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Dec 27
Can we mark this fixed?
,
Dec 28
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by pshmakov@chromium.org
, Dec 5