New issue
Advanced search Search tips

Issue 908015 link

Starred by 2 users
Status: Fixed
Owner:
johntlee@chromium.org
Closed: Jan 17
Cc:
ajha@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Separator line is missing at the bottom of advanced section in clearBrowserData overlay

Project Member Reported by rkalavakuntla@chromium.org, Nov 23 
Chrome Version:72.0.3612.0/11287.0.0 dev channel Quawks,Falco,Minnie
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign into user,go to chrome://settings/clearBrowserData >> Advanced
(2)Scroll down the page and observe no separator line as continuation

Actual: Separator line is missing at the bottom of advanced section in clearBrowserData overlay
Expected: Separator line should be seen at the bottom of advanced section in clearBrowserData overlay

This is a Regression as same works fine in M-69

Note: 
1.Issue is also seen in M-70stable, M-71 beta
2.Issue is not seen in Windows OS
Actual.png
123 KB View Download
Expected.jpg
2.8 MB View Download

Comment 1 by dpa...@chromium.org, Jan 15

Owner: johntlee@chromium.org
Status: Assigned (was: Untriaged)
@johntlee: Can you take a look? This is happening on CrOS, but not on Linux.

Comment 2 by johntlee@chromium.org, Jan 16

Status: Started (was: Assigned)

Comment 3 by johntlee@chromium.org, Jan 16 (6 days ago) 

Fixed: https://chromium-review.googlesource.com/c/chromium/src/+/1413360
clear-browsing-data.png
40.7 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 17 (6 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abbf44639a673016e9b0b26dd10482c182de27ef

commit abbf44639a673016e9b0b26dd10482c182de27ef
Author: John Lee <johntlee@chromium.org>
Date: Thu Jan 17 01:14:58 2019

WebUI: Add separator line back to dialogs for ChromeOS

With the way @apply works, the !important here was causing the
border-bottom to always be the initial values of border-bottom
(solid 1px transparent)[1] and override the bottom-border on
scrollable bodies [2].

[1] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html?q=cr_dialog.html&sq=package:chromium&g=0&l=117
[2] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html?q=cr_dialog.html&sq=package:chromium&g=0&l=130

Bug:  908015 
Change-Id: Ie0a5e72eb0f7d0beb724468d3d9f534ae79f6225
Reviewed-on: https://chromium-review.googlesource.com/c/1413360
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623493}
[modify] https://crrev.com/abbf44639a673016e9b0b26dd10482c182de27ef/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_elements.html

Comment 5 by johntlee@chromium.org, Jan 17 (6 days ago)

Status: Fixed (was: Started)
►

Sign in to add a comment