New issue
Advanced search Search tips

Issue 908010 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Add EG tests for Switch to Open Tab

Project Member Reported by gambard@chromium.org, Nov 23

Issue description

See description
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/081003553fcad3e6a4ad34559bd37f72815dec25

commit 081003553fcad3e6a4ad34559bd37f72815dec25
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Nov 23 15:26:56 2018

[iOS] Add EG for Switch to Tab feature

This CL adds EG test for testing the Switch to Open Tab feature. The
covered test cases are:
- Check that it is possible to switch to an open tab,
- Check that if you switch tab, your previous tab isn't closed,
- Check that the incognito tabs aren't taken into account in
  non-incognito and vice-versa,
- Check that the current page doesn't have the switch button.

Bug:  908010 
Change-Id: I9434ef8cf2b41b55ab59f70aec48aea282d2401e
Reviewed-on: https://chromium-review.googlesource.com/c/1349331
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610612}
[modify] https://crrev.com/081003553fcad3e6a4ad34559bd37f72815dec25/ios/chrome/browser/ui/omnibox/popup/BUILD.gn
[add] https://crrev.com/081003553fcad3e6a4ad34559bd37f72815dec25/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_egtest.mm
[modify] https://crrev.com/081003553fcad3e6a4ad34559bd37f72815dec25/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_row.h
[modify] https://crrev.com/081003553fcad3e6a4ad34559bd37f72815dec25/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_row.mm
[modify] https://crrev.com/081003553fcad3e6a4ad34559bd37f72815dec25/ios/chrome/test/earl_grey/BUILD.gn

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a49a188c2115ebe2e29f242812168b41f2c5e1f4

commit a49a188c2115ebe2e29f242812168b41f2c5e1f4
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Nov 27 16:03:33 2018

[iOS] Close NTP when switching tab

When the user switch from a NTP which doesn't have a back/forward
history to an open tab, the tab should be closed.

Bug:  908010 ,  908409 
Change-Id: Ie4c783bef4c43ddafa175ba5796bd2a0b05cc54c
Reviewed-on: https://chromium-review.googlesource.com/c/1349264
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611123}
[modify] https://crrev.com/a49a188c2115ebe2e29f242812168b41f2c5e1f4/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/a49a188c2115ebe2e29f242812168b41f2c5e1f4/ios/chrome/browser/ui/omnibox/popup/BUILD.gn
[modify] https://crrev.com/a49a188c2115ebe2e29f242812168b41f2c5e1f4/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_egtest.mm

Status: Fixed (was: Assigned)

Sign in to add a comment