New issue
Advanced search Search tips

Issue 908009 link

Starred by 1 user
Status: Fixed
Owner:
vasi...@chromium.org
Closed: Nov 23
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Password bubble anchored improperly

Project Member Reported by vasi...@chromium.org, Nov 23 
Chrome Version: 72.0.3619.0
OS: Mac

What steps will reproduce the problem?
(1) Open the browser in a fullscreen
(2) Login on any site
(3) See the password bubble

What is the expected result?
The bubble is docked to the omnibar.

What happens instead?
The bubble is in the top-right corner of the screen.
Screen Shot 2018-11-23 at 10.50.04.png
21.9 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ba3e2c06a0c471f9536757f0e03a7cb8ddc53fd

commit 3ba3e2c06a0c471f9536757f0e03a7cb8ddc53fd
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Nov 23 10:34:07 2018

Anchor the save bubble to the omnibar whenever it exists.

The obsolete code used to check the fullscreen state which is irrelevant.

Bug:  908009 
Change-Id: Ide457470aa4226843d611d043260dfef420087e7
Reviewed-on: https://chromium-review.googlesource.com/c/1349216
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610563}
[modify] https://crrev.com/3ba3e2c06a0c471f9536757f0e03a7cb8ddc53fd/chrome/browser/ui/views/passwords/password_bubble_view_base.cc

Comment 2 by vasi...@chromium.org, Nov 23

Status: Fixed (was: Started)

Comment 3 by susan.boorgula@chromium.org, Nov 26

Labels: TE-Verified-M72 TE-Verified-72.0.3621.0
Able to reproduce this issue on Mac OS 10.13.6 on the reported version 72.0.3619.0 and the issue is fixed on the latest M-72 build 72.0.3621.0.

1. Launched Chrome in fullscreen and logged into Facebook.com
2. Clicked on the password bubble and could observe that the password bubble is positioned below the omnibar.
Attached is the screen shot for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..
908009-M72.png
67.8 KB View Download
►

Sign in to add a comment