New issue
Advanced search Search tips

Issue 908003 link

Starred by 2 users
Status: Fixed
Owner:
aee@chromium.org
Closed: Nov 28
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Font size' & 'Minimum font size' size slider button is not seen properly.

Reported by dchau...@etouch.net, Nov 23 
Chrome Version: 72.0.3619.0 (Official Build) Revision	c1cb2d33f1513aa3900c3fce0470cf76faad4458-refs/branch-heads/3619@{#1} (32/64-bit)
OS: Windows (7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2).

What steps will reproduce the problem?
1. Launch Chrome, navigate to chrome://settings/fonts and observe.

Actual: 'Font size' & 'Minimum font size' size slider buttons are not seen properly.
Expected: 'Font size' & 'Minimum font size' size slider buttons are not seen properly.

This is a regression issue, broken in M-72 series, will soon update bisect info.

Kindly review the attached screen-cast for reference.

Thank you.
Slider_Screenshot.png
15.3 KB View Download
Actual behavior.mp4
207 KB View Download
Expected behavior.mp4
149 KB View Download

Comment 1 by dchau...@etouch.net, Nov 23

Labels: hasbisect-per-revision OS-Linux
Owner: aee@chromium.org
Status: Assigned (was: Unconfirmed)
Below is manual regression range:

Good build: 72.0.3618.0 (Revision: 610279)
Bad build: 72.0.3619.0 (Revision: 610515)

You are probably looking for a change made after 610338 (known good), but no later than 610339 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/9ed95380941759c1df3832216887af600fdaf6ed..1c8d73b56bafcbf0df5cbc2b5361b2fe3549bf16

Suspecting: https://chromium.googlesource.com/chromium/src/+/1c8d73b56bafcbf0df5cbc2b5361b2fe3549bf16

@aee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: This issue is also reproducible on Linux 140.4 LTS OS.

Thank you.

Comment 2 by aee@chromium.org, Nov 28

Status: Started (was: Assigned)

Comment 3 by aee@chromium.org, Nov 28 

Screenshot for https://chromium-review.googlesource.com/c/chromium/src/+/1352944/.
sliders.png
53.7 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c220499359e1f37f3fca2d7cadfda07eca06cf8e

commit c220499359e1f37f3fca2d7cadfda07eca06cf8e
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Wed Nov 28 23:11:24 2018

WebUI: cr-slider, update obsolete Shadow DOM v0 CSS var fallback syntax

Bug:  908003 
Change-Id: Iada2d816073d4f38cd0438838548d10f94d5b7db
Reviewed-on: https://chromium-review.googlesource.com/c/1352944
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611924}
[modify] https://crrev.com/c220499359e1f37f3fca2d7cadfda07eca06cf8e/ui/webui/resources/cr_elements/cr_slider/cr_slider.html

Comment 5 by aee@chromium.org, Nov 28

Status: Fixed (was: Started)

Comment 6 by dchau...@etouch.net, Nov 29

Labels: TE-Verified-M72 TE-Verified-72.0.3625.0
Update:
Rechecked this issue on Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2) and Linux(14.04) machines using latest Canary #72.0.3625.0 and issue is fixed. Hence adding TE-Verified labels.

please refer the attached screen-cast for reference.

Thank you.
Fixed behavior.mp4
202 KB View Download
►

Sign in to add a comment