Update documentation in //components/signin/core/browser/identity_utils.h |
|||
Issue description
As mentioned by @blundell in [1] and [2], the following documentation header at the top of identity_utils.h needs some improvement:
// Collection of utility functions to support migrating different consumers of
// the SigninManager component to the Identity service, which will eventually be
// migrated to //services/identity once the SigninManager class gets removed.
This bug tracks that change.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/1346093/4/components/signin/core/browser/identity_utils.h#5
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1346093/4/components/signin/core/browser/identity_utils.h#16
,
Nov 23
,
Nov 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/771622a89405e0bb0a51a730acb28bad2185f081 commit 771622a89405e0bb0a51a730acb28bad2185f081 Author: Mario Sanchez Prada <mario@igalia.com> Date: Fri Nov 23 09:56:39 2018 Update documentation in //components/signin/core/browser/identity_utils.h Rewrite the header as per the after-landing suggestions in CL1346093. Bug: 907995 Change-Id: Iaecf3cd6257846f2012c7b42b97ffb844f4b45d7 Reviewed-on: https://chromium-review.googlesource.com/c/1349250 Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#610557} [modify] https://crrev.com/771622a89405e0bb0a51a730acb28bad2185f081/components/signin/core/browser/identity_utils.h
,
Nov 23
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ma...@igalia.com
, Nov 23