New issue
Advanced search Search tips

Issue 907981 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Flaky-Test: WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabsOfferRsaAnswerRsa



Sign in to add a comment

WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabsOfferRsaAnswerRsa is flaky

Project Member Reported by Findit, Nov 23

Issue description


Flaky test: WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabsOfferRsaAnswerRsa
Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ASan%20LSan%20Tests%20%281%29/52947
Test output log: https://chromium-swarm.appspot.com/task?id=41576666330bce10
Culprit (70.0% confidence): r610499
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy0QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKaAWNocm9taXVtLm1lbW9yeS9MaW51eCBBU2FuIExTYW4gVGVzdHMgKDEpLzUyOTQ3L2Jyb3dzZXJfdGVzdHMvVjJWaVVuUmpRbkp2ZDNObGNsUmxjM1F1VW5WdWMwRjFaR2x2Vm1sa1pXOVhaV0pTVkVORFlXeHNTVzVVZDI5VVlXSnpUMlptWlhKU2MyRkJibk4zWlhKU2MyRT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabsOfferRsaAnswerRsa&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy0QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKaAWNocm9taXVtLm1lbW9yeS9MaW51eCBBU2FuIExTYW4gVGVzdHMgKDEpLzUyOTQ3L2Jyb3dzZXJfdGVzdHMvVjJWaVVuUmpRbkp2ZDNObGNsUmxjM1F1VW5WdWMwRjFaR2x2Vm1sa1pXOVhaV0pTVkVORFlXeHNTVzVVZDI5VVlXSnpUMlptWlhKU2MyRkJibk4zWlhKU2MyRT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
 
 Issue 907986  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b789219d9fbdf8931e17be61cb024d004690080

commit 6b789219d9fbdf8931e17be61cb024d004690080
Author: Rune Lillesveen <futhark@chromium.org>
Date: Fri Nov 23 09:21:26 2018

Revert "Reland "Unify input delay computations""

This reverts commit 4d820bcdc64f018c4ad2142ce2bfcbf1be2a0410.

Reason for revert: causes flakiness in browser_tests (907981).

Original change's description:
> Reland "Unify input delay computations"
> 
> This is a reland of 5d945012c69d754ad5b659008eac95e5f0affabc
> 
> Original change's description:
> > Unify input delay computations
> >
> > This CL unifies the timestamp computations for FID as reported to UMA and FID as
> > exposed in the Web Perf API. It moves the UMA reporting from the
> > PageWidgetDelegate to the EventTiming class. After this CL, the same types of
> > events are logged by both the UMA metric and the webexposed metric. In addition,
> > this CL removes the check that there are default actions or event handlers from
> > EventTiming, which means that now the webexposed API will expose events even if
> > they have no associated event handlers. In particular, this means that a click
> > will now trigger mousedown, click, and mouseup entries, in that order. This is
> > reflected in changes to the layout tests.
> >
> > Bug: 897656
> > Change-Id: Ibeee0ffe9ff1fc0df74585da96a8fd3a6f2d17dc
> > Reviewed-on: https://chromium-review.googlesource.com/c/1334564
> > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> > Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#610201}
> 
> TBR=dtapuska@chromium.org
> 
> Bug: 897656, 843184
> Change-Id: I4d97f2731fe957696c0e908d5ef3493235b52d49
> Reviewed-on: https://chromium-review.googlesource.com/c/1348254
> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
> Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610499}

TBR=tdresser@chromium.org,dtapuska@chromium.org,npm@chromium.org

Change-Id: Ib5a3717393c14d5455bb97e92187d887465bef88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 897656, 843184, 907981
Reviewed-on: https://chromium-review.googlesource.com/c/1349253
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610553}
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-bufferbeforeonload.html
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-observethenonload.html
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-onloadthenobserve-firstInput.html
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-onloadthenobserve.html
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-only-observe-firstInput.html
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-timingconditions.html
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-crossiframe-childframe.html
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-support.js
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/dom/events/event.cc
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/dom/events/event.h
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/dom/events/event_dispatcher.cc
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/dom/events/event_target.cc
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/loader/interactive_detector.cc
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/loader/interactive_detector.h
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/page/page_widget_delegate.cc
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/timing/event_timing.cc
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/timing/event_timing.h
[modify] https://crrev.com/6b789219d9fbdf8931e17be61cb024d004690080/third_party/blink/renderer/core/timing/window_performance.cc

Labels: -Pri-1 -Sheriff-Chromium Pri-2
Owner: npm@chromium.org
Status: Assigned (was: Untriaged)
 Issue 908008  has been merged into this issue.

Sign in to add a comment