Zip archive NaCl module regularly crashes when DCHECKs are enabled |
||
Issue descriptionThe following stack trace is seen when running zip files browser tests in dchecks on mode: [1123/052400.382300:FATAL:ref_counted.h(85)] Check failed: CalledOnValidSequence(). ** abort() called ** Signal 4 from untrusted code: pc=7e3b0ffb5820
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c78b3e69be46642bab7f56dd845ee996408f7703 commit c78b3e69be46642bab7f56dd845ee996408f7703 Author: Anand K. Mistry <amistry@chromium.org> Date: Mon Dec 17 05:50:07 2018 Make ppapi Resource objects RefCountedThreadSafe In DCHECK_IS_ON mode, base::RefCounted's sequence checker will trigger because ppapi's Resources will be ref-counted across threads. One specific case is the interaction between MessageLoopResource and pp::SimpleThread. Constructing a SimpleThread will create and ref a MessageLoopResource on the creation thread, but when the thread is started, the thread calls AttachToCurrentThread() where MessageLoopResource will ref itself. BUG=756531, 907972 Change-Id: I00454970a293db5f1298d5152c44bf08ec704122 Reviewed-on: https://chromium-review.googlesource.com/c/1350439 Reviewed-by: Raymes Khoury <raymes@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#617051} [modify] https://crrev.com/c78b3e69be46642bab7f56dd845ee996408f7703/ppapi/shared_impl/resource.h
,
Dec 17
|
||
►
Sign in to add a comment |
||
Comment 1 by amistry@chromium.org
, Nov 26