New issue
Advanced search Search tips

Issue 907970 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 3
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 907962

Blocking:
issue 860355



Sign in to add a comment

Closure compile the media_import_handler_unittest

Project Member Reported by noel@chromium.org, Nov 23

Issue description

 - remove the current html unittest
 - closure compile the code and the test

 
Labels: OS-Chrome
Blocking: 860355
Owner: noel@chromium.org
Status: Started (was: Untriaged)
Blockedon: 907962
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e01981efa87e038267cbad6e4a6a7f3ce2e6e68

commit 5e01981efa87e038267cbad6e4a6a7f3ce2e6e68
Author: Noel Gordon <noel@chromium.org>
Date: Mon Dec 03 04:02:29 2018

Closure compile media_import_handler_unittest

 - remove media_inport_handler_unittest.html
 - add BUILD rules to auto-generate and compile this unittest
 - define mockChrome, install it during the unittest
 - remove unused unittest vars and JS auto-format
 - document test fixtures and test helpers
 - fix Closure compile errors (there were lots).

No change in test behavior, no new tests.

Bug:  907970 
Change-Id: Id90b4b1eaf84764521fb0d77aa2c29ff56db7c07
Reviewed-on: https://chromium-review.googlesource.com/c/1356728
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612997}
[modify] https://crrev.com/5e01981efa87e038267cbad6e4a6a7f3ce2e6e68/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/5e01981efa87e038267cbad6e4a6a7f3ce2e6e68/ui/file_manager/file_manager/background/js/BUILD.gn
[delete] https://crrev.com/d1df6533e0ac7d5e63fcf6e6339e023263da8e35/ui/file_manager/file_manager/background/js/media_import_handler_unittest.html
[modify] https://crrev.com/5e01981efa87e038267cbad6e4a6a7f3ce2e6e68/ui/file_manager/file_manager/background/js/media_import_handler_unittest.js

Status: Fixed (was: Started)

Sign in to add a comment