Closure compile progress center |
||||||
Issue descriptionThe progress center is defined/used in background BUILD file but is not directly complied. And adding progress center's externs file to the closure_compiler causes the compiler to fail. We should fix that.
,
Nov 23
,
Nov 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9a4f34665b9c6022ad095dbf094505ce8e10fff commit a9a4f34665b9c6022ad095dbf094505ce8e10fff Author: Noel Gordon <noel@chromium.org> Date: Fri Nov 23 04:46:34 2018 Add Progress Center's externs file to the BUILD and make it compile Bug: 907962 Change-Id: Ia16246c0c4685b07b721e18e48d4c4f23bc210e6 Reviewed-on: https://chromium-review.googlesource.com/c/1349139 Reviewed-by: Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#610534} [modify] https://crrev.com/a9a4f34665b9c6022ad095dbf094505ce8e10fff/ui/file_manager/file_manager/background/js/BUILD.gn [modify] https://crrev.com/a9a4f34665b9c6022ad095dbf094505ce8e10fff/ui/file_manager/file_manager/background/js/progress_center.js
,
Nov 23
,
Nov 23
I should compile the mock progress center while I am at it. Patch coming.
,
Nov 23
,
Nov 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55e90d76f824128acd550819fa5413a7c35594a2 commit 55e90d76f824128acd550819fa5413a7c35594a2 Author: Noel Gordon <noel@chromium.org> Date: Fri Nov 23 06:13:28 2018 Closure compile mock_progess_center Add a work-around for CSSRule.KEYFRAMES_RULE not being defined Closure, which does not define experimental web features. No change in behavior, no new tests. Bug: 907962 No-presubmit: true Change-Id: I4dd62588da812dbea641be898cf908056a842257 Reviewed-on: https://chromium-review.googlesource.com/c/1349147 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#610541} [modify] https://crrev.com/55e90d76f824128acd550819fa5413a7c35594a2/ui/file_manager/file_manager/background/js/BUILD.gn [modify] https://crrev.com/55e90d76f824128acd550819fa5413a7c35594a2/ui/file_manager/file_manager/foreground/js/ui/progress_center_panel.js
,
Nov 23
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by noel@chromium.org
, Nov 23Components: Platform>Apps>FileManager
Labels: CrOSFilesCategory-Testing Files-Fixit-2018 CrOSFilesCategory-CodeHealth OS-Chrome
Owner: noel@chromium.org