Launching NewSplashWebApk sometimes launches WebAPK into new task stack |
||
Issue description
Repro steps:
1) Launch WebAPK with the following intent (This is not the usual way of launching a WebAPK via a deep link)
Intent intent = new Intent(Intent.ACTION_VIEW,
Uri.parse("https://tests.peter.sh/"));
intent.setComponent(new android.content.ComponentName("org.chromium.webapk.new.splash",
"org.chromium.webapk.shell_apk.h2o.SplashActivity"));
2) Emulate the Android out of memory killer killing Chrome by using "adb shell kill" to kill the Chrome process
3) Launch WebAPK via
Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse("https://tests.peter.sh/push-encryption-verifier/"));
intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
Expected:
Either WebAPK is relaunched or current WebAPK is navigated to new URL
Actual:
WebAPK is launched in new task stack. See screenshot
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40bdb6bdcb2a9c095a4652a2568b9ec64929437e commit 40bdb6bdcb2a9c095a4652a2568b9ec64929437e Author: Peter Kotwicz <pkotwicz@chromium.org> Date: Fri Nov 30 21:39:22 2018 [Android WebAPK] Make NewSplashWebApk single task 13/X This CL: - Makes SplashActivity singleTask - Introduces InitialSplashActivity to launch SplashActivity. Otherwise, whenever the user taps the WebAPK's app icon the WebAPK is relaunched and the ChromeActivity which is on top of SplashActivity is killed BUG=907951 TEST=LaunchTest.* Change-Id: Ibc06b1b3fc2aea49ad26bf1043aebec595fb68cf Reviewed-on: https://chromium-review.googlesource.com/c/1340516 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612795} [modify] https://crrev.com/40bdb6bdcb2a9c095a4652a2568b9ec64929437e/chrome/android/webapk/shell_apk/AndroidManifest.xml [modify] https://crrev.com/40bdb6bdcb2a9c095a4652a2568b9ec64929437e/chrome/android/webapk/shell_apk/BUILD.gn [modify] https://crrev.com/40bdb6bdcb2a9c095a4652a2568b9ec64929437e/chrome/android/webapk/shell_apk/current_version/current_version.gni [modify] https://crrev.com/40bdb6bdcb2a9c095a4652a2568b9ec64929437e/chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/h2o/LaunchTest.java [modify] https://crrev.com/40bdb6bdcb2a9c095a4652a2568b9ec64929437e/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/HostBrowserLauncher.java [modify] https://crrev.com/40bdb6bdcb2a9c095a4652a2568b9ec64929437e/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/HostBrowserLauncherParams.java [modify] https://crrev.com/40bdb6bdcb2a9c095a4652a2568b9ec64929437e/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/h2o/H2OMainActivity.java [add] https://crrev.com/40bdb6bdcb2a9c095a4652a2568b9ec64929437e/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/h2o/H2OOpaqueMainActivity.java [modify] https://crrev.com/40bdb6bdcb2a9c095a4652a2568b9ec64929437e/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/h2o/H2OTransparentLauncherActivity.java [modify] https://crrev.com/40bdb6bdcb2a9c095a4652a2568b9ec64929437e/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/h2o/SplashActivity.java
,
Jan 11
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this. |
||
►
Sign in to add a comment |
||
Comment 1 by pkotw...@chromium.org
, Nov 23