Flaky test: external/wpt/event-timing/event-timing-timingconditions.html Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/6917 Test output log: https://chromium-swarm.appspot.com/task?id=4156fac1996e1010 Culprit (100.0% confidence): r610504 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy3wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKoAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cy82OTE3L3dlYmtpdF9sYXlvdXRfdGVzdHMgb24gSW50ZWwgR1BVIG9uIE1hYyBvbiBNYWMtMTAuMTIuNi9aWGgwWlhKdVlXd3ZkM0IwTDJWMlpXNTBMWFJwYldsdVp5OWxkbVZ1ZEMxMGFXMXBibWN0ZEdsdGFXNW5ZMjl1WkdsMGFXOXVjeTVvZEcxcwwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20external/wpt/event-timing/event-timing-timingconditions.html&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy3wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKoAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cy82OTE3L3dlYmtpdF9sYXlvdXRfdGVzdHMgb24gSW50ZWwgR1BVIG9uIE1hYyBvbiBNYWMtMTAuMTIuNi9aWGgwWlhKdVlXd3ZkM0IwTDJWMlpXNTBMWFJwYldsdVp5OWxkbVZ1ZEMxMGFXMXBibWN0ZEdsdGFXNW5ZMjl1WkdsMGFXOXVjeTVvZEcxcwwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8e2b407768bb19b9025fcf839e08d1381e989a9 commit a8e2b407768bb19b9025fcf839e08d1381e989a9 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Fri Nov 23 01:46:05 2018 Revert "[EventTiming] Move tests to WPT" This reverts commit f1fb6d618beab1830a086c43acee5c3c1c8d8028. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 610504 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjFmYjZkNjE4YmVhYjE4MzBhMDg2YzQzYWNlZTVjM2MxYzhkODAyOAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/6917 Sample Failed Step: webkit_layout_tests on Intel GPU on Mac on Mac-10.12.6 Sample Flaky Test: external/wpt/event-timing/event-timing-timingconditions.html Original change's description: > [EventTiming] Move tests to WPT > > This CL moves Event Timing tests to web-platform-tests. Relevant changes: > * Move to using test_driver.click. > * Replace setTimeout with step_timeout. > * Move to using a python-based slow image resource. > > Bug: 841224 > Change-Id: I21f322546815d7d6bcec4dd1703de50a9296d992 > Reviewed-on: https://chromium-review.googlesource.com/c/1348855 > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610504} Change-Id: Id18988562dc34b1686497c689605b8436760a10c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 841224, 907949 Reviewed-on: https://chromium-review.googlesource.com/c/1348732 Cr-Commit-Position: refs/heads/master@{#610512} [modify] https://crrev.com/a8e2b407768bb19b9025fcf839e08d1381e989a9/third_party/WebKit/LayoutTests/MSANExpectations [modify] https://crrev.com/a8e2b407768bb19b9025fcf839e08d1381e989a9/third_party/WebKit/LayoutTests/SlowTests [modify] https://crrev.com/a8e2b407768bb19b9025fcf839e08d1381e989a9/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/72086dc9fd6cd256b110002c96b945490df51f59/third_party/WebKit/LayoutTests/external/wpt/event-timing/resources/slow-image.py [rename] https://crrev.com/a8e2b407768bb19b9025fcf839e08d1381e989a9/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-bufferbeforeonload.html [rename] https://crrev.com/a8e2b407768bb19b9025fcf839e08d1381e989a9/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-crossiframe.html [rename] https://crrev.com/a8e2b407768bb19b9025fcf839e08d1381e989a9/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-observer-manual.html [rename] https://crrev.com/a8e2b407768bb19b9025fcf839e08d1381e989a9/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-observethenonload.html [rename] https://crrev.com/a8e2b407768bb19b9025fcf839e08d1381e989a9/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-onloadthenobserve-firstInput.html [rename] https://crrev.com/a8e2b407768bb19b9025fcf839e08d1381e989a9/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-onloadthenobserve.html [rename] https://crrev.com/a8e2b407768bb19b9025fcf839e08d1381e989a9/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-only-observe-firstInput.html [rename] https://crrev.com/a8e2b407768bb19b9025fcf839e08d1381e989a9/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-retrievability.html [rename] https://crrev.com/a8e2b407768bb19b9025fcf839e08d1381e989a9/third_party/WebKit/LayoutTests/http/tests/event-timing/event-timing-timingconditions.html [rename] https://crrev.com/a8e2b407768bb19b9025fcf839e08d1381e989a9/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-crossiframe-childframe.html [rename] https://crrev.com/a8e2b407768bb19b9025fcf839e08d1381e989a9/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-observer-manual-childframe.html [rename] https://crrev.com/a8e2b407768bb19b9025fcf839e08d1381e989a9/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/event-timing-support.js [add] https://crrev.com/a8e2b407768bb19b9025fcf839e08d1381e989a9/third_party/WebKit/LayoutTests/http/tests/event-timing/resources/slow-image.php
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d commit 7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d Author: Nicolas Pena <npm@chromium.org> Date: Tue Nov 27 14:38:31 2018 Prepare to move EventTiming tests to WPT This CL does most of the changes needed to move EventTiming tests to WPT. The CL attempts to make the tests less flaky by ensuring the event handlers themselves take a long time to execute. Bug: 908187 , 907948 , 907949 Change-Id: Iced25d635cb05c9903a209d43988ba4e71681195 Reviewed-on: https://chromium-review.googlesource.com/c/1351600 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#611099} [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-bufferbeforeonload.html [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-crossiframe.html [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-observethenonload.html [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-onloadthenobserve-firstInput.html [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-onloadthenobserve.html [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-only-observe-firstInput.html [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-retrievability.html [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-timingconditions.html [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/resources/event-timing-crossiframe-childframe.html [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/resources/event-timing-support.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f5f9c29d24b1a83e226a49f446575ffb372512e commit 6f5f9c29d24b1a83e226a49f446575ffb372512e Author: Nicolas Pena <npm@chromium.org> Date: Thu Nov 29 15:59:00 2018 Move EventTiming tests to WPT Try 3 This CL moves the tests in http/tests/event-timing to external/wpt/event-timing. The slow image is change from php based to python based. The click is now handled by test driver. and setTimeout is replaced with step_timeout. Bug: 841224, 908187 , 907948 , 907949 Change-Id: Ia6359878666cfb96645aa3b7cd7736ce9df97683 Reviewed-on: https://chromium-review.googlesource.com/c/1352617 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#612214} [modify] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/MSANExpectations [modify] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/SlowTests [modify] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/TestExpectations [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-bufferbeforeonload.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-crossiframe.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-observer-manual.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-observethenonload.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-onloadthenobserve-firstInput.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-onloadthenobserve.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-only-observe-firstInput.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-retrievability.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-timingconditions.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/resources/event-timing-crossiframe-childframe.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/resources/event-timing-observer-manual-childframe.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/resources/event-timing-support.js [add] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/resources/slow-image.py [delete] https://crrev.com/7d81ddd9a1d0364772b0f423ab2fc8ad8c1c0187/third_party/blink/web_tests/http/tests/event-timing/resources/slow-image.php
Comment 1 by bugdroid1@chromium.org
, Nov 23