After https://chromium-review.googlesource.com/c/chromium/src/+/1348254 landed, the LayoutTest http/tests/event-timing/event-timing-onloadthenobserve.html (and now the equivalent external/wpt/event-timing/event-timing-onloadthenobserve.html) is failing on Mac10.13 Debug: https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/6704
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0850df10f46965edbe4fe86bbb6594c4a8e1a8cc commit 0850df10f46965edbe4fe86bbb6594c4a8e1a8cc Author: Nicolás Peña Moreno <npm@chromium.org> Date: Fri Nov 23 02:42:52 2018 EventTiming: mark event-timing-onloadthenobserve.html as flaky on Mac Bug: 907948 TBR=tdresser@chromium.org Change-Id: I53d328b935ab235e441f555e625aa97fac1b9ea4 Reviewed-on: https://chromium-review.googlesource.com/c/1349033 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#610519} [modify] https://crrev.com/0850df10f46965edbe4fe86bbb6594c4a8e1a8cc/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8e4a8a9828eb05fed4b43fe054d42c13f5e5b8a commit e8e4a8a9828eb05fed4b43fe054d42c13f5e5b8a Author: Nicolás Peña Moreno <npm@chromium.org> Date: Fri Nov 23 15:42:40 2018 Revert "EventTiming: mark event-timing-onloadthenobserve.html as flaky on Mac" This reverts commit 0850df10f46965edbe4fe86bbb6594c4a8e1a8cc. Reason for revert: the culprit CL was reverted, no longer needed. Original change's description: > EventTiming: mark event-timing-onloadthenobserve.html as flaky on Mac > > Bug: 907948 > TBR=tdresser@chromium.org > > Change-Id: I53d328b935ab235e441f555e625aa97fac1b9ea4 > Reviewed-on: https://chromium-review.googlesource.com/c/1349033 > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610519} TBR=tdresser@chromium.org,npm@chromium.org Change-Id: Ib20b5fd4bf0cf147518967ede801d9092e7a7112 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 907948 Reviewed-on: https://chromium-review.googlesource.com/c/1349496 Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#610613} [modify] https://crrev.com/e8e4a8a9828eb05fed4b43fe054d42c13f5e5b8a/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d commit 7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d Author: Nicolas Pena <npm@chromium.org> Date: Tue Nov 27 14:38:31 2018 Prepare to move EventTiming tests to WPT This CL does most of the changes needed to move EventTiming tests to WPT. The CL attempts to make the tests less flaky by ensuring the event handlers themselves take a long time to execute. Bug: 908187 , 907948 , 907949 Change-Id: Iced25d635cb05c9903a209d43988ba4e71681195 Reviewed-on: https://chromium-review.googlesource.com/c/1351600 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#611099} [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-bufferbeforeonload.html [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-crossiframe.html [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-observethenonload.html [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-onloadthenobserve-firstInput.html [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-onloadthenobserve.html [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-only-observe-firstInput.html [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-retrievability.html [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/event-timing-timingconditions.html [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/resources/event-timing-crossiframe-childframe.html [modify] https://crrev.com/7cfae5787c3a50e59902fcdcfbd645e5fc2aa24d/third_party/blink/web_tests/http/tests/event-timing/resources/event-timing-support.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f5f9c29d24b1a83e226a49f446575ffb372512e commit 6f5f9c29d24b1a83e226a49f446575ffb372512e Author: Nicolas Pena <npm@chromium.org> Date: Thu Nov 29 15:59:00 2018 Move EventTiming tests to WPT Try 3 This CL moves the tests in http/tests/event-timing to external/wpt/event-timing. The slow image is change from php based to python based. The click is now handled by test driver. and setTimeout is replaced with step_timeout. Bug: 841224, 908187 , 907948 , 907949 Change-Id: Ia6359878666cfb96645aa3b7cd7736ce9df97683 Reviewed-on: https://chromium-review.googlesource.com/c/1352617 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#612214} [modify] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/MSANExpectations [modify] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/SlowTests [modify] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/TestExpectations [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-bufferbeforeonload.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-crossiframe.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-observer-manual.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-observethenonload.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-onloadthenobserve-firstInput.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-onloadthenobserve.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-only-observe-firstInput.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-retrievability.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/event-timing-timingconditions.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/resources/event-timing-crossiframe-childframe.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/resources/event-timing-observer-manual-childframe.html [rename] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/resources/event-timing-support.js [add] https://crrev.com/6f5f9c29d24b1a83e226a49f446575ffb372512e/third_party/blink/web_tests/external/wpt/event-timing/resources/slow-image.py [delete] https://crrev.com/7d81ddd9a1d0364772b0f423ab2fc8ad8c1c0187/third_party/blink/web_tests/http/tests/event-timing/resources/slow-image.php
Comment 1 by bugdroid1@chromium.org
, Nov 23