New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment
link

Issue 907928: Unexpected blue underline when typing text in a WebView

Reported by lquinn@blackberry.com, Nov 22

Issue description

Device name: BlackBerry KEY2 LE
Android version: 8.1.0
WebView version: Chrome Beta 71.0.3578.64
Application: Gmail
Application version: 8.10.21.220187835.release

Steps to reproduce:
(1) Compose a new email message in the Gmail app.
(2) Type a variety of correctly spelled words, including words like "it" and "in".

Expected result:
Correctly spelled words should not be underlined in blue.

Actual result:
Some words are showing a blue underline. These aren't misspelled words--those are showing a red, wavy underline. I see words like "it" getting a blue underline, and I can't tell why.

I don't see this issue when I switch my WebView implementation to Chrome 70.0.3538.110, keeping everything else the same.
 

Comment 1 by jbanavatu@chromium.org, Nov 23

Labels: Needs-triage-Mobile

Comment 2 by lquinn@blackberry.com, Nov 23

https://crrev.com/6abd371966bc51434d4ebf8bf09f5c1366e9d485 looks like the culprit. It doesn't seem to be working correctly--the blue underline appears while typing and stays even after the word is fully typed (without using auto-correction).

It's also reproducible using a BlackBerry PRIV running Android 6.0.1 with Android System WebView 71.0.3578.64 and BlackBerry Keyboard 3.4.1.16225.

The problem is also reproducible in Chrome Beta if typing in HTML contenteditable fields such as those at http://mikaelharsjo.github.io/content-editable/components/content-editable/demo.html.

The problem is not reproducible in HTML textarea fields in Chrome Beta, nor is it reproducible in native Android text fields. In those cases, the blue underline appears while typing, but it disappears after the word is fully typed.

Comment 3 by chelamcherla@chromium.org, Nov 26

Cc: chelamcherla@chromium.org
Components: Blink>Editing>Spellcheck
Labels: WV-Triaged
Owner: ctzsm@chromium.org
Status: Assigned (was: Unconfirmed)
W.r.t to c#2 assigning to ctzsm@ for further help in triaging.

@ctzsm: Please feel free to re-assign if this is not related to your change.

Thanks!

Comment 4 by changwan@chromium.org, Nov 26

Cc: -chelamcherla@chromium.org sindhu.chelamcherla@chromium.org
It seems that blackberry phone is required to test this out. We couldn't test it yet, but we suspect that this is what happens:

1) Blackberry keyboard sets the blue underline. (using FLAG_AUTO_CORRECTION flag)
2) Blackberry keyboard unsets the blue underline in the next operation somehow. We think either it removes FLAG_AUTO_CORRECTION flag or calls commitCorrection().

- Chrome/WebView does not support commitCorrection() yet, and it returns false.
- The bigger problem is that chrome/webview does not keep track of the removal of the underline.

Since 71 is going to be shipped very soon, it will be difficult to fix this in time: https://www.chromium.org/developers/calendar

Comment 5 by lquinn@blackberry.com, Nov 26

Is it possible to revert https://crrev.com/6abd371966bc51434d4ebf8bf09f5c1366e9d485 until this can be implemented correctly? This bug will be quite annoying for BlackBerry users.

Comment 6 by ctzsm@chromium.org, Nov 27

I tried on a blackberry device with a blackberry keyboard, I do see the behavior you mentioned above.

With TextView, BB keyboard will do the cleanup of blue underline, so the blue underline is just for a transition state. With WebView since the corresponding calls are not implemented, BB keyboard has no way to do the cleanup.

Talked to changwan@ offline, we decided to revert this for M71 and possibly M72 given the timeline is very tight.

Comment 7 by bugdroid1@chromium.org, Nov 27

Project Member
Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd9f0fa049ebba83f7be302d7118c60747989a12

commit dd9f0fa049ebba83f7be302d7118c60747989a12
Author: Shimi Zhang <ctzsm@chromium.org>
Date: Tue Nov 27 01:57:39 2018

Revert "[Android] Add FLAG_AUTO_CORRESION support for spell checking"

This reverts commit 6abd371966bc51434d4ebf8bf09f5c1366e9d485.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [Android] Add FLAG_AUTO_CORRESION support for spell checking
>
> Add basic support for SuggestionSpan.FLAG_AUTO_CORRESION flag, make it
> show underline for this type.
>
> Bug: 869261
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
> Change-Id: I6db973826ebf761902506905d31968ec4b78819a
> Reviewed-on: https://chromium-review.googlesource.com/c/1285312
> Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Reviewed-by: Changwan Ryu <changwan@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#601669}(cherry picked from commit 193fde1762f4f0d0d925c0f109f3f536aae0c7e9)
> Reviewed-on: https://chromium-review.googlesource.com/c/1338381
> Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3578@{#702}
> Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

TBR=ctzsm@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 869261,  907928 
Change-Id: I89ae8dbbade3ac4ebf6858876846ce2e4ce03a92
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1351907
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#817}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/dd9f0fa049ebba83f7be302d7118c60747989a12/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapterImpl.java
[modify] https://crrev.com/dd9f0fa049ebba83f7be302d7118c60747989a12/content/public/android/javatests/src/org/chromium/content/browser/input/TextSuggestionMenuTest.java
[modify] https://crrev.com/dd9f0fa049ebba83f7be302d7118c60747989a12/third_party/blink/renderer/core/editing/suggestion/text_suggestion_controller.cc
[modify] https://crrev.com/dd9f0fa049ebba83f7be302d7118c60747989a12/third_party/blink/renderer/core/editing/suggestion/text_suggestion_controller.h
[modify] https://crrev.com/dd9f0fa049ebba83f7be302d7118c60747989a12/third_party/blink/renderer/core/editing/suggestion/text_suggestion_controller_test.cc

Comment 8 by cr-audit...@appspot.gserviceaccount.com, Nov 27

Project Member
Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/dd9f0fa049ebba83f7be302d7118c60747989a12

Commit: dd9f0fa049ebba83f7be302d7118c60747989a12
Author: ctzsm@chromium.org
Commiter: ctzsm@chromium.org
Date: 2018-11-27 01:57:39 +0000 UTC

Revert "[Android] Add FLAG_AUTO_CORRESION support for spell checking"

This reverts commit 6abd371966bc51434d4ebf8bf09f5c1366e9d485.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [Android] Add FLAG_AUTO_CORRESION support for spell checking
>
> Add basic support for SuggestionSpan.FLAG_AUTO_CORRESION flag, make it
> show underline for this type.
>
> Bug: 869261
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
> Change-Id: I6db973826ebf761902506905d31968ec4b78819a
> Reviewed-on: https://chromium-review.googlesource.com/c/1285312
> Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Reviewed-by: Changwan Ryu <changwan@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#601669}(cherry picked from commit 193fde1762f4f0d0d925c0f109f3f536aae0c7e9)
> Reviewed-on: https://chromium-review.googlesource.com/c/1338381
> Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3578@{#702}
> Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

TBR=ctzsm@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 869261,  907928 
Change-Id: I89ae8dbbade3ac4ebf6858876846ce2e4ce03a92
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1351907
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#817}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Comment 9 by ctzsm@chromium.org, Nov 27

lquinn@, could you please help us check which API are you calling in the keyboard for removing blue underline in TextView? I am curious about when you moves caret, the blue underline is also get removed.

Comment 10 by ctzsm@chromium.org, Nov 27

Cc: -sindhu.chelamcherla@chromium.org satyavat...@chromium.org dneelame...@chromium.org chelamcherla@chromium.org
dneelamegam@, please note that we reverted the change of the new blue underline for m71. Also, could you please add blackberry keyboard test cases.

Comment 11 by lquinn@blackberry.com, Nov 27

Thanks for the revert!

With the BlackBerry Keyboard on native Android text fields, the underline removal happens when the Keyboard calls InputConnection.finishComposingText(). According to the API documentation at https://developer.android.com/reference/android/view/inputmethod/InputConnection#finishComposingText(), that call is supposed to remove "any special composing styling".

For native Android text fields, that ends up in https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/view/inputmethod/BaseInputConnection.java#434, which removes any Spans that have Spanned.SPAN_COMPOSING set.

The BlackBerry Keyboard sets Spanned.SPAN_COMPOSING when it calls Spannable.setSpan() for FLAG_AUTO_CORRECTION.

Comment 12 by changwan@chromium.org, Nov 27

Cc: des...@chromium.org

Comment 13 by changwan@chromium.org, Nov 27

Labels: -Pri-3 Pri-2
Upping the priority as we thought that this was a critical bug.
cc'ing desaic@, our PM. This is actually quite difficult to get right, Shimi and I will have to think more about a potential fix.

Comment 14 by sbashyam@google.com, Nov 28

Verified the revert cl mentioned on comment #8, tested on compose with "it","interested","On","below","above",through","in" , Issue with under line not reproducible  on Black berry Priv /MMB29M having 71.0.3578.75 (Issue was reproduced in 71.0.3578.64).Thanks for revert fix.

Comment 15 by bugdroid1@chromium.org, Dec 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2165e538dec6f3b051ae87319f367bd9b082d8f4

commit 2165e538dec6f3b051ae87319f367bd9b082d8f4
Author: Shimi Zhang <ctzsm@chromium.org>
Date: Sat Dec 15 02:50:54 2018

[Android] Properly remove SuggestionSpan after composition

This CL:

1) Reads Spanned#SPAN_COMPOSING from Java side and propagate it to
   Blink (SuggestionMarker).
2) Removes SuggestionMarker which has this flag after IME done with
   composition.

We want to remove these SuggestionMarkers for
- InputConnection#commitText()
- InputConnection#setComposingText()
- InputConnection#finishComposing()

Note that before caret move event is covered by finishComposing().

Bug:  907928 
Change-Id: I6245d7a2d43f54e7272d5abf6ea46b53f2f57ce7
Reviewed-on: https://chromium-review.googlesource.com/c/1361727
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616926}
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/content/browser/android/ime_adapter_android.cc
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/content/common/content_param_traits_macros.h
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/content/common/input/ime_text_span_conversions.cc
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapterImpl.java
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/content/public/android/javatests/src/org/chromium/content/browser/input/TextSuggestionMenuTest.java
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/services/ws/public/mojom/ime/ime.mojom
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/services/ws/public/mojom/ime/ime_struct_traits.cc
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/services/ws/public/mojom/ime/ime_struct_traits.h
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/third_party/blink/public/web/web_ime_text_span.h
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/third_party/blink/renderer/core/editing/ime/ime_text_span.cc
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/third_party/blink/renderer/core/editing/ime/ime_text_span.h
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/third_party/blink/renderer/core/editing/ime/input_method_controller.cc
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/third_party/blink/renderer/core/editing/ime/input_method_controller.h
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/third_party/blink/renderer/core/editing/ime/input_method_controller_test.cc
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/third_party/blink/renderer/core/editing/markers/document_marker_controller.cc
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/third_party/blink/renderer/core/editing/markers/document_marker_controller.h
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/third_party/blink/renderer/core/editing/markers/document_marker_controller_test.cc
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/third_party/blink/renderer/core/editing/markers/suggestion_marker.cc
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/third_party/blink/renderer/core/editing/markers/suggestion_marker.h
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/third_party/blink/renderer/core/editing/markers/suggestion_marker_properties.cc
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/third_party/blink/renderer/core/editing/markers/suggestion_marker_properties.h
[modify] https://crrev.com/2165e538dec6f3b051ae87319f367bd9b082d8f4/ui/base/ime/ime_text_span.h

Comment 16 by alekyoo@google.com, Dec 18

Verified on: 
Device name: BlackBerry Priv / MMB29M 
WebView version: Chrome Beta 73.0.3643.0 
(Saw issue on: 71.0.3578.64)

Comment 17 by ctzsm@chromium.org, Dec 18

Labels: Merge-Request-72
Requesting merge back to M72.

Comment 18 by sheriffbot@chromium.org, Dec 18

Project Member
Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 19 by ctzsm@chromium.org, Dec 18

lquinn@, could you please also test this issue on Chrome canary (73.0.3643.0) with Blackberry devices you have. Thanks!

Comment 20 by gov...@chromium.org, Dec 18

Is the M72 merge request for Cl listed at #15? 
If yes, how is the change looking in canary? Is it fully safe to merge? And why it is critical to merge this change to M72?

This looks like a large cl to merge in beta branch.

Comment 21 by ctzsm@chromium.org, Dec 18

Re #20,

Yes the merge request is for CL in #15. Alek tested on canary and replied in #16.

The feature itself was landed in M72, and CL in #15 fixed a bug caused by that feature, so M72 is actually still broken since we only reverted it for M71.

I wrote many tests around this fix, so the CL looks large. I think it should be safe to merge it back. But if lquinn@ would like to help us cross verify the fix on their end, it will be good enough to go.

Comment 22 by gov...@chromium.org, Dec 18

Labels: -Merge-Review-72 Merge-Approved-72
Approving merge to M72 branch 3626 based on comment #21. Please merge ASAP so we can pick it up for this week beta release. Thank you.

Comment 23 by lquinn@blackberry.com, Dec 18

The fix looks good to me using Chrome Canary 73.0.3644.0 as the WebView implementation on a BlackBerry KEY2 LE. Using the same device, I can reproduce the issue with Chrome Beta 72.0.3626.14.

Comment 24 by gov...@chromium.org, Dec 18

Thank you lquinn@ for canary verification.

 ctzsm@, pls merge the change to M72 ASAP so we can pick it up for tomorrow's beta release. Thank you.

Comment 25 by bugdroid1@chromium.org, Dec 18

Project Member
Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/440021a9059ba7446d2e50e69cf997558845d188

commit 440021a9059ba7446d2e50e69cf997558845d188
Author: Shimi Zhang <ctzsm@chromium.org>
Date: Tue Dec 18 17:58:13 2018

[Android] Properly remove SuggestionSpan after composition

This CL:

1) Reads Spanned#SPAN_COMPOSING from Java side and propagate it to
   Blink (SuggestionMarker).
2) Removes SuggestionMarker which has this flag after IME done with
   composition.

We want to remove these SuggestionMarkers for
- InputConnection#commitText()
- InputConnection#setComposingText()
- InputConnection#finishComposing()

Note that before caret move event is covered by finishComposing().

Bug:  907928 
Change-Id: I6245d7a2d43f54e7272d5abf6ea46b53f2f57ce7
Reviewed-on: https://chromium-review.googlesource.com/c/1361727
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616926}(cherry picked from commit 2165e538dec6f3b051ae87319f367bd9b082d8f4)
Reviewed-on: https://chromium-review.googlesource.com/c/1382862
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#434}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/content/browser/android/ime_adapter_android.cc
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/content/common/content_param_traits_macros.h
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/content/common/input/ime_text_span_conversions.cc
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapterImpl.java
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/content/public/android/javatests/src/org/chromium/content/browser/input/TextSuggestionMenuTest.java
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/services/ws/public/mojom/ime/ime.mojom
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/services/ws/public/mojom/ime/ime_struct_traits.cc
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/services/ws/public/mojom/ime/ime_struct_traits.h
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/third_party/blink/public/web/web_ime_text_span.h
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/third_party/blink/renderer/core/editing/ime/ime_text_span.cc
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/third_party/blink/renderer/core/editing/ime/ime_text_span.h
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/third_party/blink/renderer/core/editing/ime/input_method_controller.cc
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/third_party/blink/renderer/core/editing/ime/input_method_controller.h
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/third_party/blink/renderer/core/editing/ime/input_method_controller_test.cc
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/third_party/blink/renderer/core/editing/markers/document_marker_controller.cc
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/third_party/blink/renderer/core/editing/markers/document_marker_controller.h
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/third_party/blink/renderer/core/editing/markers/document_marker_controller_test.cc
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/third_party/blink/renderer/core/editing/markers/suggestion_marker.cc
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/third_party/blink/renderer/core/editing/markers/suggestion_marker.h
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/third_party/blink/renderer/core/editing/markers/suggestion_marker_properties.cc
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/third_party/blink/renderer/core/editing/markers/suggestion_marker_properties.h
[modify] https://crrev.com/440021a9059ba7446d2e50e69cf997558845d188/ui/base/ime/ime_text_span.h

Comment 26 by ctzsm@chromium.org, Dec 18

Status: Fixed (was: Assigned)
Thank you lquinn@ and govind@, merged the change back to M72.

Please verify accordingly, thanks!

Comment 27 by srinivassista@google.com, Dec 18

Mac64 beta builders are failing with this error. This is the only CL for this build. PTAL

[20918/46254] CXX obj/chrome/browser/ui/ui/md_settings_localized_strings_provider.o
FAILED: obj/chrome/browser/ui/ui/md_settings_localized_strings_provider.o
export DEVELOPER_DIR=/b/c/b/mac64_beta/src/build/mac_files/Xcode.app;  ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/browser/ui/ui/md_settings_localized_strings_provider.o.d -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -D_LIBCPP_HAS_NO_ALIGNED_ALLOCATION -DCR_XCODE_VERSION=0832 -DCR_CLANG_REVISION=\"346388-5\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_CUPS -DWEBP_EXTERN=extern -DTOOLKIT_VIEWS=1 -DUSE_EGL -DSYNC_PASSWORD_REUSE_DETECTION_ENABLED -DEXPAT_RELATIVE_PATH -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DLEVELDB_PLATFORM_CHROMIUM=1 -DLEVELDB_PLATFORM_CHROMIUM=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DV8_USE_EXTERNAL_STARTUP_DATA -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DABSL_ALLOCATOR_NOTHROW=1 -DNO_MAIN_THREAD_WRAPPING -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1 -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -DSK_BUILD_FOR_MAC -DV8_DEPRECATION_WARNINGS -DI18N_ADDRESS_VALIDATION_DATA_URL=\"https://chromium-i18n.appspot.com/ssl-aggregate-address/\" -Igen/chrome/browser/ui -I../.. -Igen -I../../third_party/libyuv/include -I../../third_party/libwebp/src -I../../third_party/khronos -I../../gpu -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/webrtc_overrides -I../../third_party/webrtc -I../../third_party/abseil-cpp -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/docs -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/pathops -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/codec -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/skia/modules/skottie/include -I../../third_party/libwebm/source -I../../v8/include -Igen/v8/include -I../../third_party/perfetto/include -Igen/third_party/perfetto/protos -I../../testing/gtest/include -Igen/third_party/perfetto/protos -Igen/third_party/perfetto/protos -Igen/third_party/metrics_proto -I../../third_party/re2/src -I../../third_party/mesa_headers -Igen -Igen -Igen -Igen -I../../third_party/google_toolbox_for_mac -I../../third_party/google_toolbox_for_mac/src -I../../third_party/google_toolbox_for_mac/src/AppKit -I../../third_party/google_toolbox_for_mac/src/DebugUtils -I../../third_party/google_toolbox_for_mac/src/Foundation -I../../third_party/libaddressinput/src/cpp/include -I../../third_party/cacheinvalidation/overrides -I../../third_party/cacheinvalidation/src -I../../third_party/flatbuffers/src/include -I../../third_party/brotli/include -I../../third_party/zlib -Igen -Igen -Igen -Igen -Igen -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -arch x86_64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-null-pointer-arithmetic -Wno-ignored-pragma-optimize -O2 -fno-omit-frame-pointer -gdwarf-2 -fno-standalone-debug -isysroot ../../build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -mmacosx-version-min=10.9.0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang enforce-in-thirdparty-webkit -Xclang -plugin-arg-find-bad-constructs -Xclang check-enum-max-value -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-nonnull -Wexit-time-destructors -Wno-shorten-64-to-32 -Wno-exit-time-destructors -std=c++14 -stdlib=libc++ -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -c ../../chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc -o obj/chrome/browser/ui/ui/md_settings_localized_strings_provider.o
../../chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1678:23: error: use of undeclared identifier 'is_unified_consent_enabled'
{"syncWillStart", is_unified_consent_enabled
^
../../chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:1769:27: error: no matching function for call to 'ArraySizeHelper'
arraysize(localized_strings));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../base/macros.h:57:34: note: expanded from macro 'arraysize'
#define arraysize(array) (sizeof(ArraySizeHelper(array)))
^~~~~~~~~~~~~~~
../../base/macros.h:56:40: note: candidate template ignored: could not match 'T [N]' against 'settings::(anonymous namespace)::LocalizedString []'
template <typename T, size_t N> char (&ArraySizeHelper(T (&array)[N]))[N];
^
2 errors generated.

Comment 28 by changwan@chromium.org, Dec 18

srinivassista@, could you point us to the build page? At a glance, the error log doesn't seem relevant.

Comment 30 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Project Member
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/440021a9059ba7446d2e50e69cf997558845d188

Commit: 440021a9059ba7446d2e50e69cf997558845d188
Author: ctzsm@chromium.org
Commiter: ctzsm@chromium.org
Date: 2018-12-18 17:58:13 +0000 UTC

[Android] Properly remove SuggestionSpan after composition

This CL:

1) Reads Spanned#SPAN_COMPOSING from Java side and propagate it to
   Blink (SuggestionMarker).
2) Removes SuggestionMarker which has this flag after IME done with
   composition.

We want to remove these SuggestionMarkers for
- InputConnection#commitText()
- InputConnection#setComposingText()
- InputConnection#finishComposing()

Note that before caret move event is covered by finishComposing().

Bug:  907928 
Change-Id: I6245d7a2d43f54e7272d5abf6ea46b53f2f57ce7
Reviewed-on: https://chromium-review.googlesource.com/c/1361727
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#616926}(cherry picked from commit 2165e538dec6f3b051ae87319f367bd9b082d8f4)
Reviewed-on: https://chromium-review.googlesource.com/c/1382862
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#434}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Comment 31 by alekyoo@google.com, Dec 19

Status: Verified (was: Fixed)
Verified on: 
Device name: BlackBerry Priv / MMB29M 
WebView version: 72.0.3626.28

Sign in to add a comment