New issue
Advanced search Search tips

Issue 907922 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 898270



Sign in to add a comment

SkDDL renderer should pass all test that GLRenderer passes

Project Member Reported by weiliangc@chromium.org, Nov 22

Issue description

Based on trying to use SkDDL by default.

https://chromium-review.googlesource.com/c/chromium/src/+/1348255

For all platforms:
viz_unittests failures:
DisplayTest.Finish

cc_unittests failures:
LayerTreeHostImplTest.ShutdownReleasesContext

compositor_unittests failures:
LayerWithRealCompositorTest.DrawAlphaThresholdFilterPixels


There are also another set of test failures for Android, but it's longer so won't list here.
 
The DrawAlphaThresholdFilterPixels test should be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1348830
LayerTreeHostImplTest.ShutdownReleasesContext is testing the gl context release texture by using copy request to texture. Doesn't seem to be a valid cc LTHI test. (even if want to test similar things, should probably move to another place)


Including Display.Finish, there are a number of display tests that set up GL context probably different than how it's used in DDL. Need to modify these tests set up based on whether DDL or not.



Sign in to add a comment