Introduce the ability to distinguish between system echo cancellers in CrOS |
|||||||||
Issue descriptionIn order to safely widen the activation of APM in CrAS a functionality is needed to determine which echo canceller is active. The intended use of that is to switch from using the echo canceller in CrAS to the one in the Browser, in case there is need to.
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/85fa8d9c746e919b1679c1ff3a928481193a534d commit 85fa8d9c746e919b1679c1ff3a928481193a534d Author: Per Åhgren <peah@chromium.org> Date: Tue Nov 27 23:19:44 2018 CRAS: Add group ID for system AEC This CL adds the functionality to have an aec group ID, which allow Chromium to take actions that is specific for the echo canceller. BUG= chromium:907917 TEST=Build and test on buddy Change-Id: I264e1544c72e01706a3c4d9cb5bdd145e3a2176f Reviewed-on: https://chromium-review.googlesource.com/1349280 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Per Åhgren <peah@chromium.org> Reviewed-by: Hsinyu Chao <hychao@chromium.org> [modify] https://crrev.com/85fa8d9c746e919b1679c1ff3a928481193a534d/cras/src/common/cras_types.h [modify] https://crrev.com/85fa8d9c746e919b1679c1ff3a928481193a534d/cras/src/server/cras_system_state.h [modify] https://crrev.com/85fa8d9c746e919b1679c1ff3a928481193a534d/cras/src/tests/cras_test_client.c [modify] https://crrev.com/85fa8d9c746e919b1679c1ff3a928481193a534d/cras/src/libcras/cras_client.h [modify] https://crrev.com/85fa8d9c746e919b1679c1ff3a928481193a534d/cras/src/server/config/cras_board_config.c [modify] https://crrev.com/85fa8d9c746e919b1679c1ff3a928481193a534d/cras/src/server/cras_system_state.c [modify] https://crrev.com/85fa8d9c746e919b1679c1ff3a928481193a534d/cras/src/libcras/cras_client.c [modify] https://crrev.com/85fa8d9c746e919b1679c1ff3a928481193a534d/cras/src/server/cras_dbus_control.c [modify] https://crrev.com/85fa8d9c746e919b1679c1ff3a928481193a534d/cras/src/server/config/cras_board_config.h
,
Nov 29
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/4353637025b85e4a918f6f10ff7ac114dea305ab commit 4353637025b85e4a918f6f10ff7ac114dea305ab Author: Yu-Hsuan Hsu <yuhsuan@chromium.org> Date: Thu Nov 29 20:11:01 2018 CRAS: cras_dbus_control - Fix mismatched tag in XML This bug causes a lot of test errors. Fix mismatched tag in XML. BUG= chromium:907917 , chromium:909813 TEST=Can pass audio_Aplay test. Change-Id: I8d32f4c7c5033039fcb13da9b9cb4c5072d96a2f Reviewed-on: https://chromium-review.googlesource.com/1351972 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Per Åhgren <peah@chromium.org> [modify] https://crrev.com/4353637025b85e4a918f6f10ff7ac114dea305ab/cras/src/server/cras_dbus_control.c
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5dade9ffcbf5781abfed755854ea36445da711b0 commit 5dade9ffcbf5781abfed755854ea36445da711b0 Author: Per Åhgren <peah@chromium.org> Date: Fri Nov 30 23:53:58 2018 CRAS System AEC: Add support for using AEC group ID in AEC selection This CL adds the functionality to have an aec group ID, which allow Chromium to take actions that is specific for the echo canceller parameter set that is being used in the Chrome Audio Server. BUG= chromium:907917 CQ-DEPEND=CL:1349280,CL:1349353 Change-Id: I391fd0a65858a2635c8927dc2a8816dfb9cd4221 Reviewed-on: https://chromium-review.googlesource.com/c/1349260 Reviewed-by: Jenny Zhang <jennyz@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Per Åhgren <peah@chromium.org> Cr-Commit-Position: refs/heads/master@{#612852} [modify] https://crrev.com/5dade9ffcbf5781abfed755854ea36445da711b0/chromeos/audio/cras_audio_handler.cc [modify] https://crrev.com/5dade9ffcbf5781abfed755854ea36445da711b0/chromeos/audio/cras_audio_handler.h [modify] https://crrev.com/5dade9ffcbf5781abfed755854ea36445da711b0/chromeos/dbus/cras_audio_client.cc [modify] https://crrev.com/5dade9ffcbf5781abfed755854ea36445da711b0/chromeos/dbus/cras_audio_client.h [modify] https://crrev.com/5dade9ffcbf5781abfed755854ea36445da711b0/chromeos/dbus/fake_cras_audio_client.cc [modify] https://crrev.com/5dade9ffcbf5781abfed755854ea36445da711b0/chromeos/dbus/fake_cras_audio_client.h [modify] https://crrev.com/5dade9ffcbf5781abfed755854ea36445da711b0/media/audio/audio_features.cc [modify] https://crrev.com/5dade9ffcbf5781abfed755854ea36445da711b0/media/audio/audio_features.h [modify] https://crrev.com/5dade9ffcbf5781abfed755854ea36445da711b0/media/audio/cras/audio_manager_cras.cc [modify] https://crrev.com/5dade9ffcbf5781abfed755854ea36445da711b0/media/audio/cras/audio_manager_cras.h
,
Dec 4
We would like to merge this issue to M72. It landed just after the M72 cut, and is vital for extending the CrAS audio tunings to in a safe manner cover more devices. In order for the CL in this issue to be merged, the CL https://chromium-review.googlesource.com/c/1355943 does also need to be merged as it contains a required dependency. The CLs we would like to merge are -https://chromium-review.googlesource.com/1349353 -https://chromium-review.googlesource.com/c/1355943
,
Dec 4
,
Dec 5
,
Dec 5
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 5
Correction to #5 The first CL to merge should be -https://chromium-review.googlesource.com/c/1349260 (the one stated in #5 is already in M72).
,
Dec 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f25c5d1da75da490d38b500c53e6f1ec262afd4 commit 7f25c5d1da75da490d38b500c53e6f1ec262afd4 Author: Per Åhgren <peah@chromium.org> Date: Thu Dec 06 09:57:24 2018 Merge to M72: Roll src/third_party/cros_system_api/ eb9630f23..908e07846 (4 commits) https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/eb9630f2312f..908e07846946 $ git log eb9630f23..908e07846 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 aoldemeier login: Add DBus call to SessionManager to clear check_enrollment flag. 2018-11-26 xiaochu imageloader/system_api/dlcservice: move constants to system_api 2018-11-22 peah system_api: Add group ID for system AEC 2018-11-08 itspeter runtime_probe: the skeleton Created with: roll-dep src/third_party/cros_system_api R=derat@chromium.org BUG= chromium:907917 Change-Id: I4cd0cb0d357330d69a4a870bcbd45b26c8f03aad Reviewed-on: https://chromium-review.googlesource.com/c/1355943 Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Per Åhgren <peah@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612443}(cherry picked from commit 3056ec84e8d1bc1a1644908102ca3c38a65c11be) Reviewed-on: https://chromium-review.googlesource.com/c/1363831 Cr-Commit-Position: refs/branch-heads/3626@{#101} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/7f25c5d1da75da490d38b500c53e6f1ec262afd4/DEPS
,
Dec 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0819759105572ad97874af0af2bd8c49a6ecd5dd commit 0819759105572ad97874af0af2bd8c49a6ecd5dd Author: Per Åhgren <peah@chromium.org> Date: Thu Dec 06 09:59:39 2018 Merge to M72: CRAS System AEC: Add support for using AEC group ID in AEC selection This CL adds the functionality to have an aec group ID, which allow Chromium to take actions that is specific for the echo canceller parameter set that is being used in the Chrome Audio Server. BUG= chromium:907917 CQ-DEPEND=CL:1349280,CL:1349353 Change-Id: I391fd0a65858a2635c8927dc2a8816dfb9cd4221 Reviewed-on: https://chromium-review.googlesource.com/c/1349260 Reviewed-by: Jenny Zhang <jennyz@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Per Åhgren <peah@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612852}(cherry picked from commit 5dade9ffcbf5781abfed755854ea36445da711b0) Reviewed-on: https://chromium-review.googlesource.com/c/1363832 Cr-Commit-Position: refs/branch-heads/3626@{#102} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/0819759105572ad97874af0af2bd8c49a6ecd5dd/chromeos/audio/cras_audio_handler.cc [modify] https://crrev.com/0819759105572ad97874af0af2bd8c49a6ecd5dd/chromeos/audio/cras_audio_handler.h [modify] https://crrev.com/0819759105572ad97874af0af2bd8c49a6ecd5dd/chromeos/dbus/cras_audio_client.cc [modify] https://crrev.com/0819759105572ad97874af0af2bd8c49a6ecd5dd/chromeos/dbus/cras_audio_client.h [modify] https://crrev.com/0819759105572ad97874af0af2bd8c49a6ecd5dd/chromeos/dbus/fake_cras_audio_client.cc [modify] https://crrev.com/0819759105572ad97874af0af2bd8c49a6ecd5dd/chromeos/dbus/fake_cras_audio_client.h [modify] https://crrev.com/0819759105572ad97874af0af2bd8c49a6ecd5dd/media/audio/audio_features.cc [modify] https://crrev.com/0819759105572ad97874af0af2bd8c49a6ecd5dd/media/audio/audio_features.h [modify] https://crrev.com/0819759105572ad97874af0af2bd8c49a6ecd5dd/media/audio/cras/audio_manager_cras.cc [modify] https://crrev.com/0819759105572ad97874af0af2bd8c49a6ecd5dd/media/audio/cras/audio_manager_cras.h
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/9598d9b5ab07ae4198a8247c505a097e25121a97 commit 9598d9b5ab07ae4198a8247c505a097e25121a97 Author: Yu-Hsuan Hsu <yuhsuan@chromium.org> Date: Wed Dec 12 02:01:36 2018 CRAS: cras_dbus_control - Fix mismatched tag in XML This bug causes a lot of test errors. Fix mismatched tag in XML. BUG= chromium:907917 , chromium:909813 TEST=Can pass audio_Aplay test. Change-Id: I8d32f4c7c5033039fcb13da9b9cb4c5072d96a2f Reviewed-on: https://chromium-review.googlesource.com/1351972 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Per Åhgren <peah@chromium.org> (cherry picked from commit 4353637025b85e4a918f6f10ff7ac114dea305ab) Reviewed-on: https://chromium-review.googlesource.com/c/1369988 Commit-Queue: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> Tested-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> Reviewed-by: Paris Yeh <pyeh@chromium.org> Reviewed-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org> [modify] https://crrev.com/9598d9b5ab07ae4198a8247c505a097e25121a97/cras/src/server/cras_dbus_control.c
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0819759105572ad97874af0af2bd8c49a6ecd5dd Commit: 0819759105572ad97874af0af2bd8c49a6ecd5dd Author: peah@chromium.org Commiter: guidou@chromium.org Date: 2018-12-06 09:59:39 +0000 UTC Merge to M72: CRAS System AEC: Add support for using AEC group ID in AEC selection This CL adds the functionality to have an aec group ID, which allow Chromium to take actions that is specific for the echo canceller parameter set that is being used in the Chrome Audio Server. BUG= chromium:907917 CQ-DEPEND=CL:1349280,CL:1349353 Change-Id: I391fd0a65858a2635c8927dc2a8816dfb9cd4221 Reviewed-on: https://chromium-review.googlesource.com/c/1349260 Reviewed-by: Jenny Zhang <jennyz@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Per Åhgren <peah@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612852}(cherry picked from commit 5dade9ffcbf5781abfed755854ea36445da711b0) Reviewed-on: https://chromium-review.googlesource.com/c/1363832 Cr-Commit-Position: refs/branch-heads/3626@{#102} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f25c5d1da75da490d38b500c53e6f1ec262afd4 Commit: 7f25c5d1da75da490d38b500c53e6f1ec262afd4 Author: peah@chromium.org Commiter: guidou@chromium.org Date: 2018-12-06 09:57:24 +0000 UTC Merge to M72: Roll src/third_party/cros_system_api/ eb9630f23..908e07846 (4 commits) https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/eb9630f2312f..908e07846946 $ git log eb9630f23..908e07846 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 aoldemeier login: Add DBus call to SessionManager to clear check_enrollment flag. 2018-11-26 xiaochu imageloader/system_api/dlcservice: move constants to system_api 2018-11-22 peah system_api: Add group ID for system AEC 2018-11-08 itspeter runtime_probe: the skeleton Created with: roll-dep src/third_party/cros_system_api R=derat@chromium.org BUG= chromium:907917 Change-Id: I4cd0cb0d357330d69a4a870bcbd45b26c8f03aad Reviewed-on: https://chromium-review.googlesource.com/c/1355943 Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Per Åhgren <peah@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612443}(cherry picked from commit 3056ec84e8d1bc1a1644908102ca3c38a65c11be) Reviewed-on: https://chromium-review.googlesource.com/c/1363831 Cr-Commit-Position: refs/branch-heads/3626@{#101} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Dec 29
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 27