New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 907916 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

diagnostics: Modernize code after libchrome uprev

Project Member Reported by emaxx@chromium.org, Nov 22

Issue description

It would be good to clean up our code base under src/platform2/diagnostics, now that new tools from libchrome became available.

Some examples that come to mind:
1. base::Callback -> OnceCallback|RepeatingCallback.
2. base::LazyInstance -> base::NoDestructor.
3. std::atomic_flag -> base::AtomicFlag.
4. std::unique_ptr -> base::Optional (* where the semantics makes sense).
5. Get rid of brillo/bind_lambda.h usages (however, maybe only possible for captureless lambdas).
6. base::MessageLoop::current -> base::ThreadTaskRunnerHandle::Get.
 
Labels: telemetry
Cc: pbond@chromium.org
Labels: -telemetry Sarien
Labels: Enterprise-Triaged
Labels: Type-Task

Sign in to add a comment