New issue
Advanced search Search tips

Issue 907910 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Password generation on change password forms

Project Member Reported by kolos@chromium.org, Nov 22

Issue description

This is umbrella bug for password generation on change password forms
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8f00d8139e500f50908e0a47bfa73ae34cafcde

commit f8f00d8139e500f50908e0a47bfa73ae34cafcde
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Tue Nov 27 20:48:11 2018

[Password Generation] Fix uploading NEW_PASSWORD vote when a user presses "Update"

|NEW_PASSWORD| votes should be sent when a user presses "Update" button in the prompt

Bug: 907910, 552420
Change-Id: I0fd422255bd0ae599c833e11a9b64529d8bddecb
Reviewed-on: https://chromium-review.googlesource.com/c/1350611
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611301}
[modify] https://crrev.com/f8f00d8139e500f50908e0a47bfa73ae34cafcde/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/f8f00d8139e500f50908e0a47bfa73ae34cafcde/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/f8f00d8139e500f50908e0a47bfa73ae34cafcde/components/password_manager/core/browser/new_password_form_manager.cc
[modify] https://crrev.com/f8f00d8139e500f50908e0a47bfa73ae34cafcde/components/password_manager/core/browser/new_password_form_manager.h
[modify] https://crrev.com/f8f00d8139e500f50908e0a47bfa73ae34cafcde/components/password_manager/core/browser/new_password_form_manager_unittest.cc
[modify] https://crrev.com/f8f00d8139e500f50908e0a47bfa73ae34cafcde/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/f8f00d8139e500f50908e0a47bfa73ae34cafcde/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/f8f00d8139e500f50908e0a47bfa73ae34cafcde/components/password_manager/core/browser/password_form_manager_for_ui.h
[modify] https://crrev.com/f8f00d8139e500f50908e0a47bfa73ae34cafcde/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/f8f00d8139e500f50908e0a47bfa73ae34cafcde/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/f8f00d8139e500f50908e0a47bfa73ae34cafcde/components/password_manager/core/browser/password_manager_client.cc
[modify] https://crrev.com/f8f00d8139e500f50908e0a47bfa73ae34cafcde/components/password_manager/core/browser/password_manager_client.h
[modify] https://crrev.com/f8f00d8139e500f50908e0a47bfa73ae34cafcde/components/password_manager/core/browser/votes_uploader.cc
[modify] https://crrev.com/f8f00d8139e500f50908e0a47bfa73ae34cafcde/components/password_manager/core/browser/votes_uploader_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1a1f83ac97db0128de76060c04f4c2c2f931ee9

commit d1a1f83ac97db0128de76060c04f4c2c2f931ee9
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Wed Dec 19 16:01:18 2018

[Password Manager] Don't consider server predictions for password fields in SAVING mode

As server predictions for password fields can be incomplete (no current password prediction on a change password form or no confirmation password prediction while the confirmation field is present), don't use the predictions in SAVING mode.

At the moment, the client heuristics (|LocateSpecificPasswords|) is more reliable when user-typed values are available.

When the server will be able to provide complete predictions, use them for more accurate saving (trust only server prediction or combine with the client heuristics).

Bug: 907910, 552420, 913965
Change-Id: I63eee5a6a8fceb3cef23bfd1a955c96ec44d0b7d
Reviewed-on: https://chromium-review.googlesource.com/c/1371813
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617844}
[modify] https://crrev.com/d1a1f83ac97db0128de76060c04f4c2c2f931ee9/components/password_manager/core/browser/form_parsing/form_parser.cc
[modify] https://crrev.com/d1a1f83ac97db0128de76060c04f4c2c2f931ee9/components/password_manager/core/browser/form_parsing/form_parser_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 4

Labels: merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7d3f64731cf3b09707d1ba6755588ec5d8a0168

commit a7d3f64731cf3b09707d1ba6755588ec5d8a0168
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Jan 04 14:47:14 2019

[Merge-M72][Password Manager] Don't consider server predictions for password fields in SAVING mode

As server predictions for password fields can be incomplete (no current password prediction on a change password form or no confirmation password prediction while the confirmation field is present), don't use the predictions in SAVING mode.

At the moment, the client heuristics (|LocateSpecificPasswords|) is more reliable when user-typed values are available.

When the server will be able to provide complete predictions, use them for more accurate saving (trust only server prediction or combine with the client heuristics).

TBR=kolos@chromium.org

(cherry picked from commit d1a1f83ac97db0128de76060c04f4c2c2f931ee9)

Bug: 907910, 552420, 913965
Change-Id: I63eee5a6a8fceb3cef23bfd1a955c96ec44d0b7d
Reviewed-on: https://chromium-review.googlesource.com/c/1371813
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#617844}
Reviewed-on: https://chromium-review.googlesource.com/c/1396027
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#560}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/a7d3f64731cf3b09707d1ba6755588ec5d8a0168/components/password_manager/core/browser/form_parsing/form_parser.cc
[modify] https://crrev.com/a7d3f64731cf3b09707d1ba6755588ec5d8a0168/components/password_manager/core/browser/form_parsing/form_parser_unittest.cc

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/a7d3f64731cf3b09707d1ba6755588ec5d8a0168

Commit: a7d3f64731cf3b09707d1ba6755588ec5d8a0168
Author: kolos@chromium.org
Commiter: kolos@chromium.org
Date: 2019-01-04 14:47:14 +0000 UTC

[Merge-M72][Password Manager] Don't consider server predictions for password fields in SAVING mode

As server predictions for password fields can be incomplete (no current password prediction on a change password form or no confirmation password prediction while the confirmation field is present), don't use the predictions in SAVING mode.

At the moment, the client heuristics (|LocateSpecificPasswords|) is more reliable when user-typed values are available.

When the server will be able to provide complete predictions, use them for more accurate saving (trust only server prediction or combine with the client heuristics).

TBR=kolos@chromium.org

(cherry picked from commit d1a1f83ac97db0128de76060c04f4c2c2f931ee9)

Bug: 907910, 552420, 913965
Change-Id: I63eee5a6a8fceb3cef23bfd1a955c96ec44d0b7d
Reviewed-on: https://chromium-review.googlesource.com/c/1371813
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#617844}
Reviewed-on: https://chromium-review.googlesource.com/c/1396027
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#560}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment