[Background Fetch API] Fetched File showing wrong date and time in download sectionIssue Summary |
|||||||||
Issue descriptionApplication Version (from "Chrome Settings > About Chrome"): 71.0.3578.64 Android Build Number (from "Android Settings > About Phone/Tablet"): 8.0.0 Device: Samsung Galaxy Note 8(SM-N950F) Steps to reproduce: 1) Launch chrome 2) Enable "Experimental Web Platform Features" flag 3) Navigate to "https://backgroundfetch.com" 4) Make sure "Fetch a text file" and "Fetch an image" 5) Tap on "Start Background Fetch" button 6) Go to Menu-->Downloads and notice 7) Go back to "https://backgroundfetch.com" page 8) Now select "Fetch a file with a delay of '5' seconds" 9) Go to Menu-->Downloads and notice Observed behavior: 6. Date and time of a downloaded file is not correct 9. Though multiple files has downloaded, they are not listed in "Downloads" section. Expected behavior: 6. Correct date and time should be displayed 7. All files fetched should reflect in "Downloads" section Frequency: 5/5 <number of times you were able to reproduce> Additional comments:
,
Nov 22
[making public] Thank you for testing! This indeed shouldn't happen, can you take a look Mugdha? We shouldn't show up on the downloads page at all, but I'm not sure what that'd mean for the snackbar.
,
Nov 23
,
Nov 23
I installed the 71 build on a Pixel 2, and I'm not able to see the snackbar/toast at all. I also don't see anything in Menu-->Downloads. Is there a flag that turns the snackbar on?
,
Nov 23
Update: I am able to see the snackbar on other sites (e.g., drive.google.com) when a download completes, and am also able to see these files in Downloads home. I'm not able to see this for BackgroundFetch, which is WAI according to me. Will try some other recent builds to double check.
,
Nov 23
My bad, I was testing with the non-modern apk on Android N+. I can repro now on 71.0.3578.64, but not on the latest master chrome_modern_apk build or chrome_modern_public_apk builds.
,
Nov 23
I've also failed to repro on a later official (modern) canary build: 72.0.3570.0.
,
Nov 23
Assigning to Shakti to see if he knows something that has changed recently to fix it, so we can merge it back to 71, thanks!
,
Nov 23
Fyi for Shakti from just reading through this: We may not be filtering transient downloads correctly in the new downloads home. Should be easy to check by simulating a download from the downloads internals page? On Fri, Nov 23, 2018, 8:54 AM nator via monorail < monorail+v2.2115502119@chromium.org wrote:
,
Nov 24
Ah it looks like this is using the old downloads home. We should confirm we're setting and propagating the istransient flag that should hide this!
,
Nov 26
This issue is now not reproducible on latest M72-72.0.3622.0, but still observed on M71-71.0.3578.72 when "Download home V2" flag is enabled.
,
Nov 27
The download shouldn't show up in download home, and on the infobar. In new download home, we were not filtering this out and hence it shows up if the download is inprogress while the download home is open. Fixing this with CL : https://chromium-review.googlesource.com/c/chromium/src/+/1351717 However in old download home, the transient is already filtered out, so shouldn't show up. Is there any way that we may not be marking it as transient for the given 71 version?
,
Nov 27
Adding RBS for tracking purpose
,
Nov 27
Can you reproduce this on the M-71 latest?
,
Nov 27
Cannot see the issue on 71.0.3578.73. The download doesn't show up on the download home which is correct. Please let me know if you are able to see the download on download home. Note: We still show it when snackbar is enabled, which is okay for now, since snackbars are going away soon (behind a flag right now) But the real problem is that we shouldn't see this on download home. However I can't repro this on 71 latest.
,
Nov 27
Update : I found out that the attached video is when new download home enabled, which was a bug, but I just fixed in the CL https://chromium-review.googlesource.com/c/chromium/src/+/1351717 Sorry my bad, for some reason I was thinking that the reported UI was old download home, as they looked very very similar! Hence marking this as fixed, since both new and old download home should now filter out background fetch downloads for both M71 and M72.
,
Nov 27
[Auto-generated comment by a script] We noticed that this issue is targeted for M-71; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-71 label, otherwise remove Merge-TBD label. Thanks.
,
Nov 27
,
Nov 28
This issue is now not reproducible on latest M71-71.0.3578.75, verified on Pixel XL/PPR2.181005.004
,
Nov 28
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by dknandiraju@chromium.org
, Nov 22