WebglConformance_conformance_extensions_oes_texture_half_float_with_canvas Failing on Win7 FYI Release (AMD) |
||||
Issue description
The gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance_extensions_oes_texture_half_float_with_canvas test is failing on at least two configurations:
webgl_conformance_d3d11_validating_tests
webgl_conformance_d3d9_passthrough_tests
It appears to be due to a failing assertion in AudioServiceListener::Metrics::ServiceStopped:
...
chrome!logging::LogMessage::~LogMessage+0x4a0
chrome!content::AudioServiceListener::Metrics::ServiceStopped+0x65
chrome!content::AudioServiceListener::OnServiceStopped+0x74
chrome!service_manager::mojom::ServiceManagerListenerStubDispatch::Accept+0x4ad
chrome!service_manager::mojom::ServiceManagerListenerStub<mojo::RawPtrImplRefTraits<service_manager::mojom::ServiceManagerListener> >::Accept+0x13
chrome!mojo::InterfaceEndpointClient::HandleValidatedMessage+0x21d
chrome!mojo::FilterChain::Accept+0x83
chrome!mojo::InterfaceEndpointClient::HandleIncomingMessage+0x6a
chrome!mojo::internal::MultiplexRouter::ProcessIncomingMessage+0x2ce
chrome!mojo::internal::MultiplexRouter::Accept+0x127
chrome!mojo::FilterChain::Accept+0x83
chrome!mojo::Connector::ReadSingleMessage+0x258
chrome!mojo::Connector::ReadAllAvailableMessages+0x58
chrome!mojo::Connector::OnHandleReadyInternal+0x7e
...
Suspecting https://chromium-review.googlesource.com/c/chromium/src/+/1345548 because it changes the audio APIs. Going to revert because it's a holiday in the US.
,
Nov 22
,
Nov 26
Closing this since the revert fixed it.
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bdf26ad8f19ee9b629e09eb04ecc95c870fe772 commit 3bdf26ad8f19ee9b629e09eb04ecc95c870fe772 Author: Ken Rockot <rockot@google.com> Date: Tue Nov 27 18:10:27 2018 Fix raciness in AudioServiceListener This fixes potential race conditions in AudioServiceListener resulting from the fact that a service instance can become unreachable (and may therefore be replaced with a new one) before it is officially designated as "stopped" by the Service Manager, even in the case of singleton services. The ServiceManagerListener API is augmented to convey a service instance's current running state via RunningServiceInfo. This is used by AudioServiceListener to more accurately track the running audio service instance. The listener now tracks the Identity of the most recently created audio service instance and responds to events accordingly. This also updates the logic and comments in resource_coordinator's ProcessMap to accurately reflect current guarantees of the ServiceManagerListener API, since these have changed slightly. NOTRY=true Bug: 818593 , 907898 ,908319 Change-Id: If3e8a35aa90db72a34c8f5f2d458f0f24c3447eb Reviewed-on: https://chromium-review.googlesource.com/c/1350649 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Olga Sharonova <olka@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#611193} [modify] https://crrev.com/3bdf26ad8f19ee9b629e09eb04ecc95c870fe772/content/browser/renderer_host/media/audio_service_listener.cc [modify] https://crrev.com/3bdf26ad8f19ee9b629e09eb04ecc95c870fe772/content/browser/renderer_host/media/audio_service_listener.h [modify] https://crrev.com/3bdf26ad8f19ee9b629e09eb04ecc95c870fe772/content/browser/renderer_host/media/audio_service_listener_unittest.cc [modify] https://crrev.com/3bdf26ad8f19ee9b629e09eb04ecc95c870fe772/services/resource_coordinator/memory_instrumentation/process_map.cc [modify] https://crrev.com/3bdf26ad8f19ee9b629e09eb04ecc95c870fe772/services/service_manager/public/mojom/service_manager.mojom [modify] https://crrev.com/3bdf26ad8f19ee9b629e09eb04ecc95c870fe772/services/service_manager/service_manager.cc [modify] https://crrev.com/3bdf26ad8f19ee9b629e09eb04ecc95c870fe772/services/service_manager/service_manager.h
,
Nov 27
Unlinking the other bugs now that above CL has landed, as these bugs apply to a much larger effort than just fixing AudioServiceListener's behavior, and subsequent CLs would add a lot of unrelated noise to this bug. Please feel free to re-link the bugs if you feel it serves a purpose I'm overlooking!
,
Nov 28
Thanks Ken for tracking this down and fixing it. CLs that refer to those other bugs won't cause this one to receive updates, and it's really useful to be able to click through the bug tree to find out what regressions were caused by certain features, so let me reinstate the blocking relationship for those other two bugs.
,
Nov 28
Oh sorry, I didn't think that should be the case, but I somewhat idiotically overlooked the fact that this bug was explicitly referenced in my commit. X} |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Nov 22