New issue
Advanced search Search tips

Issue 907885 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 23
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Soundwave doesn't quickly exit on Ctrl+C

Project Member Reported by perezju@chromium.org, Nov 22

Issue description

... or in case of errors.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/e8ac8cce286535af96f08e5f261e120d95d48da4

commit e8ac8cce286535af96f08e5f261e120d95d48da4
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Fri Nov 23 11:31:05 2018

[soundwave] On finalization terminate pool, don't close.

When there is an error (or e.g. the user tries Ctrl+C to keyboard
interrupt), pool.close() will wait for all existing jobs to finish.

Instead pool.terminate() will promptly shut everything down and
quit.

Bug:  chromium:907885 
Change-Id: I452ebedbe6a58be14166c3afeaa77a6d0141696a
Reviewed-on: https://chromium-review.googlesource.com/c/1347990
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>

[modify] https://crrev.com/e8ac8cce286535af96f08e5f261e120d95d48da4/experimental/soundwave/soundwave/worker_pool.py

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b778d86c12f35f8fef5285009f67978960af2837

commit b778d86c12f35f8fef5285009f67978960af2837
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Nov 23 14:26:19 2018

Roll src/third_party/catapult 4ed4737007d8..43e8ebcaf284 (2 commits)

https://chromium.googlesource.com/catapult.git/+log/4ed4737007d8..43e8ebcaf284


git log 4ed4737007d8..43e8ebcaf284 --date=short --no-merges --format='%ad %ae %s'
2018-11-23 perezju@chromium.org [soundwave] Use /timeseries2 to fetch data on -i option
2018-11-23 perezju@chromium.org [soundwave] On finalization terminate pool, don't close.


Created with:
  gclient setdep -r src/third_party/catapult@43e8ebcaf284

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:900218, chromium:907885 
TBR=sullivan@chromium.org

Change-Id: Id2475cd9a73b69a2231b508deb72467107836bd6
Reviewed-on: https://chromium-review.googlesource.com/c/1349434
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610602}
[modify] https://crrev.com/b778d86c12f35f8fef5285009f67978960af2837/DEPS

Sign in to add a comment