New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 14
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment
link

Issue 907882: SigninManager should get LST from credential provider when possible

Reported by rogerta@chromium.org, Nov 22 Project Member

Issue description

When the user creates an account with the credential provider, this account should be used to sign in to chrome.
 

Comment 1 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599

commit 4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599
Author: Roger Tawa <rogerta@chromium.org>
Date: Fri Dec 14 15:19:55 2018

SigninManager should get LST from credential provider when possible

Bug:  907882 
Change-Id: Icaf7f785bf05ab24ab098e91453df9d1fe787295
Reviewed-on: https://chromium-review.googlesource.com/c/1347787
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616678}
[modify] https://crrev.com/4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599/chrome/browser/BUILD.gn
[modify] https://crrev.com/4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599/chrome/browser/profiles/profile_manager.cc
[modify] https://crrev.com/4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599/chrome/browser/profiles/profile_window.cc
[modify] https://crrev.com/4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599/chrome/browser/profiles/profile_window.h
[modify] https://crrev.com/4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599/chrome/browser/signin/signin_manager_factory.cc
[add] https://crrev.com/4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599/chrome/browser/signin/signin_util_win.cc
[add] https://crrev.com/4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599/chrome/browser/signin/signin_util_win.h
[add] https://crrev.com/4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599/chrome/browser/signin/signin_util_win_browsertest.cc
[modify] https://crrev.com/4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599/chrome/credential_provider/common/gcp_strings.cc
[modify] https://crrev.com/4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599/chrome/credential_provider/common/gcp_strings.h
[modify] https://crrev.com/4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599/chrome/credential_provider/gaiacp/scoped_user_profile.cc
[modify] https://crrev.com/4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599/chrome/test/BUILD.gn
[modify] https://crrev.com/4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599/components/signin/core/browser/profile_oauth2_token_service.cc
[modify] https://crrev.com/4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599/components/signin/core/browser/signin_manager_base.cc
[modify] https://crrev.com/4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599/components/signin/core/browser/signin_metrics.h
[modify] https://crrev.com/4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599/components/signin/core/browser/signin_pref_names.cc
[modify] https://crrev.com/4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599/components/signin/core/browser/signin_pref_names.h
[modify] https://crrev.com/4d0a6f56f8e3f6b9f75b0ed40eef99505b2c2599/tools/metrics/histograms/enums.xml

Comment 2 by rogerta@chromium.org, Dec 14

Status: Fixed (was: Started)

Sign in to add a comment