New issue
Advanced search Search tips

Issue 907880 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

isolate: remove --config-variable, --path-variable, --extra-variable

Project Member Reported by mar...@chromium.org, Nov 22

Issue description

Removing these and deploying everywhere will ensure they are not used. This further reduces the reliance on the '.isolate' file format. This will make the transition to 'isolated' easier.
 
Summary: isolate: remove --config-variable, --path-variable, --extra-variable (was: isolate.py: remove --config-variable, --path-variable, --extra-variable)
Including both 'isolate.py' and 'isolate' in Go as a single bug.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 24

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/06d61d5c4017c4f5ccbbf752283b36ae9bea13f8

commit 06d61d5c4017c4f5ccbbf752283b36ae9bea13f8
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Sat Nov 24 18:32:12 2018

isolate: deprecate isolate variables

R=qyearsley@chromium.org

Bug: 907880
Change-Id: Ia53bbf58d97c68eeb3a86ad7ee7e544f8a39740a
Reviewed-on: https://chromium-review.googlesource.com/c/1347493
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/06d61d5c4017c4f5ccbbf752283b36ae9bea13f8/client/cmd/isolate/common.go

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/8b7f24eff3ec0998fef52b568fba9bc5e53aa495

commit 8b7f24eff3ec0998fef52b568fba9bc5e53aa495
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Mon Nov 26 21:31:47 2018

[client] Add warning about variable flags

R=qyearsley@chromium.org

Bug: 907880
Change-Id: I4d097a78c2af97a71dd539f37a912514e9f83772
Reviewed-on: https://chromium-review.googlesource.com/c/1347671
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/8b7f24eff3ec0998fef52b568fba9bc5e53aa495/client/isolate.py
[modify] https://crrev.com/8b7f24eff3ec0998fef52b568fba9bc5e53aa495/client/tests/isolate_smoke_test.py

Sign in to add a comment