New issue
Advanced search Search tips

Issue 907859 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 907804
Owner: ----
Closed: Nov 23
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug
Flaky-Test: FrameImplTest.ExecuteJavaScriptImmediate



Sign in to add a comment

FrameImplTest.ExecuteJavaScriptImmediate is flaky

Project Member Reported by Findit, Nov 22

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0bf74011bcc7ad290f9ebbf2301e7518d0c6661

commit f0bf74011bcc7ad290f9ebbf2301e7518d0c6661
Author: Anders Hartvoll Ruud <andruud@chromium.org>
Date: Thu Nov 22 14:16:46 2018

Disable flaky test: FrameImplTest.ExecuteJavaScriptImmediate.

TBR=jamesr@chromium.org

Bug:  907859 
Change-Id: Ia9b893ce42f89121c12f52dc7b4cddc4b97dc635
Reviewed-on: https://chromium-review.googlesource.com/c/1348066
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610406}
[modify] https://crrev.com/f0bf74011bcc7ad290f9ebbf2301e7518d0c6661/webrunner/browser/frame_impl_browsertest.cc

Components: Internals>PlatformIntegration
Labels: OS-Fuchsia
Mergedinto: 907804
Status: Duplicate (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8c78a28251a4fa7fef218d47b83cfad39dca314

commit d8c78a28251a4fa7fef218d47b83cfad39dca314
Author: Wez <wez@chromium.org>
Date: Tue Nov 27 18:37:40 2018

Revert "Disable all tests in FrameImplTest."

This reverts commit 912050e157c4fd552a19a44d87cbd67e42d38411.

Reason for revert: Fuchsia SDK believed to be the cause of these failures; speculatively reverting to re-enable the tests to evaluate.

Original change's description:
> Disable all tests in FrameImplTest.
>
> Almost all have been reported as flaky. Disable all to avoid having
> reports coming in from whichever subtest was not reported yet. Caused a
> lot of red jobs on the Fuchsia x64 bot.
>
> TBR=wez@chromium.org
>
> Bug:  907804 
> Change-Id: I2fb4da79bf1e4251e14900ef4cabb890b7b3380d
> Reviewed-on: https://chromium-review.googlesource.com/c/1349315
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Commit-Queue: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610580}

TBR=wez@chromium.org,futhark@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  907804 ,  907859 ,  907717 
Change-Id: I72103faff6457a93136925afdab9d7f003061369
Reviewed-on: https://chromium-review.googlesource.com/c/1351100
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611212}
[modify] https://crrev.com/d8c78a28251a4fa7fef218d47b83cfad39dca314/webrunner/browser/frame_impl_browsertest.cc
[modify] https://crrev.com/d8c78a28251a4fa7fef218d47b83cfad39dca314/webrunner/renderer/on_load_script_injector.h

Sign in to add a comment