New issue
Advanced search Search tips

Issue 907849 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 864871

Blocking:
issue 701330


Show other hotlists

Hotlists containing this issue:
WebRTC-1.0-Spec-Compliance


Sign in to add a comment

Implement RTCDtlsTransport

Project Member Reported by hta@chromium.org, Nov 22

Issue description

Blockedon: 864871
it doesn't make much sense to ship this before RTCIceTransport rolls out, so marking it as blocked on RTCIceTransport implementation.

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1081d0ac7c5532ddbd4a66c776e6ec8c6d36b01a

commit 1081d0ac7c5532ddbd4a66c776e6ec8c6d36b01a
Author: Harald Alvestrand <hta@chromium.org>
Date: Sun Nov 25 12:24:35 2018

Implement IDL surface for RTCDtlsTransport

This provides the IDL surface only, there is no connection to the
underlying objects.

Bug: 907849
Change-Id: Ie11bac767c6a26628c1bc757d2529f1192a07e40
Reviewed-on: https://chromium-review.googlesource.com/c/1348064
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610730}
[modify] https://crrev.com/1081d0ac7c5532ddbd4a66c776e6ec8c6d36b01a/third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
[modify] https://crrev.com/1081d0ac7c5532ddbd4a66c776e6ec8c6d36b01a/third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
[modify] https://crrev.com/1081d0ac7c5532ddbd4a66c776e6ec8c6d36b01a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1081d0ac7c5532ddbd4a66c776e6ec8c6d36b01a/third_party/blink/renderer/modules/event_target_modules_names.json5
[modify] https://crrev.com/1081d0ac7c5532ddbd4a66c776e6ec8c6d36b01a/third_party/blink/renderer/modules/modules_idl_files.gni
[modify] https://crrev.com/1081d0ac7c5532ddbd4a66c776e6ec8c6d36b01a/third_party/blink/renderer/modules/peerconnection/BUILD.gn
[add] https://crrev.com/1081d0ac7c5532ddbd4a66c776e6ec8c6d36b01a/third_party/blink/renderer/modules/peerconnection/rtc_dtls_transport.cc
[add] https://crrev.com/1081d0ac7c5532ddbd4a66c776e6ec8c6d36b01a/third_party/blink/renderer/modules/peerconnection/rtc_dtls_transport.h
[add] https://crrev.com/1081d0ac7c5532ddbd4a66c776e6ec8c6d36b01a/third_party/blink/renderer/modules/peerconnection/rtc_dtls_transport.idl
[modify] https://crrev.com/1081d0ac7c5532ddbd4a66c776e6ec8c6d36b01a/third_party/blink/renderer/platform/runtime_enabled_features.json5

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/ad88c886d7f4cee4c76be740da207d812a086efa

commit ad88c886d7f4cee4c76be740da207d812a086efa
Author: Harald Alvestrand <hta@webrtc.org>
Date: Wed Nov 28 19:39:28 2018

Add API for returning a webrtc::DtlsTransport for a MID on a PC

This includes a refactoring of jseptransport to store a refcounted
object instead of a std::unique_ptr to the cricket::DtlsTransport.

Bug: chromium:907849
Change-Id: Ib557ce72c2e6ce8af297c2b8deb7ec3a103d6d31
Reviewed-on: https://webrtc-review.googlesource.com/c/111920
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25831}
[modify] https://crrev.com/ad88c886d7f4cee4c76be740da207d812a086efa/api/BUILD.gn
[modify] https://crrev.com/ad88c886d7f4cee4c76be740da207d812a086efa/api/DEPS
[add] https://crrev.com/ad88c886d7f4cee4c76be740da207d812a086efa/api/dtlstransportinterface.h
[modify] https://crrev.com/ad88c886d7f4cee4c76be740da207d812a086efa/api/peerconnectioninterface.cc
[modify] https://crrev.com/ad88c886d7f4cee4c76be740da207d812a086efa/api/peerconnectioninterface.h
[modify] https://crrev.com/ad88c886d7f4cee4c76be740da207d812a086efa/pc/BUILD.gn
[add] https://crrev.com/ad88c886d7f4cee4c76be740da207d812a086efa/pc/dtlstransport.cc
[add] https://crrev.com/ad88c886d7f4cee4c76be740da207d812a086efa/pc/dtlstransport.h
[modify] https://crrev.com/ad88c886d7f4cee4c76be740da207d812a086efa/pc/jseptransport.cc
[modify] https://crrev.com/ad88c886d7f4cee4c76be740da207d812a086efa/pc/jseptransport.h
[modify] https://crrev.com/ad88c886d7f4cee4c76be740da207d812a086efa/pc/jseptransport_unittest.cc
[modify] https://crrev.com/ad88c886d7f4cee4c76be740da207d812a086efa/pc/jseptransportcontroller.cc
[modify] https://crrev.com/ad88c886d7f4cee4c76be740da207d812a086efa/pc/jseptransportcontroller.h
[modify] https://crrev.com/ad88c886d7f4cee4c76be740da207d812a086efa/pc/jseptransportcontroller_unittest.cc
[modify] https://crrev.com/ad88c886d7f4cee4c76be740da207d812a086efa/pc/peerconnection.cc
[modify] https://crrev.com/ad88c886d7f4cee4c76be740da207d812a086efa/pc/peerconnection.h
[modify] https://crrev.com/ad88c886d7f4cee4c76be740da207d812a086efa/pc/peerconnection_bundle_unittest.cc
[modify] https://crrev.com/ad88c886d7f4cee4c76be740da207d812a086efa/rtc_base/fakenetwork.h

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4fc95699a752eb1f14d7e83f47e462cd6f242fc

commit a4fc95699a752eb1f14d7e83f47e462cd6f242fc
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Sun Dec 02 16:22:36 2018

Roll src/third_party/webrtc 0cc11b4b947e..21d8b181f663 (47 commits)

https://webrtc.googlesource.com/src.git/+log/0cc11b4b947e..21d8b181f663


git log 0cc11b4b947e..21d8b181f663 --date=short --no-merges --format='%ad %ae %s'
2018-12-02 kwiberg@webrtc.org Remove some unused forward declarations
2018-12-01 zstein@webrtc.org Add transaction id to candidate pair event log parser and encoder.
2018-12-01 zstein@webrtc.org Log DTLS writable changes to RtcEventLog
2018-12-01 benwright@webrtc.org Add BufferedFrameDecryptor to cleanly deal with receiving encrypted frames.
2018-12-01 qingsi@webrtc.org Revert "Fix output period in RtcEventLogImpl"
2018-11-30 magjed@webrtc.org Android: Add constant for native EGL NO_CONTEXT
2018-11-30 zstein@webrtc.org Reland "Add transaction id to CandidatePairEvents."
2018-11-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 173a384b25..3546854f59 (612554:612694)
2018-11-30 ouj@fb.com Parse `ice_unwritable_timeout` and `ice_unwritable_min_checks` from RTCConfiguration into IceConfig
2018-11-30 steveanton@webrtc.org Add integration test for new GetStats() with many tracks
2018-11-30 eladalon@webrtc.org Fix output period in RtcEventLogImpl
2018-11-30 sprang@webrtc.org Remove deprecated VideoEncoder metadata methods
2018-11-30 mirtad@webrtc.org Add metadata from VideoEncoderFactory::CodecInfo to VideoEncoder::EncoderInfo
2018-11-30 nisse@webrtc.org Move implementation of LoopbackMediaTransport to .cc file
2018-11-30 srte@webrtc.org Fixes DCHECK bug in LinkCapacityEstimator.
2018-11-30 srte@webrtc.org Friendlier error messages from data unit classes.
2018-11-30 sprang@webrtc.org Revert "Add transaction id to CandidatePairEvents."
2018-11-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 77dd2659f0..173a384b25 (612445:612554)
2018-11-30 braveyao@webrtc.org desktop_capture: apply scale to cursor relative positon on Mac only
2018-11-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d6514607ce..77dd2659f0 (612330:612445)
2018-11-29 zstein@webrtc.org Add transaction id to CandidatePairEvents.
2018-11-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0a7ee90062..d6514607ce (612216:612330)
2018-11-29 srte@webrtc.org Extracts LinkCapacityEstimator from AimdRateControl.
2018-11-29 sprang@webrtc.org Cap probing bitrate to max total allocated bitrate
2018-11-29 crodbro@webrtc.org Unittests for loss based bandwidth estimation.
2018-11-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f85d2e4da0..0a7ee90062 (612092:612216)
2018-11-29 phoglund@webrtc.org Revert "Various VP9 high fps fixes"
2018-11-29 phoglund@webrtc.org Try UWP with msvc.
2018-11-29 sprang@webrtc.org Make simulcast screenshare default-on
2018-11-29 nisse@webrtc.org Delete method EncodedFrame::GetBitstream, part 2
2018-11-29 nisse@webrtc.org Move size() method to EncodedImage base class
2018-11-29 phoglund@webrtc.org Disable goma for uwp bots.
2018-11-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2f5059a4ae..f85d2e4da0 (611832:612092)
2018-11-29 phoglund@webrtc.org Add Win UWP bots.
2018-11-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 28d6168850..2f5059a4ae (611644:611832)
2018-11-28 steveanton@webrtc.org [Unified Plan] Fix old GetStats() not associating track id
2018-11-28 zstein@webrtc.org Log DTLS state changes to RtcEventLog
2018-11-28 hta@webrtc.org Add API for returning a webrtc::DtlsTransport for a MID on a PC
2018-11-28 yvesg@webrtc.org [Cleanup] Add missing #include. Remove useless ones. IWYU part 2.
2018-11-28 oprypin@webrtc.org Add new names of perf bots that will be migrated to LUCI
2018-11-28 ssilkin@webrtc.org Keep bitrate constraints.
2018-11-28 artit@webrtc.org Reland "Run robolectric tests for Android on several Android API versions"
2018-11-28 nisse@webrtc.org Add video support to LoopbackMediaTransport
2018-11-28 nisse@webrtc.org Delete ssrc book-keeping in NetEq
2018-11-28 andersc@webrtc.org React to changes in either width or height in iOS Metal renderer.
2018-11-28 sakal@webrtc.org Add missing files to AAR.
2018-11-28 nisse@webrtc.org Delete method EncodedFrame::GetBitstream, part 1


Created with:
  gclient setdep -r src/third_party/webrtc@21d8b181f663

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:909784,chromium:None,chromium:None,chromium:none,chromium:None,chromium:690537,chromium:None,chromium:None,chromium:906988,chromium:907849,chromium:908001
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ia2a0ebb98aeece46ef99b2c5f9e622f088ba3822
Reviewed-on: https://chromium-review.googlesource.com/c/1357892
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612977}
[modify] https://crrev.com/a4fc95699a752eb1f14d7e83f47e462cd6f242fc/DEPS

Labels: Target-73
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/41390474fc04889892cfc4df0e2e57a9654f1e70

commit 41390474fc04889892cfc4df0e2e57a9654f1e70
Author: Harald Alvestrand <hta@webrtc.org>
Date: Tue Dec 04 10:29:32 2018

Add LookupDtlsTransportByMid to proxy map

Bug: chromium:907849
Change-Id: Ib707f18fdf67617967b83cd17f0454d182b8011f
Reviewed-on: https://webrtc-review.googlesource.com/c/112907
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25885}
[modify] https://crrev.com/41390474fc04889892cfc4df0e2e57a9654f1e70/api/peerconnectioninterface.cc
[modify] https://crrev.com/41390474fc04889892cfc4df0e2e57a9654f1e70/api/peerconnectioninterface.h
[modify] https://crrev.com/41390474fc04889892cfc4df0e2e57a9654f1e70/api/peerconnectionproxy.h
[modify] https://crrev.com/41390474fc04889892cfc4df0e2e57a9654f1e70/pc/test/fakepeerconnectionbase.h

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0eeec60faf7ab7e726dfaf4a5e9a577acbf47691

commit 0eeec60faf7ab7e726dfaf4a5e9a577acbf47691
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Dec 04 14:41:54 2018

Roll src/third_party/webrtc d0b69a8c50f4..41390474fc04 (1 commits)

https://webrtc.googlesource.com/src.git/+log/d0b69a8c50f4..41390474fc04


git log d0b69a8c50f4..41390474fc04 --date=short --no-merges --format='%ad %ae %s'
2018-12-04 hta@webrtc.org Add LookupDtlsTransportByMid to proxy map


Created with:
  gclient setdep -r src/third_party/webrtc@41390474fc04

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:907849
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Idbd07bccf7bce585248d3c45ced81247ef7db5bf
Reviewed-on: https://chromium-review.googlesource.com/c/1360794
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613544}
[modify] https://crrev.com/0eeec60faf7ab7e726dfaf4a5e9a577acbf47691/DEPS

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/628f37a6fe24cd7783b3446d40b2e26752cc6ebb

commit 628f37a6fe24cd7783b3446d40b2e26752cc6ebb
Author: Harald Alvestrand <hta@webrtc.org>
Date: Thu Dec 06 12:06:34 2018

Delete a cricket::DtlsTransport when PC is closed

This avoids use-after-free problems that occur when references
to webrtc::DtlsTransport objects are held outside of the PC.

Bug: chromium:907849
Change-Id: Id428c8e616482eff0f4327d2eac17e29bb3f6484
Reviewed-on: https://webrtc-review.googlesource.com/c/113303
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25915}
[modify] https://crrev.com/628f37a6fe24cd7783b3446d40b2e26752cc6ebb/pc/dtlstransport.h
[modify] https://crrev.com/628f37a6fe24cd7783b3446d40b2e26752cc6ebb/pc/jseptransport.cc
[modify] https://crrev.com/628f37a6fe24cd7783b3446d40b2e26752cc6ebb/pc/jseptransportcontroller_unittest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c100291e910c399ebd733edf3b23ba1483c6843

commit 7c100291e910c399ebd733edf3b23ba1483c6843
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Dec 06 14:46:39 2018

Roll src/third_party/webrtc fafae11bfc4c..628f37a6fe24 (1 commits)

https://webrtc.googlesource.com/src.git/+log/fafae11bfc4c..628f37a6fe24


git log fafae11bfc4c..628f37a6fe24 --date=short --no-merges --format='%ad %ae %s'
2018-12-06 hta@webrtc.org Delete a cricket::DtlsTransport when PC is closed


Created with:
  gclient setdep -r src/third_party/webrtc@628f37a6fe24

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:907849
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ie1e59d6a33a293fd29401a6f788a14412896c3cb
Reviewed-on: https://chromium-review.googlesource.com/c/1365418
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#614343}
[modify] https://crrev.com/7c100291e910c399ebd733edf3b23ba1483c6843/DEPS

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb

commit d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb
Author: Harald Alvestrand <hta@chromium.org>
Date: Mon Dec 10 10:00:02 2018

Create RTCDtlsTransport objects in the blink layer

This CL does on-demand creation of blink-layer transport
objects. It also introduces a way to get at the webrtc::PeerConnection
object from the WebPeerConnectionHandler API.

Bug: chromium:907849
Change-Id: Ic86a5a66289c31d1f939a47d58bc194c32471cbd
Reviewed-on: https://chromium-review.googlesource.com/c/1358060
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615072}
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/content/renderer/media/webrtc/mock_peer_connection_impl.h
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/content/renderer/media/webrtc/rtc_peer_connection_handler.cc
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/content/renderer/media/webrtc/rtc_peer_connection_handler.h
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/public/platform/web_rtc_peer_connection_handler.h
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/renderer/modules/peerconnection/rtc_dtls_transport.cc
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/renderer/modules/peerconnection/rtc_dtls_transport.h
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.h
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.cc
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.h
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.idl
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.cc
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.h
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.idl
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/renderer/modules/peerconnection/rtc_rtp_transceiver.cc
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/renderer/platform/testing/testing_platform_support_with_web_rtc.cc
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/renderer/platform/testing/testing_platform_support_with_web_rtc.h
[add] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/web_tests/external/wpt/webrtc/RTCRtpSender-transport.https-expected.txt
[add] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/web_tests/external/wpt/webrtc/RTCRtpSender-transport.https.html
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/web_tests/external/wpt/webrtc/idlharness.https.window-expected.txt
[add] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/web_tests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCRtpSender-transport.https-expected.txt
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/web_tests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
[modify] https://crrev.com/d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68c1d92a3636682a92cd7db078898fcdb4e2a191

commit 68c1d92a3636682a92cd7db078898fcdb4e2a191
Author: Samuel Huang <huangs@chromium.org>
Date: Mon Dec 10 15:00:01 2018

Revert "Create RTCDtlsTransport objects in the blink layer"

This reverts commit d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb.

Reason for revert: virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCRtpSender-transport.https.html fails in "WebKit Linux Trusty MSAN".

Original change's description:
> Create RTCDtlsTransport objects in the blink layer
> 
> This CL does on-demand creation of blink-layer transport
> objects. It also introduces a way to get at the webrtc::PeerConnection
> object from the WebPeerConnectionHandler API.
> 
> Bug: chromium:907849
> Change-Id: Ic86a5a66289c31d1f939a47d58bc194c32471cbd
> Reviewed-on: https://chromium-review.googlesource.com/c/1358060
> Commit-Queue: Harald Alvestrand <hta@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615072}

TBR=hta@chromium.org,haraken@chromium.org,hbos@chromium.org,guidou@chromium.org

Change-Id: Ie9c8d2e3dc5f97fc94ca5bf43cc30a9407d9fa4c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:907849
Reviewed-on: https://chromium-review.googlesource.com/c/1369719
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615115}
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/content/renderer/media/webrtc/mock_peer_connection_impl.h
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/content/renderer/media/webrtc/rtc_peer_connection_handler.cc
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/content/renderer/media/webrtc/rtc_peer_connection_handler.h
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/third_party/blink/public/platform/web_rtc_peer_connection_handler.h
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/third_party/blink/renderer/modules/peerconnection/rtc_dtls_transport.cc
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/third_party/blink/renderer/modules/peerconnection/rtc_dtls_transport.h
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.h
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.cc
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.h
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.idl
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.cc
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.h
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.idl
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/third_party/blink/renderer/modules/peerconnection/rtc_rtp_transceiver.cc
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/third_party/blink/renderer/platform/testing/testing_platform_support_with_web_rtc.cc
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/third_party/blink/renderer/platform/testing/testing_platform_support_with_web_rtc.h
[delete] https://crrev.com/0817cc924940c3ad27588db82f34dde7bac07007/third_party/blink/web_tests/external/wpt/webrtc/RTCRtpSender-transport.https-expected.txt
[delete] https://crrev.com/0817cc924940c3ad27588db82f34dde7bac07007/third_party/blink/web_tests/external/wpt/webrtc/RTCRtpSender-transport.https.html
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/third_party/blink/web_tests/external/wpt/webrtc/idlharness.https.window-expected.txt
[delete] https://crrev.com/0817cc924940c3ad27588db82f34dde7bac07007/third_party/blink/web_tests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCRtpSender-transport.https-expected.txt
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/third_party/blink/web_tests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
[modify] https://crrev.com/68c1d92a3636682a92cd7db078898fcdb4e2a191/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5916390277b33b2aa8803ffa0b9e34294bae03f

commit c5916390277b33b2aa8803ffa0b9e34294bae03f
Author: Harald Alvestrand <hta@chromium.org>
Date: Wed Dec 12 16:22:32 2018

Reland "Create RTCDtlsTransport objects in the blink layer"

This reverts commit 68c1d92a3636682a92cd7db078898fcdb4e2a191.

Reason for revert: Fixed an issue that fits the symptoms

Original change's description:
> Revert "Create RTCDtlsTransport objects in the blink layer"
>
> This reverts commit d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb.
>
> Reason for revert: virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCRtpSender-transport.https.html fails in "WebKit Linux Trusty MSAN".
>
> Original change's description:
> > Create RTCDtlsTransport objects in the blink layer
> >
> > This CL does on-demand creation of blink-layer transport
> > objects. It also introduces a way to get at the webrtc::PeerConnection
> > object from the WebPeerConnectionHandler API.
> >
> > Bug: chromium:907849
> > Change-Id: Ic86a5a66289c31d1f939a47d58bc194c32471cbd
> > Reviewed-on: https://chromium-review.googlesource.com/c/1358060
> > Commit-Queue: Harald Alvestrand <hta@chromium.org>
> > Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> > Reviewed-by: Henrik Boström <hbos@chromium.org>
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#615072}
>
> TBR=hta@chromium.org,haraken@chromium.org,hbos@chromium.org,guidou@chromium.org
>
> Change-Id: Ie9c8d2e3dc5f97fc94ca5bf43cc30a9407d9fa4c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:907849
> Reviewed-on: https://chromium-review.googlesource.com/c/1369719
> Reviewed-by: Samuel Huang <huangs@chromium.org>
> Commit-Queue: Samuel Huang <huangs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615115}

Change-Id: Ic0dcb6851d725eec31fb4203770cd21b88ce3e88
Bug: chromium:907849
Reviewed-on: https://chromium-review.googlesource.com/c/1371890
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Florent Castelli <orphis@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615915}
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/content/renderer/media/webrtc/mock_peer_connection_impl.h
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/content/renderer/media/webrtc/rtc_peer_connection_handler.cc
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/content/renderer/media/webrtc/rtc_peer_connection_handler.h
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/public/platform/web_rtc_peer_connection_handler.h
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/renderer/modules/peerconnection/rtc_dtls_transport.cc
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/renderer/modules/peerconnection/rtc_dtls_transport.h
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.h
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.cc
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.h
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/renderer/modules/peerconnection/rtc_rtp_receiver.idl
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.cc
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.h
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.idl
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/renderer/modules/peerconnection/rtc_rtp_transceiver.cc
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/renderer/platform/testing/testing_platform_support_with_web_rtc.cc
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/renderer/platform/testing/testing_platform_support_with_web_rtc.h
[add] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/web_tests/external/wpt/webrtc/RTCRtpSender-transport.https-expected.txt
[add] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/web_tests/external/wpt/webrtc/RTCRtpSender-transport.https.html
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/web_tests/external/wpt/webrtc/idlharness.https.window-expected.txt
[add] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/web_tests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCRtpSender-transport.https-expected.txt
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/web_tests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
[modify] https://crrev.com/c5916390277b33b2aa8803ffa0b9e34294bae03f/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/d02541e276f256834b7fcc7f04b1fe7c706b916a

commit d02541e276f256834b7fcc7f04b1fe7c706b916a
Author: Harald Alvestrand <hta@webrtc.org>
Date: Thu Jan 03 12:15:54 2019

Add an observer API for DTLSTransport events.

This wires up the "state change" event and defines an observer
class that can be used by clients.

Bug: chromium:907849
Change-Id: I3cba2dc051a56280fb958f139f29cbb0022a39c6
Reviewed-on: https://webrtc-review.googlesource.com/c/114884
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26120}
[modify] https://crrev.com/d02541e276f256834b7fcc7f04b1fe7c706b916a/api/dtlstransportinterface.h
[modify] https://crrev.com/d02541e276f256834b7fcc7f04b1fe7c706b916a/pc/BUILD.gn
[modify] https://crrev.com/d02541e276f256834b7fcc7f04b1fe7c706b916a/pc/dtlstransport.cc
[modify] https://crrev.com/d02541e276f256834b7fcc7f04b1fe7c706b916a/pc/dtlstransport.h
[add] https://crrev.com/d02541e276f256834b7fcc7f04b1fe7c706b916a/pc/dtlstransport_unittest.cc
[modify] https://crrev.com/d02541e276f256834b7fcc7f04b1fe7c706b916a/pc/jseptransport.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a75f00e5619166382ebb5ceeaf00fa3d198b968e

commit a75f00e5619166382ebb5ceeaf00fa3d198b968e
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Jan 03 20:25:50 2019

Roll src/third_party/webrtc c63ddb2a3f9a..3f2b9aad4a05 (8 commits)

https://webrtc.googlesource.com/src.git/+log/c63ddb2a3f9a..3f2b9aad4a05


git log c63ddb2a3f9a..3f2b9aad4a05 --date=short --no-merges --format='%ad %ae %s'
2019-01-03 srte@webrtc.org Moves logged event structs to separate header.
2019-01-03 yinwa@webrtc.org Bugfix: Activate pushback on every sent packet.
2019-01-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 86bff8b8d1..adf0af4da1 (619523:619625)
2019-01-03 hta@webrtc.org Add an observer API for DTLSTransport events.
2019-01-03 minyue@webrtc.org Use ordered data structure for supported frame lengths in ANA.
2019-01-03 nisse@webrtc.org Convert peerconnection_client to use VcmCapturer
2019-01-03 nisse@webrtc.org Update unityplugin to use VcmCapturer.
2019-01-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d189a9543f..86bff8b8d1 (619409:619523)


Created with:
  gclient setdep -r src/third_party/webrtc@3f2b9aad4a05

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:907849,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I9eb6c6869d7c551064e241d794ecd60715e660b0
Reviewed-on: https://chromium-review.googlesource.com/c/1394686
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#619738}
[modify] https://crrev.com/a75f00e5619166382ebb5ceeaf00fa3d198b968e/DEPS

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d24417f4e32b141684e05ace391a43698cda137

commit 4d24417f4e32b141684e05ace391a43698cda137
Author: Harald Alvestrand <hta@chromium.org>
Date: Tue Jan 08 17:11:54 2019

Wiring for webrtc DtlsTransport events and state

This is a somewhat simplified approach from the one used in
the ICE transport adapters.

Bug: chromium:907849
Change-Id: I799735b5a2e92602fc303ca813466d762b7933a1
Reviewed-on: https://chromium-review.googlesource.com/c/1392957
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620767}
[modify] https://crrev.com/4d24417f4e32b141684e05ace391a43698cda137/third_party/blink/renderer/modules/peerconnection/BUILD.gn
[add] https://crrev.com/4d24417f4e32b141684e05ace391a43698cda137/third_party/blink/renderer/modules/peerconnection/adapters/dtls_transport_proxy.cc
[add] https://crrev.com/4d24417f4e32b141684e05ace391a43698cda137/third_party/blink/renderer/modules/peerconnection/adapters/dtls_transport_proxy.h
[modify] https://crrev.com/4d24417f4e32b141684e05ace391a43698cda137/third_party/blink/renderer/modules/peerconnection/adapters/web_rtc_cross_thread_copier.h
[modify] https://crrev.com/4d24417f4e32b141684e05ace391a43698cda137/third_party/blink/renderer/modules/peerconnection/rtc_dtls_transport.cc
[modify] https://crrev.com/4d24417f4e32b141684e05ace391a43698cda137/third_party/blink/renderer/modules/peerconnection/rtc_dtls_transport.h
[modify] https://crrev.com/4d24417f4e32b141684e05ace391a43698cda137/third_party/blink/renderer/modules/peerconnection/rtc_dtls_transport.idl
[add] https://crrev.com/4d24417f4e32b141684e05ace391a43698cda137/third_party/blink/web_tests/external/wpt/webrtc/RTCDtlsTransport-state-expected.txt
[add] https://crrev.com/4d24417f4e32b141684e05ace391a43698cda137/third_party/blink/web_tests/external/wpt/webrtc/RTCDtlsTransport-state.html
[add] https://crrev.com/4d24417f4e32b141684e05ace391a43698cda137/third_party/blink/web_tests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCDtlsTransport-state-expected.txt

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/cdc3045973d6f8466cf4f281c303319711f6654b

commit cdc3045973d6f8466cf4f281c303319711f6654b
Author: Harald Alvestrand <hta@webrtc.org>
Date: Tue Jan 08 17:44:00 2019

Fire a state change event when clearing DtlsTransport

This will happen in normal operation when the PeerConnection is closed.
If it is already in the Closed state, do not fire an event.

Bug: chromium:907849
Change-Id: Icc7eaf487a287ed494d881b877a9b4e97b2a44b8
Reviewed-on: https://webrtc-review.googlesource.com/c/116485
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26167}
[modify] https://crrev.com/cdc3045973d6f8466cf4f281c303319711f6654b/pc/dtlstransport.cc
[modify] https://crrev.com/cdc3045973d6f8466cf4f281c303319711f6654b/pc/dtlstransport_unittest.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd46c3d46607a47fdd58bf58c5696f39908911ba

commit bd46c3d46607a47fdd58bf58c5696f39908911ba
Author: Harald Alvestrand <hta@chromium.org>
Date: Tue Jan 08 21:40:27 2019

DtlsTransport: Remove an observer when close is seen.

This was the result of discussion on CL 1392957, and was left off
that patch by mistake.

Bug: chromium:907849
Change-Id: Ic8a47855320b76a07aa1bf46c0f41e65ee8b68a0
Reviewed-on: https://chromium-review.googlesource.com/c/1400813
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620890}
[modify] https://crrev.com/bd46c3d46607a47fdd58bf58c5696f39908911ba/third_party/blink/renderer/modules/peerconnection/adapters/dtls_transport_proxy.cc
[modify] https://crrev.com/bd46c3d46607a47fdd58bf58c5696f39908911ba/third_party/blink/renderer/modules/peerconnection/adapters/dtls_transport_proxy.h

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82766c73a978515b0940f15892d8515f5974418e

commit 82766c73a978515b0940f15892d8515f5974418e
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Jan 09 12:34:55 2019

Roll src/third_party/webrtc 455d27c49abf..1ab9445be032 (13 commits)

https://webrtc.googlesource.com/src.git/+log/455d27c49abf..1ab9445be032


git log 455d27c49abf..1ab9445be032 --date=short --no-merges --format='%ad %ae %s'
2019-01-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision aa595e0ebb..63546ce7e8 (620951:621059)
2019-01-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8a0dac94cf..aa595e0ebb (620848:620951)
2019-01-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f4077a406f..8a0dac94cf (620741:620848)
2019-01-08 steveanton@webrtc.org Include absl/memory/memory.h if absl::make_unique is used
2019-01-08 hta@webrtc.org Fire a state change event when clearing DtlsTransport
2019-01-08 ossu@webrtc.org Disable FullStackTest/ScreenshareSlidesVP8_3TL_Simulcast on Windows
2019-01-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7ca76f7356..f4077a406f (620613:620741)
2019-01-08 nisse@webrtc.org Delete NetEqTest::ExtDecoderMap
2019-01-08 sprang@webrtc.org Account for packetization overhead when setting target bitrate.
2019-01-08 sprang@webrtc.org Add ability to set max probing bitrate in SendSideCongestionController.
2019-01-08 djcb@djcbsoftware.nl Add ',' between elements in RTCStatsReport::ToJson
2019-01-08 srte@webrtc.org Simplifies RtcEventProcessor interface.
2019-01-08 titovartem@google.com Extract NetworkNode abstraction.


Created with:
  gclient setdep -r src/third_party/webrtc@1ab9445be032

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:907849,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I4323dbe68d9e2a2583d0a9abcf7f3fab02663109
Reviewed-on: https://chromium-review.googlesource.com/c/1402217
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#621120}
[modify] https://crrev.com/82766c73a978515b0940f15892d8515f5974418e/DEPS

Blocking: 701330
Project Member

Comment 20 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0954b10823d294de4b8b85bc62bcbb9f6a5c0ac1

commit 0954b10823d294de4b8b85bc62bcbb9f6a5c0ac1
Author: Harald Alvestrand <hta@chromium.org>
Date: Tue Jan 15 12:43:11 2019

Add a default case to DtlsTransportState handling.

This is required in order to land
https://webrtc-review.googlesource.com/c/src/+/116984

Bug: chromium:907849
Change-Id: I86567e70cb99e8bf0b8aa4113350206451c82462
Reviewed-on: https://chromium-review.googlesource.com/c/1411918
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622830}
[modify] https://crrev.com/0954b10823d294de4b8b85bc62bcbb9f6a5c0ac1/third_party/blink/renderer/modules/peerconnection/rtc_dtls_transport.cc

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/4a7b3acfcfc08fcce0be54c545cd5622d648a879

commit 4a7b3acfcfc08fcce0be54c545cd5622d648a879
Author: Harald Alvestrand <hta@webrtc.org>
Date: Thu Jan 17 10:21:32 2019

Add DTLSTransport info into sender/receiver state.

This is in preparation for letting Chrome extract DTLSTransport
information after SLD/SRD instead of doing it on-demand.

Bug: chromium:907849
Change-Id: Iac6b174c98d3d14136e1fd25bce4a9292f6c8b41
Reviewed-on: https://webrtc-review.googlesource.com/c/116984
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26289}
[modify] https://crrev.com/4a7b3acfcfc08fcce0be54c545cd5622d648a879/api/dtls_transport_interface.h
[modify] https://crrev.com/4a7b3acfcfc08fcce0be54c545cd5622d648a879/api/rtp_receiver_interface.cc
[modify] https://crrev.com/4a7b3acfcfc08fcce0be54c545cd5622d648a879/api/rtp_receiver_interface.h
[modify] https://crrev.com/4a7b3acfcfc08fcce0be54c545cd5622d648a879/api/rtp_sender_interface.cc
[modify] https://crrev.com/4a7b3acfcfc08fcce0be54c545cd5622d648a879/api/rtp_sender_interface.h
[modify] https://crrev.com/4a7b3acfcfc08fcce0be54c545cd5622d648a879/logging/BUILD.gn
[modify] https://crrev.com/4a7b3acfcfc08fcce0be54c545cd5622d648a879/logging/rtc_event_log/events/rtc_event_dtls_transport_state.h
[modify] https://crrev.com/4a7b3acfcfc08fcce0be54c545cd5622d648a879/pc/jsep_transport.h
[modify] https://crrev.com/4a7b3acfcfc08fcce0be54c545cd5622d648a879/pc/jsep_transport_controller.cc
[modify] https://crrev.com/4a7b3acfcfc08fcce0be54c545cd5622d648a879/pc/jsep_transport_controller.h
[modify] https://crrev.com/4a7b3acfcfc08fcce0be54c545cd5622d648a879/pc/peer_connection.cc
[modify] https://crrev.com/4a7b3acfcfc08fcce0be54c545cd5622d648a879/pc/peer_connection.h
[modify] https://crrev.com/4a7b3acfcfc08fcce0be54c545cd5622d648a879/pc/peer_connection_signaling_unittest.cc
[modify] https://crrev.com/4a7b3acfcfc08fcce0be54c545cd5622d648a879/pc/rtp_receiver.h
[modify] https://crrev.com/4a7b3acfcfc08fcce0be54c545cd5622d648a879/pc/rtp_sender.h
[modify] https://crrev.com/4a7b3acfcfc08fcce0be54c545cd5622d648a879/pc/test/mock_rtp_receiver_internal.h
[modify] https://crrev.com/4a7b3acfcfc08fcce0be54c545cd5622d648a879/pc/test/mock_rtp_sender_internal.h

Project Member

Comment 22 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d444d1dd29f38737a04fc49006e071e4740b3be3

commit d444d1dd29f38737a04fc49006e071e4740b3be3
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Jan 17 16:54:05 2019

Roll src/third_party/webrtc ad8719442b26..83ed89a45f45 (5 commits)

https://webrtc.googlesource.com/src.git/+log/ad8719442b26..83ed89a45f45


git log ad8719442b26..83ed89a45f45 --date=short --no-merges --format='%ad %ae %s'
2019-01-17 aleloi@webrtc.org Opus multistream.
2019-01-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ac86e0cdbd..3a9216d2da (623074:623639)
2019-01-17 yvesg@webrtc.org Remove obsolete video_capture_module dependency.
2019-01-17 titovartem@webrtc.org Fix chromium roll
2019-01-17 hta@webrtc.org Add DTLSTransport info into sender/receiver state.


Created with:
  gclient setdep -r src/third_party/webrtc@83ed89a45f45

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:907849
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ief1c960de37308830513074c5aad05a14b893752
Reviewed-on: https://chromium-review.googlesource.com/c/1417286
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#623721}
[modify] https://crrev.com/d444d1dd29f38737a04fc49006e071e4740b3be3/DEPS

Project Member

Comment 23 by bugdroid1@chromium.org, Today (14 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20bc6832dfb435f24cb22fac27bf58841616d5ec

commit 20bc6832dfb435f24cb22fac27bf58841616d5ec
Author: Harald Alvestrand <hta@chromium.org>
Date: Tue Jan 22 17:35:46 2019

Use cricket::IceTransportInternal for accessing IceTransport

This minimizes linkage with the cricket::P2PTransportChannel
implementation class, and makes later restructuring easier.

Bug: chromium:907849
Change-Id: I8b94b3eaba2cdb2ae6299c4ab0c818a011624465
Reviewed-on: https://chromium-review.googlesource.com/c/1426778
Reviewed-by: Steve Anton <steveanton@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624816}
[modify] https://crrev.com/20bc6832dfb435f24cb22fac27bf58841616d5ec/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter_impl.cc
[modify] https://crrev.com/20bc6832dfb435f24cb22fac27bf58841616d5ec/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter_impl.h

Sign in to add a comment