New issue
Advanced search Search tips

Issue 907833 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

download bar buttons have mismatched focus ring path / ink drop bounds

Reported by sanyam.g...@etouch.net, Nov 22

Issue description

Chrome Version:72.0.3618.0 (Official Build) Revision	473cb3615ccd757dbfd816963e699299a0732b59-refs/branch-heads/3618@{#1}(64-bit)
OS: Mac(10.13.1 , 10.13.6 , 10.14.2)  

Steps to reproduce:
1. Launch chrome, Save the page by giving cmd+s and downloaded file is seen in download bar.
2. Press tab to bring focus to up arrow icon of the downloaded file.
3. Hover mouse on the up arrow icon (while the blue focus ring is present) and observe.

Actual Result   : Size of grey shadow (highlight) and the blue focus ring does not match. 
Expected Result : Size of grey shadow (highlight) and the blue focus ring should match.

This is a regression issue broken in M-70 and below is the bisect information:
Good Build : 70.0.3503.0 (Revision : 578160)
Bad Build : 70.0.3504.0 (Revision : 578510)

You are probably looking for a change made after 578333 (known good), but no later than 578334 (first known bad).

CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure

https://chromium.googlesource.com/chromium/src/+log/bcb7db78edc13f57577f0a9562c98918bdcc10ae..67d21d10815fe6d87d1785a65a50fbc386e6605b

Suspecting: https://chromium.googlesource.com/chromium/src/+/67d21d10815fe6d87d1785a65a50fbc386e6605b

@ellyjones:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.	

Note: Issue is not reproducible on Linux(14.04 LTS) and Windows(7,8,10) OS.

Kindly refer the attached screencast.

Thank You!
 
Actual_Focus.mov
2.6 MB View Download
Expected_Focus.mov
2.1 MB View Download
Labels: -Pri-1 -Target-70 -M-70 -Target-71 -Target-72 Target-73 M-73 Pri-3
Owner: pbos@chromium.org
Summary: download bar buttons have mismatched focus ring path / ink drop bounds (was: Regression: Size of grey shadow (highlight) and the blue focus ring does not match.)
mac triage: to pbos@
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2

commit 9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2
Author: Peter Boström <pbos@chromium.org>
Date: Wed Jan 02 23:27:40 2019

Unify ink-drop style to flood fill with masks.

This change makes flood fill the default ink-drop style. Square InkDrops
are currently bugs in the browser that are kind-of hidden by InkDrop
masks.

It makes use of the same path that FocusRing uses for masks to make sure
that the InkDrop and FocusRing are in sync by default. These mismatch
bugs keep popping up, especially on Mac, as testers verify new parts of
the UI.

Follow-up changes will be to reduce the number of classes that override
CreateInkDrop methods and make sure that they explicitly request a
SquareInkDrop when they want it.

Bug: chromium:888204,  chromium:907833 ,  chromium:915284 

Change-Id: I681b93d6f5bdfe7f78421ebc8f2fbd522fb6eee4
Reviewed-on: https://chromium-review.googlesource.com/c/1367186
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619533}
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/download/download_item_view.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/download/download_item_view.h
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/hover_button.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/toolbar/browser_app_menu_button.h
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/toolbar/toolbar_action_view.h
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/toolbar/toolbar_button.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/toolbar/toolbar_button.h
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/animation/ink_drop_host_view.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/animation/ink_drop_host_view.h
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/animation/ink_drop_impl.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/animation/ink_drop_impl.h
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/controls/button/button.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/controls/button/checkbox.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/controls/button/label_button.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/controls/button/label_button.h
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/controls/button/md_text_button.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/controls/button/md_text_button.h
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/controls/focus_ring.cc
[modify] https://crrev.com/9c8b10b5f102aac1db5ce7a2ac99a450381ee7c2/ui/views/controls/focus_ring.h

Labels: TE-Verified-M73 TE-Verified-73.0.3660.0
Hi,

Update:

Retested the above issue on  Mac(10.13.1, 10.13.6, 10.14.3) using latest Canary Build #73.0.3660.0 and issue is fixed.

Kindly refer the below attached screen cast.

Thank You!

Fixed_Behaviour.mov
1.8 MB View Download
Status: Verified (was: Assigned)
Thanks!

Sign in to add a comment