Issue metadata
Sign in to add a comment
|
FrameImplTest tests are flaky |
||||||||||||||||||||||
Issue descriptionFrameImplTest.NavigationObserverDisconnected is flaky. Findit has detected 3 flake occurrences of this test within the past 24 hours. List of all flake occurrences can be found at: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVwsSBUZsYWtlIkxjaHJvbWl1bUB3ZWJydW5uZXJfYnJvd3NlcnRlc3RzQEZyYW1lSW1wbFRlc3QuTmF2aWdhdGlvbk9ic2VydmVyRGlzY29ubmVjdGVkDA. Unless the culprit CL is found and reverted, please disable this test first within 30 minutes then find an appropriate owner. If the result above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%20for%20FrameImplTest.NavigationObserverDisconnected&comment=Link%20to%20flake%20occurrences%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVwsSBUZsYWtlIkxjaHJvbWl1bUB3ZWJydW5uZXJfYnJvd3NlcnRlc3RzQEZyYW1lSW1wbFRlc3QuTmF2aWdhdGlvbk9ic2VydmVyRGlzY29ubmVjdGVkDA Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Nov 23
,
Nov 23
Issue 907987 has been merged into this issue.
,
Nov 23
Issue 907934 has been merged into this issue.
,
Nov 23
Issue 907933 has been merged into this issue.
,
Nov 23
Issue 907921 has been merged into this issue.
,
Nov 23
Issue 907906 has been merged into this issue.
,
Nov 23
Issue 907927 has been merged into this issue.
,
Nov 23
Issue 907904 has been merged into this issue.
,
Nov 23
Issue 907903 has been merged into this issue.
,
Nov 23
Issue 907890 has been merged into this issue.
,
Nov 23
Issue 907859 has been merged into this issue.
,
Nov 23
,
Nov 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/912050e157c4fd552a19a44d87cbd67e42d38411 commit 912050e157c4fd552a19a44d87cbd67e42d38411 Author: Rune Lillesveen <futhark@chromium.org> Date: Fri Nov 23 12:31:22 2018 Disable all tests in FrameImplTest. Almost all have been reported as flaky. Disable all to avoid having reports coming in from whichever subtest was not reported yet. Caused a lot of red jobs on the Fuchsia x64 bot. TBR=wez@chromium.org Bug: 907804 Change-Id: I2fb4da79bf1e4251e14900ef4cabb890b7b3380d Reviewed-on: https://chromium-review.googlesource.com/c/1349315 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#610580} [modify] https://crrev.com/912050e157c4fd552a19a44d87cbd67e42d38411/webrunner/browser/frame_impl_browsertest.cc
,
Nov 23
,
Nov 23
FrameImplTest.ExecuteOnLoadEarlyAndLateRegistrations is flaky. Findit has detected 4 new flake occurrences of this test. List of all flake occurrences can be found at: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyXwsSBUZsYWtlIlRjaHJvbWl1bUB3ZWJydW5uZXJfYnJvd3NlcnRlc3RzQEZyYW1lSW1wbFRlc3QuRXhlY3V0ZU9uTG9hZEVhcmx5QW5kTGF0ZVJlZ2lzdHJhdGlvbnMM. Since this test is still flaky, this issue has been moved back onto the Sheriff Bug Queue if it's not already there. This flaky test was previously tracked in bug 907890 . If the result above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%20for%20FrameImplTest.ExecuteOnLoadEarlyAndLateRegistrations&comment=Link%20to%20flake%20occurrences%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyXwsSBUZsYWtlIlRjaHJvbWl1bUB3ZWJydW5uZXJfYnJvd3NlcnRlc3RzQEZyYW1lSW1wbFRlc3QuRXhlY3V0ZU9uTG9hZEVhcmx5QW5kTGF0ZVJlZ2lzdHJhdGlvbnMM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Nov 23
FindIt report only for runs before the DISABLEs landed.
,
Nov 23
FrameImplTest.GetVisibleEntry is flaky. Findit has detected 5 new flake occurrences of this test. List of all flake occurrences can be found at: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVySAsSBUZsYWtlIj1jaHJvbWl1bUB3ZWJydW5uZXJfYnJvd3NlcnRlc3RzQEZyYW1lSW1wbFRlc3QuR2V0VmlzaWJsZUVudHJ5DA. Since this test is still flaky, this issue has been moved back onto the Sheriff Bug Queue if it's not already there. This flaky test was previously tracked in bug 907904 . If the result above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%20for%20FrameImplTest.GetVisibleEntry&comment=Link%20to%20flake%20occurrences%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVySAsSBUZsYWtlIj1jaHJvbWl1bUB3ZWJydW5uZXJfYnJvd3NlcnRlc3RzQEZyYW1lSW1wbFRlc3QuR2V0VmlzaWJsZUVudHJ5DA Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Nov 23
FrameImplTest.NoNavigationObserverAttached is flaky. Findit has detected 4 new flake occurrences of this test. List of all flake occurrences can be found at: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVQsSBUZsYWtlIkpjaHJvbWl1bUB3ZWJydW5uZXJfYnJvd3NlcnRlc3RzQEZyYW1lSW1wbFRlc3QuTm9OYXZpZ2F0aW9uT2JzZXJ2ZXJBdHRhY2hlZAw. Since this test is still flaky, this issue has been moved back onto the Sheriff Bug Queue if it's not already there. This flaky test was previously tracked in bug 907906 . If the result above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%20for%20FrameImplTest.NoNavigationObserverAttached&comment=Link%20to%20flake%20occurrences%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVQsSBUZsYWtlIkpjaHJvbWl1bUB3ZWJydW5uZXJfYnJvd3NlcnRlc3RzQEZyYW1lSW1wbFRlc3QuTm9OYXZpZ2F0aW9uT2JzZXJ2ZXJBdHRhY2hlZAw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Nov 23
See #17
,
Nov 24
FrameImplTest.ExecuteJavascriptOnLoadWrongOrigin is flaky. Findit has detected 3 new flake occurrences of this test. List of all flake occurrences can be found at: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyWwsSBUZsYWtlIlBjaHJvbWl1bUB3ZWJydW5uZXJfYnJvd3NlcnRlc3RzQEZyYW1lSW1wbFRlc3QuRXhlY3V0ZUphdmFzY3JpcHRPbkxvYWRXcm9uZ09yaWdpbgw. Since this test is still flaky, this issue has been moved back onto the Sheriff Bug Queue if it's not already there. This flaky test was previously tracked in bug 907987 . If the result above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%20for%20FrameImplTest.ExecuteJavascriptOnLoadWrongOrigin&comment=Link%20to%20flake%20occurrences%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyWwsSBUZsYWtlIlBjaHJvbWl1bUB3ZWJydW5uZXJfYnJvd3NlcnRlc3RzQEZyYW1lSW1wbFRlc3QuRXhlY3V0ZUphdmFzY3JpcHRPbkxvYWRXcm9uZ09yaWdpbgw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Nov 26
Test was disabled.
,
Nov 26
Looks like the tests are failing an SQL database CHECK for some reason; perhaps not waiting for preceding test to have finished w/ the SQL storage back-end, for example? Flake finder reports oldest flake on Nov 21st, which coincides with the SDK roll that appears to have broken the test-summary fetch as per issue 908125 . Issue 908125 may therefore be a filesystem issue, rather than a netstack one?
,
Nov 26
FWIW after https://chromium-review.googlesource.com/c/chromium/src/+/1341073 the FrameImplTest.ExecuteJavaScriptOnLoadWildcardOrigin test was failing pretty reliably, I didn't realize it was flaky at the time.
,
Nov 26
Bunch of (very confused) analysis here: https://chromium-review.googlesource.com/c/chromium/src/+/1341073/11#message-fca2f3c445e7e6233a9f3b115324fcf1c76b0ae2 https://chromium-review.googlesource.com/c/chromium/src/+/1341073/11#message-349b3e6b62a4d69a5187ec4278ea7b1abfc90578 Which may help debug/understand the flakiness
,
Nov 26
Re #25: Looks like the FrameImplTest flakes started on Nov 21st, which is _after_ https://chromium-review.googlesource.com/c/chromium/src/+/1341073 was failing for you?
,
Nov 27
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8c78a28251a4fa7fef218d47b83cfad39dca314 commit d8c78a28251a4fa7fef218d47b83cfad39dca314 Author: Wez <wez@chromium.org> Date: Tue Nov 27 18:37:40 2018 Revert "Disable all tests in FrameImplTest." This reverts commit 912050e157c4fd552a19a44d87cbd67e42d38411. Reason for revert: Fuchsia SDK believed to be the cause of these failures; speculatively reverting to re-enable the tests to evaluate. Original change's description: > Disable all tests in FrameImplTest. > > Almost all have been reported as flaky. Disable all to avoid having > reports coming in from whichever subtest was not reported yet. Caused a > lot of red jobs on the Fuchsia x64 bot. > > TBR=wez@chromium.org > > Bug: 907804 > Change-Id: I2fb4da79bf1e4251e14900ef4cabb890b7b3380d > Reviewed-on: https://chromium-review.googlesource.com/c/1349315 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610580} TBR=wez@chromium.org,futhark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 907804 , 907859 , 907717 Change-Id: I72103faff6457a93136925afdab9d7f003061369 Reviewed-on: https://chromium-review.googlesource.com/c/1351100 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#611212} [modify] https://crrev.com/d8c78a28251a4fa7fef218d47b83cfad39dca314/webrunner/browser/frame_impl_browsertest.cc [modify] https://crrev.com/d8c78a28251a4fa7fef218d47b83cfad39dca314/webrunner/renderer/on_load_script_injector.h
,
Dec 4
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Nov 22Labels: OS-Fuchsia