New issue
Advanced search Search tips

Issue 907793 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 894819



Sign in to add a comment

ExtensionLocalizationPeer should work with data pipe

Project Member Reported by yhirano@chromium.org, Nov 22

Issue description

Cc: yhirano@chromium.org
Owner: shimazu@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f3d5d7804858d658708344a74978e34f798e8af

commit 5f3d5d7804858d658708344a74978e34f798e8af
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Thu Dec 13 22:37:32 2018

Implement ExtensionLocalizationPeer with data pipe

Previously ExtensionLocalizationPeer::OnStartLoadingResponseBody() passed the
pipe through the |original_peer_|. As we are moving body transfer from
RequestPeer::OnReceivedData to OnStartLoadingResponseBody, this CL implements
OnStartloadingResponseBody() and the following logic.

Bug:  907793 
Change-Id: If85d788084ca089fd34ba9b17b016240ecd29214
Reviewed-on: https://chromium-review.googlesource.com/c/1358311
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616461}
[modify] https://crrev.com/5f3d5d7804858d658708344a74978e34f798e8af/chrome/renderer/extensions/extension_localization_peer.cc
[modify] https://crrev.com/5f3d5d7804858d658708344a74978e34f798e8af/chrome/renderer/extensions/extension_localization_peer.h
[modify] https://crrev.com/5f3d5d7804858d658708344a74978e34f798e8af/chrome/renderer/extensions/extension_localization_peer_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment