New issue
Advanced search Search tips

Issue 907791 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Nov 30
Cc:
xiaoche...@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
editing-dev@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Red underline is seen for search text in search textbox on chrome://flags/.

Reported by pranjali...@etouch.net, Nov 22 
Chrome Version:72.0.3618.0 (Official Build) 473cb3615ccd757dbfd816963e699299a0732b59-refs/branch-heads/3618@{#1}(32/64 bit)

OS:  Win(7,8,8.1,10) and Linux(14.04 LTS)

What steps will reproduce the problem?
1.Launch chrome and navigate to 'chrome://flags/'.
2.Now enter some relevant text in search textbox and observe.

Actual  : Red underline is seen for search text in search textbox on chrome://flags/.
Expected: Red underline should not be seen for search text in search textbox on chrome://flags/.

This is a regression issue broken in ‘M-68’ and below is bisect info.
Good build: 68.0.3401.0 
Bad build: 68.0.3402.0 

You are probably looking for a change made after 552269 (known good), but no later than 552270 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/527433a7047fd56a0db0189a80a422087a1ab951..8712023f7d10238966ed56d02d27f10e02c8c394

Suspect: https://chromium.googlesource.com/chromium/src/+/8712023f7d10238966ed56d02d27f10e02c8c394

@xiaochengh: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note: Issue is not seen on Mac(10.13.1 , 10.13.6 , 10.14.2)

Thank You...
Expected Result.mp4
672 KB View Download
Actual Result.mp4
463 KB View Download

Comment 1 by dtapu...@chromium.org, Nov 22

Components: -Blink Blink>Editing>Spellcheck UI>Settings
Seems like perhaps spellcheck needs to be disabled on the chrome://flags search box?

Comment 2 by xiaoche...@chromium.org, Nov 26

Owner: dpa...@chromium.org
Exactly. Assigned to UI>Settings for disabling spellcheck.

Comment 3 by dpa...@chromium.org, Nov 27

Components: -UI>Settings UI>Browser>WebUI
Owner: asvitk...@chromium.org

Comment 4 by asvitk...@chromium.org, Nov 29

Owner: xiaoche...@chromium.org
Status: Available (was: Assigned)
Assigning to author of suspected CL.

Comment 5 by asvitk...@chromium.org, Nov 29 

To clarify: If your CL caused a regression, you're responsible for the fix.

Comment 6 by dpa...@chromium.org, Nov 30 

> Exactly. Assigned to UI>Settings for disabling spellcheck.

UI>Settings corresponds to chrome://settings WebUI page. The bug reported here refers to chrome://flags. Either way, the fix is probably adding spellcheck="false" to the <input> element that should not be checked. See examples at [1]

[1] https://cs.chromium.org/search/?q=spellcheck%3D%22false%22+file:%5Esrc/chrome/browser/resources/settings/+package:%5Echromium$&type=cs

Comment 7 by xiaoche...@chromium.org, Nov 30 

asvitkine: it's not my patch causing a regression, but rather, the WebUI code made a wrong assumption and was revealed.

dpapad:

I never touched WebUI code before...

Could you assign to someone familiar with it, or point out the code location so that I can change it?

Thanks!

Comment 8 by dpa...@chromium.org, Nov 30 

CL at https://chromium-review.googlesource.com/c/chromium/src/+/1357018.
spellcheck_before.png
13.0 KB View Download
spellcheck_after.png
10.3 KB View Download

Comment 9 by dpa...@chromium.org, Nov 30

Cc: xiaoche...@chromium.org
Owner: dpa...@chromium.org
Status: Started (was: Available)
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba76b5bac231ec145aabb2a036ffb28ebb6d69a4

commit ba76b5bac231ec145aabb2a036ffb28ebb6d69a4
Author: dpapad <dpapad@chromium.org>
Date: Fri Nov 30 20:25:01 2018

Don't spellcheck chrome://flags search box.

Bug:  907791 
Change-Id: I18f62b564509ac97d54aa6fec33d213ebf16e575
Reviewed-on: https://chromium-review.googlesource.com/c/1357018
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612757}
[modify] https://crrev.com/ba76b5bac231ec145aabb2a036ffb28ebb6d69a4/components/flags_ui/resources/flags.html

Comment 11 by dpa...@chromium.org, Nov 30

Status: Fixed (was: Started)
►

Sign in to add a comment