Issue metadata
Sign in to add a comment
|
Regression:[NTP]Unable to view the Chrome background photo link when NTP requires scrolling
Reported by
vineetha...@etouch.net,
Nov 22
|
||||||||||||||||||||
Issue descriptionChrome Version: 72.0.3618.0 (Official Build) Revision 473cb3615ccd757dbfd816963e699299a0732b59-refs/branch-heads/3618@{#1}(32/64-Bit) OS: Mac (10.13.1, 10.13.6, 10.14.2) Steps to reproduce: 1.Launch chrome and navigate to chrome://restart and relaunch browser to invoke remote NTP. 2.Ensure that browser window is in full screen mode. 3.Navigate to NTP and apply any background wallpaper to NTP by clicking on gear icon > 'Chrome backgrounds'. 4.Observe that photo link related to chrome background (' Photo by....') is visible on lower LHS of NTP. 5.Now ensure that browser window is not in full screen mode(by clicking on green icon of traffic signal). 6.Observe the photo link now. Actual Result : Unable to view the Chrome background photo link when browser is not in full screen mode. Expected Result: Should be able to view the Chrome background photo link even when browser is not in full screen mode. This is a regression issue, broken in 'M-70', and below is the bisect info: Good Build:70.0.3537.0 (Revision: 587303) Bad Build :70.0.3538.0 (Revision: 587811) Change-Log URL: https://chromium.googlesource.com/chromium/src/+log/70.0.3537.0..70.0.3538.0?pretty=fuller&n=10000 Suspecting:r587382? @sweilun: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. Issue is reproducible only on remote NTP 2. Providing suspect through 'Change-Log' because unable to perform bisect using 'per-revision' and 'chromium bisect' script. 3. Tried performing 'per revision' bisect on multiple Mac machines but unable to perform the same since getting following error:[Errno 2] No such file or directory error message 4. Unable to perform 'chromium bisect' script as issue is not reproducible on chromium builds. 5. In some Mac machines(based on screen size), issue is reproducible only when remote NTP is resized and made smaller. 6. Issue is specific to Mac OS. Thank You!
,
Nov 26
@Ramya, this is from cl/210459063 (hide the attribution if the window is 666px or less, not present in local NTP). Should this be intended behavior?
,
Nov 26
Oh, interesting. There is no second row of icons, but the promo & attribution are hidden here anyway, because sizing & decision to hide is based on there being two rows. This is WAI when both rows of icons are visible (eg pixelbook at 100% zoom has no scroll or overlap of attribution over the icons). I think this is also acceptable when there isn't a second row of icons (+Yana to confirm), and (correct me if I'm wrong), but it'd be complex to figure out when that second row is missing & auto-hide based on that?
,
Nov 26
Yes, it'll be somewhat complex since we'll need to account for zoom/window resizing.
,
Nov 26
It seems like there is enough space to display the attribution and promo even if we had two rows of icons here, no?
,
Nov 26
@yyushkina: I think that's probably not the case because the scrollbar is visible, but we can try to replicate with the exact screen dimensions to confirm. @vineetha.sarma: can you provide your screen dimensions when you're able to repro this?
,
Nov 26
,
Nov 27
Update w.r.t comment #6: Able to reproduce the above issue on, 1.Mac 10.13.6 OS and screen dimension is 13.3 inch(1280 X 800) and 2.Mac 10.13.6 OS with screen dimension 15.4 inch(2880 X 1800) but only after resizing the browser window. Thank you
,
Nov 27
,
Nov 29
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ramyan@chromium.org
, Nov 23Labels: -Pri-1 -Target-70 -Target-71 AddToRemoteNTP KR-NTP-MD2-Polish O-Polish-Birthday-Features Pri-3
Owner: kristip...@chromium.org
Summary: Regression:[NTP]Unable to view the Chrome background photo link when NTP requires scrolling (was: Regression:[NTP]Unable to view the Chrome background photo link when browser is not in full screen mode)