New issue
Advanced search Search tips

Issue 907786 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 827072



Sign in to add a comment

[iOS][Unity] Needs to remove consent bump UI.

Project Member Reported by jlebel@chromium.org, Nov 22

Issue description

Unity consent is not relevant anymore. The UI should be removed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43b712539b62fff8b6706ddf36b9fc6e65e7e70f

commit 43b712539b62fff8b6706ddf36b9fc6e65e7e70f
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Mon Nov 26 18:29:53 2018

[iOS] Removing unified consent bump UI

Unified consent bump is not relevant anymore. Removing UI, images, and strings.
The Chrome flags will be removed by tangltom, when all the UI from other
platform will be removed.

Bug:  907786 
Change-Id: I6cbc5b9ffcee3f10cbb1613c8578e6f4fc7c3e93
Reviewed-on: https://chromium-review.googlesource.com/c/1343100
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610894}
[modify] https://crrev.com/43b712539b62fff8b6706ddf36b9fc6e65e7e70f/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/43b712539b62fff8b6706ddf36b9fc6e65e7e70f/ios/chrome/app/strings/ios_chromium_strings.grd
[modify] https://crrev.com/43b712539b62fff8b6706ddf36b9fc6e65e7e70f/ios/chrome/app/strings/ios_google_chrome_strings.grd
[modify] https://crrev.com/43b712539b62fff8b6706ddf36b9fc6e65e7e70f/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/43b712539b62fff8b6706ddf36b9fc6e65e7e70f/ios/chrome/browser/ui/authentication/BUILD.gn
[modify] https://crrev.com/43b712539b62fff8b6706ddf36b9fc6e65e7e70f/ios/chrome/browser/ui/authentication/authentication_constants.h
[modify] https://crrev.com/43b712539b62fff8b6706ddf36b9fc6e65e7e70f/ios/chrome/browser/ui/authentication/authentication_constants.mm
[modify] https://crrev.com/43b712539b62fff8b6706ddf36b9fc6e65e7e70f/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/consent_bump/BUILD.gn
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_consumer.h
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_coordinator.h
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_coordinator.mm
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_coordinator_delegate.h
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_mediator.h
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_mediator.mm
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_option_button.h
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_option_button.mm
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_option_type.h
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_personalization_coordinator.h
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_personalization_coordinator.mm
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_personalization_view_controller.h
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_personalization_view_controller.mm
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_view_controller.h
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_view_controller.mm
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/consent_bump/consent_bump_view_controller_delegate.h
[modify] https://crrev.com/43b712539b62fff8b6706ddf36b9fc6e65e7e70f/ios/chrome/browser/ui/authentication/resources/BUILD.gn
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/resources/authentication_checkmark.imageset/Contents.json
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/resources/authentication_checkmark.imageset/authentication_checkmark.png
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/resources/authentication_checkmark.imageset/authentication_checkmark@2x.png
[delete] https://crrev.com/13eec5538f21ae8ba71ee72185e6bfd6e7f393cf/ios/chrome/browser/ui/authentication/resources/authentication_checkmark.imageset/authentication_checkmark@3x.png
[modify] https://crrev.com/43b712539b62fff8b6706ddf36b9fc6e65e7e70f/ios/chrome/browser/ui/authentication/unified_consent/BUILD.gn
[modify] https://crrev.com/43b712539b62fff8b6706ddf36b9fc6e65e7e70f/ios/chrome/browser/ui/authentication/unified_consent/identity_picker_view.h
[modify] https://crrev.com/43b712539b62fff8b6706ddf36b9fc6e65e7e70f/ios/chrome/browser/ui/authentication/unified_consent/identity_picker_view.mm
[modify] https://crrev.com/43b712539b62fff8b6706ddf36b9fc6e65e7e70f/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_coordinator.h
[modify] https://crrev.com/43b712539b62fff8b6706ddf36b9fc6e65e7e70f/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_coordinator.mm
[modify] https://crrev.com/43b712539b62fff8b6706ddf36b9fc6e65e7e70f/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.h
[modify] https://crrev.com/43b712539b62fff8b6706ddf36b9fc6e65e7e70f/ios/chrome/browser/ui/authentication/unified_consent/unified_consent_view_controller.mm
[modify] https://crrev.com/43b712539b62fff8b6706ddf36b9fc6e65e7e70f/ios/chrome/browser/ui/commands/browser_coordinator_commands.h
[modify] https://crrev.com/43b712539b62fff8b6706ddf36b9fc6e65e7e70f/ios/chrome/browser/ui/main/BUILD.gn
[modify] https://crrev.com/43b712539b62fff8b6706ddf36b9fc6e65e7e70f/ios/chrome/browser/ui/main/browser_coordinator.mm

Status: Fixed (was: Started)

Sign in to add a comment