Extension API Modification Proposal API Namespace: chrome.idle API Owners: ljusten@chromium.org The following documents may not be necessary depending on the scope of your proposal: API Overview Doc: https://docs.google.com/document/d/1g9cJ4AeuEisqxbuwglVq6b1nM0uIkhXYunJbalmNYDg/edit?usp=sharing Design Doc: https://docs.google.com/document/d/1D8iXdpTaIWhwPaaBJI2TRzNBOVU3evz7rYIqd5gZFkg Supplementary Resources: Secure Connect Chrome OS PRD https://docs.google.com/document/d/1OU4-f1kq4ZZW60Wc9AZtUOpZfpGdz1T7qFlR1Dg9lGk Secure Connect Chrome OS DD https://docs.google.com/document/d/1LZD6yE6NENBRZ41O8FM9yETq0eq-DkqIOUsnKSY51W4/edit?pli=1#heading=h.9xapoavu8ivm
Sounds reasonable to me. +meacer for security, +dcheng@ FYI (as owner of chrome.idle).
Security LGTM.
There's no UI required for this feature.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/061f5ba1cbf224dacf9f5a8b06fa29c173c3646c commit 061f5ba1cbf224dacf9f5a8b06fa29c173c3646c Author: Andreea Costinas <acostinas@google.com> Date: Mon Jan 14 09:14:39 2019 Get autolock delay from policy This commit gets the autolock delay time for ChromeOS from policies and send the information to chrome.idle.getAutoLockDelay. BUG= chromium:907751 Change-Id: I33006f6498621c7d46a49ee67814f5266408838a Reviewed-on: https://chromium-review.googlesource.com/c/1382443 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#622399} [add] https://crrev.com/061f5ba1cbf224dacf9f5a8b06fa29c173c3646c/chrome/browser/extensions/api/idle/idle_get_auto_lock_delay_apitest.cc [modify] https://crrev.com/061f5ba1cbf224dacf9f5a8b06fa29c173c3646c/chrome/test/BUILD.gn [add] https://crrev.com/061f5ba1cbf224dacf9f5a8b06fa29c173c3646c/chrome/test/data/extensions/api_test/idle/get_auto_lock_delay/manifest.json [add] https://crrev.com/061f5ba1cbf224dacf9f5a8b06fa29c173c3646c/chrome/test/data/extensions/api_test/idle/get_auto_lock_delay/test.js [add] https://crrev.com/061f5ba1cbf224dacf9f5a8b06fa29c173c3646c/chrome/test/data/extensions/api_test/idle/unsupported_get_auto_lock_delay/manifest.json [add] https://crrev.com/061f5ba1cbf224dacf9f5a8b06fa29c173c3646c/chrome/test/data/extensions/api_test/idle/unsupported_get_auto_lock_delay/test.js [modify] https://crrev.com/061f5ba1cbf224dacf9f5a8b06fa29c173c3646c/chrome/test/data/extensions/api_test/stubs_app/background.js [modify] https://crrev.com/061f5ba1cbf224dacf9f5a8b06fa29c173c3646c/chromeos/dbus/power_policy_controller.cc [modify] https://crrev.com/061f5ba1cbf224dacf9f5a8b06fa29c173c3646c/chromeos/dbus/power_policy_controller.h [modify] https://crrev.com/061f5ba1cbf224dacf9f5a8b06fa29c173c3646c/chromeos/dbus/power_policy_controller_unittest.cc [modify] https://crrev.com/061f5ba1cbf224dacf9f5a8b06fa29c173c3646c/extensions/browser/api/idle/idle_api.cc [modify] https://crrev.com/061f5ba1cbf224dacf9f5a8b06fa29c173c3646c/extensions/browser/api/idle/idle_api.h [modify] https://crrev.com/061f5ba1cbf224dacf9f5a8b06fa29c173c3646c/extensions/browser/api/idle/idle_manager.cc [modify] https://crrev.com/061f5ba1cbf224dacf9f5a8b06fa29c173c3646c/extensions/browser/api/idle/idle_manager.h [modify] https://crrev.com/061f5ba1cbf224dacf9f5a8b06fa29c173c3646c/extensions/browser/extension_function_histogram_value.h [modify] https://crrev.com/061f5ba1cbf224dacf9f5a8b06fa29c173c3646c/extensions/common/api/_api_features.json [modify] https://crrev.com/061f5ba1cbf224dacf9f5a8b06fa29c173c3646c/extensions/common/api/idle.json [modify] https://crrev.com/061f5ba1cbf224dacf9f5a8b06fa29c173c3646c/tools/metrics/histograms/enums.xml
Comment 1 by ljusten@google.com
, Nov 22