Regression: [Print Preview] Unnecessary print preview page gets scrolled.
Reported by
dchau...@etouch.net,
Nov 22
|
|
Issue descriptionChrome Version: 72.0.3617.0 (Official Build) Revision 4b5e988589e5f4f1db23c9441c7739ca6f1bd72b-refs/branch-heads/3617@{#1} (32/64-bit) OS: Windows(7,8,8.1,10), Mac (10.13.1, 10.13.6, 10.14.2) and Linux (14.04 LTS). What steps will reproduce the problem? 1. Launch Chrome and give print command on any webpage. 2. Zoom-in the page so that vertical scroll-bar appears on print preview page. 3. Keep focus on 'All' radio button under 'Pages' section using 'Tab' key. 4. Now press down arrow key from keyboard to reach the focus on second radio button and observe the print preview page. Actual: Unnecessary print preview page gets scrolled down on pressing down arrow key. Expected: Print preview page should not scroll down on pressing down arrow key. This is a regression issue, broken in M-71 series, below is manual regression range: Good build: 71.0.3575.0 (Revision: 597883) Bad build: 71.0.3576.0 (Revision: 598282) You are probably looking for a change made after 598191 (known good), but no later than 598192 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/5874ee01d629645dac59da7d7f91be7c0e36fbca..33d2f351e23d3db6fbbee5d0835aeaffd997e910 Suspecting: https://chromium.googlesource.com/chromium/src/+/33d2f351e23d3db6fbbee5d0835aeaffd997e910 @rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: This issue is also reproducible on Beta # 71.0.3578.62 & Dev #72.0.3610.2 Kindly review the attached screen-cast for reference. Thank you.
,
Nov 28
With response to comment #1: Checked the behavior of migration to cr-radio-group buttons on chrome://settings page and print preview page both and found the result below. behavior of cr-radio-group buttons on chrome://settings page: if we move the focus around radio buttons via up/down arrow key from keyboard then vertical scroll-bar of chrome://settings page doesn't scroll. behavior of cr-radio-group buttons on print preview page: if we move the focus around radio buttons via up/down arrow key from keyboard then vertical scroll-bar of print preview (content area of the page) page gets scrolled. @rbpotter: could you please have a look into this issue again. Attaching screen-cast for the same. Thank you..!
,
Nov 28
Like any page, the settings page will not scroll if there is no content to scroll to. I tested this in Canary on Windows 10 and observed that if you set the browser window size such that there is content above and below the "On startup" radio buttons, the page scrolls up if the up arrow is pressed again with focus on the top radio button, and down if the down arrow is pressed again when focus is on the bottom radio button. Similarly in Print Preview if the sidebar is scrollable, it will scroll down if focus is on the bottom radio button and the down arrow is pressed again, or up if there is content above the pages section and the top radio button is focused and the up arrow is pressed again. Print Preview also always passes up/down arrow keys to the plugin if they are not handled by the current element. This is not a bug.
,
Dec 21
|
|
►
Sign in to add a comment |
|
Comment 1 by rbpotter@chromium.org
, Nov 28