New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 907681 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 26
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

clang-format is not set up for imageloader

Project Member Reported by chowes@google.com, Nov 21

Issue description

clang-format does not run for imageloader changes. Should be added to PRESUBMIT.cfg
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ad6271a6fcd236296c248fcc6ff378170fbcdd34

commit ad6271a6fcd236296c248fcc6ff378170fbcdd34
Author: Colin Howes <chowes@google.com>
Date: Fri Nov 23 03:08:02 2018

PRESUBMIT: Enable clang_format_check for imageloader.

This change enables clang_format_check for imageloader. Also let clang
format fix style errors to keep from polluting future CLs.

BUG= chromium:907681 
TEST=Try to submit a change with bad style.

Change-Id: If5719263e30610e913dc66fa53a1e7023e3be965
Reviewed-on: https://chromium-review.googlesource.com/1347147
Commit-Ready: Colin Howes <chowes@google.com>
Tested-by: Colin Howes <chowes@google.com>
Reviewed-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/ad6271a6fcd236296c248fcc6ff378170fbcdd34/imageloader/helper_process_proxy.cc
[modify] https://crrev.com/ad6271a6fcd236296c248fcc6ff378170fbcdd34/imageloader/imageloader_main.cc
[modify] https://crrev.com/ad6271a6fcd236296c248fcc6ff378170fbcdd34/imageloader/imageloader_impl.cc
[modify] https://crrev.com/ad6271a6fcd236296c248fcc6ff378170fbcdd34/imageloader/imageloader_impl.h
[modify] https://crrev.com/ad6271a6fcd236296c248fcc6ff378170fbcdd34/imageloader/component_test.cc
[modify] https://crrev.com/ad6271a6fcd236296c248fcc6ff378170fbcdd34/imageloader/imageloader_test.cc
[modify] https://crrev.com/ad6271a6fcd236296c248fcc6ff378170fbcdd34/imageloader/verity_mounter_test.cc
[modify] https://crrev.com/ad6271a6fcd236296c248fcc6ff378170fbcdd34/imageloader/verity_mounter_impl.cc
[modify] https://crrev.com/ad6271a6fcd236296c248fcc6ff378170fbcdd34/PRESUBMIT.cfg
[modify] https://crrev.com/ad6271a6fcd236296c248fcc6ff378170fbcdd34/imageloader/imageloader.h
[modify] https://crrev.com/ad6271a6fcd236296c248fcc6ff378170fbcdd34/imageloader/component.h
[modify] https://crrev.com/ad6271a6fcd236296c248fcc6ff378170fbcdd34/imageloader/verity_mounter.cc
[modify] https://crrev.com/ad6271a6fcd236296c248fcc6ff378170fbcdd34/imageloader/verity_mounter.h
[modify] https://crrev.com/ad6271a6fcd236296c248fcc6ff378170fbcdd34/imageloader/mock_helper_process_proxy.h
[modify] https://crrev.com/ad6271a6fcd236296c248fcc6ff378170fbcdd34/imageloader/imageloader.cc
[modify] https://crrev.com/ad6271a6fcd236296c248fcc6ff378170fbcdd34/imageloader/mock_verity_mounter.h

Status: Fixed (was: Assigned)

Sign in to add a comment