Issue 907336  has been merged into this issue.

The log here indicates that inotify_add_watch() failed, which would explain why the test subsequently times out (https://bugs.chromium.org/p/chromium/issues/detail?id=794372#c9).

However the current flakes don't include that log message.

ProxyConfigServiceLinuxTest.KDEFileChanged is flaky.

Findit has detected 28 new flake occurrences of this test. List
of all flake occurrences can be found at:
https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTAsSBUZsYWtlIkFjaHJvbWl1bUBuZXRfdW5pdHRlc3RzQFByb3h5Q29uZmlnU2VydmljZUxpbnV4VGVzdC5LREVGaWxlQ2hhbmdlZAw.

Since this test is still flaky, this issue has been moved back onto the Sheriff
Bug Queue if it's not already there.

This flaky test was previously tracked in  bug 907336 .

If the result above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%20for%20ProxyConfigServiceLinuxTest.KDEFileChanged&comment=Link%20to%20flake%20occurrences%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTAsSBUZsYWtlIkFjaHJvbWl1bUBuZXRfdW5pdHRlc3RzQFByb3h5Q29uZmlnU2VydmljZUxpbnV4VGVzdC5LREVGaWxlQ2hhbmdlZAw

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).

Yes this was very annoying, never let me land https://chromium-review.googlesource.com/c/chromium/src/+/1345570, i think we should just disable this.

Eroman sent a CL out to disable the test under TSAN and ASAN - we shouldn't disable it everywhere, if it's just the memory tools that make it flaky.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaf020df77b36a496d664b7152a89324b3ed8440

commit eaf020df77b36a496d664b7152a89324b3ed8440
Author: Eric Roman <eroman@chromium.org>
Date: Thu Nov 22 03:57:40 2018

Disable ProxyConfigServiceLinuxTest.KDEFileChanged on ASAN and TSAN bots.

Bug:  907673 
Change-Id: I71a9bf1433ca7afce1d7482791e008ed809dc04e
Reviewed-on: https://chromium-review.googlesource.com/c/1347771
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610297}
[modify] https://crrev.com/eaf020df77b36a496d664b7152a89324b3ed8440/net/proxy_resolution/proxy_config_service_linux_unittest.cc

Chromium sheriff here.
It looks we can remove Sheriff-Chromium label now.
If this needs an attention from sheriff, please add it. I think FindIt add it if this is still flaky.

I'm not sure who should be an owner of this issue.

This seems to be a legitimate timing issue, and not TSAN or ASAN specific.

I can reproduce the failure locally on a release build by adding a synchronous delay of over 0.1 ms on the sequence where inotify_add_watch() is called.

I'll try to take a closer look later this week as this sounds like either a problem with the test, or the underlying implementation, and could also flake on non-TSAN/ASAN bots.

Looks like a race in the unit-test.

It modifies the kioslaverc potentially before the task that runs notify_add_watch() has completed. In which case that modification is not caught and the test hangs.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/753b30fdc46bc635b653829ae9c0053422a2d7e2

commit 753b30fdc46bc635b653829ae9c0053422a2d7e2
Author: Eric Roman <eroman@chromium.org>
Date: Mon Nov 26 21:03:21 2018

Fix flakiness of ProxyConfigServiceLinuxTest.KDEFileChanged.

Bug:  907673 
Change-Id: I5c355e2cba9398b919e6a14d6fb817332c43a0d2
Reviewed-on: https://chromium-review.googlesource.com/c/1351284
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610940}
[modify] https://crrev.com/753b30fdc46bc635b653829ae9c0053422a2d7e2/net/proxy_resolution/proxy_config_service_linux_unittest.cc