compiler_proxy crashes when ctrl-c'ing ninja |
|||
Issue descriptionThe most recent opensource goma client binaries crash very often (with another goma backend). After testing with some local builds, I believe this was introduced (or uncovered) by something in commit e425ea10f736bcf639f0f659865037f58833ff7f. The simplest way to kill compiler_proxy is to ctrl-c ninja during a build. I haven't been able to find anything relevant in the log files when this happens, but I did notice another CHECK failure in client/socket_descriptor.cc: F1121 22:40:17.874032 16070 socket_descriptor.cc:57] Check failed: !write_in_queue_ Perhaps this is related? If so, these commits mentioned in the git log might be worth checking: a78da810c94ebcf2252e851c95302955b5814104 Call Finish when socket is closed 53066421755b9518f40456c923dd6da6a544663f socket_descriptor: PeerName for unix domain socket.
,
Nov 22
mostynb, We have noticed the problem. The current open source version has the problem, and we already have a fix. After syncing the internal version to the open source version, it should be fixed. The sync should have been done, however, we had one problem while syncing, so it's not finished. AFAIK, tikuta@ is working on that.
,
Nov 22
If you want to Ctrl-C until the fixed version sync, will you try the followings to make the Goma client binary before the culprit? $ cipd install infra/goma/client/linux-amd64 git_revision:3c56bf89f6495126bcc9accb8eecab1cde39fa28 --root $HOME/goma
,
Nov 22
I pushed the fix to external repository. Sorry for inconvenience.
,
Nov 22
The tip of master seems better after half a day of testing- thanks for fixing this. |
|||
►
Sign in to add a comment |
|||
Comment 1 by most...@vewd.com
, Nov 21