Issue metadata
Sign in to add a comment
|
A zero-to-nonzero to 3.4% regression in system_health.common_desktop at 608744:608806 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Nov 21
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1446a497e40000
,
Nov 21
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/1446a497e40000
,
Nov 21
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1608abf4140000
,
Nov 21
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/1608abf4140000 Added URLLoaderThrottleSafeBrowsingChecks to testing config by carlosil@chromium.org https://chromium.googlesource.com/chromium/src/+/c3639baabf0af95d5eb4eff138c9cff56c8e9120 cpu_time_percentage: 0.9902 → 1.023 (+0.03239) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: https://bit.ly/system-health-benchmarks
,
Dec 3
From the pinpoint (and the initial graph) it looks like the regression is for about 0.03%, I'm not familiar with perf regressions, so I'm not sure if this is within the noise or something that needs to be reverted/addressed. FWIW this changes a check that was done via a ResourceThrottle, so it now uses a URLLoaderThrottle, so I don't think this should increase CPU usage unless URLLoaderThrottles use more CPU, but that seems external to this CL. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 21