New issue
Advanced search Search tips

Issue 907641 link

Starred by 1 user
Status: Verified
Merged: issue 907422
Owner:
pbos@chromium.org
Closed: Nov 27
Cc:
edwardjung@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Tab loading animation] Tab-loading animation renders subpixel misaligned

Project Member Reported by meh...@chromium.org, Nov 21 
Chrome Version: Canary 72.0.3617.0 
OS: macOS 10.14.1 (probably OS=All
Device: MacBook AIr Non-Retina


What steps will reproduce the problem?
(1) Take a look at the left/right of the Tab loading animation


What is the expected result?
Same fade color.


What happens instead?
Different fade color.

Not sure, if this is only a Non-Retina issue? Unfortunately I have no Retina Device to test it.

Thanks
Mehmet
actual.png
16.2 KB View Download
expected.png
16.2 KB View Download

Comment 1 by pbos@chromium.org, Nov 21

Mergedinto: 907422
Status: Duplicate (was: Untriaged)
This was probably the 2dp roundrect caps (which, if you only have 1 pixel to render a corner, comes out as different alpha). This should be fixed in r610083 where we move to rounded caps which hasn't been released yet. Can you check this in the next Canary or so and reopen if it persists?

Comment 2 by pbos@chromium.org, Nov 21 

Sorry, where we moved to rectangular caps = just painting a rectangle.

Comment 3 by meh...@chromium.org, Nov 21 

Thanks for the info, pbos@. I downloaded Chromium Snapshot r610194 and it looks now as the attached screenshot. (Only the right side has a light area now - not sure if intended).
Bildschirmfoto 2018-11-21 um 23.11.42.png
11.1 KB View Download

Comment 4 by pbos@chromium.org, Nov 21

Status: Untriaged (was: Duplicate)
Summary: [Tab loading animation] Tab-loading animation renders subpixel misaligned (was: [Tab loading animation] Different fade color on left/right)
I believe that's a subpixel alignment issue (we render to x% which might be off pixel), edwardjung@ WDYT? We can get stuck in this state.

Comment 5 by robliao@chromium.org, Nov 22

Labels: Hotlist-DesktopUIConsider

Comment 6 by robliao@chromium.org, Nov 22

Labels: Group-Loading_Animation

Comment 7 by robliao@chromium.org, Nov 22

Status: Assigned (was: Untriaged)

Comment 8 by robliao@chromium.org, Nov 22

Labels: -Hotlist-DesktopUIConsider Hotlist-DesktopUITriaged

Comment 9 by edwardjung@chromium.org, Nov 22 

If we can round off to the nearest pixel that would make this feel crisper.
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a00b2365ad012fec23b4479d28ab8d065095532

commit 0a00b2365ad012fec23b4479d28ab8d065095532
Author: Peter Boström <pbos@chromium.org>
Date: Tue Nov 27 22:30:34 2018

Align the loading animation to pixel bounds

This is done by disabling anti aliasing. As we're painting a single
solid rectangle this is equivalent (and probably marginally faster).

Bug:  chromium:907641 
Change-Id: I05dec569b963511ce87f0a24d0f2f443fa0d9889
Reviewed-on: https://chromium-review.googlesource.com/c/1352338
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611380}
[modify] https://crrev.com/0a00b2365ad012fec23b4479d28ab8d065095532/chrome/browser/ui/views/tabs/tab_icon.cc
[modify] https://crrev.com/0a00b2365ad012fec23b4479d28ab8d065095532/ui/gfx/paint_throbber.cc

Comment 11 by pbos@chromium.org, Nov 27

Status: Fixed (was: Assigned)

Comment 12 by meh...@chromium.org, Nov 28 

Thanks. Looks perfect now on my non-retina device.
Bildschirmfoto 2018-11-28 um 17.29.33.png
12.9 KB View Download

Comment 13 by pbos@chromium.org, Nov 28

Status: Verified (was: Fixed)
Thanks!
►

Sign in to add a comment