New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 907632 link

Starred by 1 user
Status: Fixed
Owner:
█ chowes@google.com
Last visit > 30 days ago
Closed: Nov 29
Cc:
norvez@chromium.org
ahass...@chromium.org
xiaochu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Every other DLC install attempt fails.

Project Member Reported by chowes@google.com, Nov 21 
When installing a DLC through dlcservice via dbus messages, only every second install attempt is successful.

To reproduce, alternate install/uninstall messages. Only every second install message will result in a successful installation.

Install command:

dbus-send --system --print-reply --type=method_call --dest=org.chromium.DlcService /org/chromium/DlcService org.chromium.DlcServiceInterface.Install string:"dlctest"

Uninstall command:

dbus-send --system --print-reply --type=method_call --dest=org.chromium.DlcService /org/chromium/DlcService org.chromium.DlcServiceInterface.Uninstall string:"dlctest"

Install requests seem to fail due to errors when Imageloader tries to mount the downloaded image, but Update Engine doesn't seem to actually make a request in these cases, so the image is likely just the dummy file created by ftruncate.

Comment 1 by xiaochu@chromium.org, Nov 21

Labels: OS-Chrome
In an install request, we do the following:

...
make sure UE is idle
send AttemptInstall to UE
keep querying UE until it is idle again
call imageloader to mount dlc image
...

So if UE is always idle for some reason, then yes we then go head to mount the image without UE actually finishes (from busy to idle).

Comment 2 by xiaochu@chromium.org, Nov 21

Components: Internals>Installer
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/d772aaebdbd0c53d3e46e21df5783d437809108a

commit d772aaebdbd0c53d3e46e21df5783d437809108a
Author: Colin Howes <chowes@google.com>
Date: Thu Nov 29 20:11:19 2018

update_engine: Don't require reboot after install.

We don't require a reboot after installing a DLC. Instead just set
Update Engine's status to idle.

BUG= chromium:907205 , chromium:907632 
TEST=Attempt a DLC install, UE no longer prompts for a reboot.

Change-Id: I4fba804ba8b62b8e781279c988aba0e1f21fe3cf
Reviewed-on: https://chromium-review.googlesource.com/1344916
Commit-Ready: Colin Howes <chowes@google.com>
Tested-by: Colin Howes <chowes@google.com>
Reviewed-by: Amin Hassani <ahassani@chromium.org>

[modify] https://crrev.com/d772aaebdbd0c53d3e46e21df5783d437809108a/update_attempter_unittest.cc
[modify] https://crrev.com/d772aaebdbd0c53d3e46e21df5783d437809108a/update_attempter.h
[modify] https://crrev.com/d772aaebdbd0c53d3e46e21df5783d437809108a/update_attempter.cc

Comment 4 by chowes@google.com, Nov 29

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/f9e5656462ee760b83bb89dbdf533565c8543921

commit f9e5656462ee760b83bb89dbdf533565c8543921
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Tue Dec 04 04:32:14 2018

Revert "update_engine: Don't require reboot after install."

This reverts commit d772aaebdbd0c53d3e46e21df5783d437809108a.

Reason for revert:  crbug.com/905704 

Original change's description:
> update_engine: Don't require reboot after install.
>
> We don't require a reboot after installing a DLC. Instead just set
> Update Engine's status to idle.
>
> BUG= chromium:907205 , chromium:907632 
> TEST=Attempt a DLC install, UE no longer prompts for a reboot.
>
> Change-Id: I4fba804ba8b62b8e781279c988aba0e1f21fe3cf
> Reviewed-on: https://chromium-review.googlesource.com/1344916
> Commit-Ready: Colin Howes <chowes@google.com>
> Tested-by: Colin Howes <chowes@google.com>
> Reviewed-by: Amin Hassani <ahassani@chromium.org>

TBR=norvez@chromium.org,ahassani@chromium.org,xiaochu@chromium.org,chromiumos-cl-exonerator@appspot.gserviceaccount.com,chowes@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:907205 ,  chromium:907632 
Change-Id: I4c95c7c0acacfb2a6589a7b2b82d445a8ef1f7d0
Reviewed-on: https://chromium-review.googlesource.com/1359108
Commit-Ready: Xiaochu Liu <xiaochu@chromium.org>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Xiaochu Liu <xiaochu@chromium.org>

[modify] https://crrev.com/f9e5656462ee760b83bb89dbdf533565c8543921/update_attempter_unittest.cc
[modify] https://crrev.com/f9e5656462ee760b83bb89dbdf533565c8543921/update_attempter.h
[modify] https://crrev.com/f9e5656462ee760b83bb89dbdf533565c8543921/update_attempter.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 4

Labels: merge-merged-release-R72-11316.B
The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/72b5eca9beadaf945bce17900d3c1a14fe387515

commit 72b5eca9beadaf945bce17900d3c1a14fe387515
Author: Xiaochu Liu <xiaochu@chromium.org>
Date: Tue Dec 04 19:22:45 2018

Revert "update_engine: Don't require reboot after install."

This reverts commit d772aaebdbd0c53d3e46e21df5783d437809108a.

Reason for revert:  crbug.com/905704 

Original change's description:
> update_engine: Don't require reboot after install.
>
> We don't require a reboot after installing a DLC. Instead just set
> Update Engine's status to idle.
>
> BUG= chromium:907205 , chromium:907632 
> TEST=Attempt a DLC install, UE no longer prompts for a reboot.
>
> Change-Id: I4fba804ba8b62b8e781279c988aba0e1f21fe3cf
> Reviewed-on: https://chromium-review.googlesource.com/1344916
> Commit-Ready: Colin Howes <chowes@google.com>
> Tested-by: Colin Howes <chowes@google.com>
> Reviewed-by: Amin Hassani <ahassani@chromium.org>

TBR=norvez@chromium.org,ahassani@chromium.org,xiaochu@chromium.org,chromiumos-cl-exonerator@appspot.gserviceaccount.com,chowes@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  chromium:907205 ,  chromium:907632 
Change-Id: I4c95c7c0acacfb2a6589a7b2b82d445a8ef1f7d0
Reviewed-on: https://chromium-review.googlesource.com/1359108
Commit-Ready: Xiaochu Liu <xiaochu@chromium.org>
Tested-by: Xiaochu Liu <xiaochu@chromium.org>
Reviewed-by: Xiaochu Liu <xiaochu@chromium.org>
(cherry picked from commit f9e5656462ee760b83bb89dbdf533565c8543921)

[modify] https://crrev.com/72b5eca9beadaf945bce17900d3c1a14fe387515/update_attempter_unittest.cc
[modify] https://crrev.com/72b5eca9beadaf945bce17900d3c1a14fe387515/update_attempter.h
[modify] https://crrev.com/72b5eca9beadaf945bce17900d3c1a14fe387515/update_attempter.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/ac170d935176908876dc3a67ef565ed536e2d7c0

commit ac170d935176908876dc3a67ef565ed536e2d7c0
Author: Colin Howes <chowes@google.com>
Date: Thu Dec 06 22:35:22 2018

update_engine: Don't require reboot after install.

We don't require a reboot after installing a DLC. Instead just set
Update Engine's status to idle.

Resubmitting now that  crbug.com/905704  is fixed.

BUG= chromium:907205 , chromium:907632 
TEST=Attempt a DLC install, UE no longer prompts for a reboot.

(cherry picked from commit d772aaebdbd0c53d3e46e21df5783d437809108a)

Change-Id: I061ee8d6268a922ae21f310211acea5b645a3ebb
Reviewed-on: https://chromium-review.googlesource.com/1362572
Commit-Ready: Colin Howes <chowes@google.com>
Tested-by: Colin Howes <chowes@google.com>
Reviewed-by: Amin Hassani <ahassani@chromium.org>

[modify] https://crrev.com/ac170d935176908876dc3a67ef565ed536e2d7c0/update_attempter_unittest.cc
[modify] https://crrev.com/ac170d935176908876dc3a67ef565ed536e2d7c0/update_attempter.h
[modify] https://crrev.com/ac170d935176908876dc3a67ef565ed536e2d7c0/update_attempter.cc
►

Sign in to add a comment