New issue
Advanced search Search tips

Issue 907621 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Feature



Sign in to add a comment

add URL to document.write violation message

Reported by kaycebas...@gmail.com, Nov 21

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36

Steps to reproduce the problem:
1. open devtools console
2. go to https://documentwrite.glitch.me/

What is the expected behavior?
the violation message in the console contains a URL where you can learn more about the violation

What went wrong?
no URL

Did this work before? No 

Chrome version: 70.0.3538.110  Channel: stable
OS Version: OS X 10.13.6
Flash Version:
 
write.png
410 KB View Download
Labels: -Type-Bug Type-Feature
Owner: kayce@google.com
Status: Started (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bde6d04fa980ac5d0e8e883c00aabbccaeb5005b

commit bde6d04fa980ac5d0e8e883c00aabbccaeb5005b
Author: Kayce Basques <kayce@chromium.org>
Date: Wed Nov 28 21:47:55 2018

add link to document.write violation message

Bug:  907621 
Change-Id: I543e58a273ab502f3526a7ac03d049c51cb4e50c
Reviewed-on: https://chromium-review.googlesource.com/c/1347448
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kayce Basques <kayce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611882}
[modify] https://crrev.com/bde6d04fa980ac5d0e8e883c00aabbccaeb5005b/third_party/blink/renderer/core/dom/document.cc

Cc: phanindra.mandapaka@chromium.org
Labels: Needs-Feedback
Tried testing this issue on Mac 10.14.0 and 10.13.6 on the reported version 70.0.3538.110 and the latest M-72 72.0.3625.0 by following the below steps.

1. Launched Chrome 
2. Opened DevTools >> Console
As we have observed that url along with the error link (404) on console using latest chrome 72.0.3625.0. Attached is the screen cast for reference.

Kayce Basques@ Request you to check and confirm if anything is missed from our end in verifying the issue and help us to verify the fix on the latest M-72 build.

Thanks..!
907621.mp4
842 KB View Download
Status: Fixed (was: Started)
phanindra.mandapaka@chromium.org, 

I forgot to mention that you need to click "Default levels" and enable "Verbose". The Console was filtering out the message from your DevTools UI.

Also, you might need to hold Reload and select "Empty Cache and Hard Reload".

Sign in to add a comment