ArcDataSource::AddApps hits NOTREACHED on login |
||||||
Issue description
Chrome Version: Debug build from ToT from Nov 20, 2018
Can't get to chrome://version
Login screen says Google Chrome 72.0.3617.0 (Platform 11281.0.2018_11_20_1350 (Test Build - iby) developer-build eve) SN:8321G02EF3
OS: ChromeOS
What steps will reproduce the problem?
(1) Build in debug mode (eve)
(2) Deploy to temp partition
(3) Attach gdb
(4) Login
I had Crostini (Linux) activated, if that matters.
What is the expected result?
No Crashes
What happens instead?
Hit the 'if (!app_info)' NOTREACHED() in ArcDataSource::AddApps
gdb bt shows:
#0 base::debug::(anonymous namespace)::DebugBreak() ()
at ../../base/debug/debugger_posix.cc:240
#1 0x000057211fb3a538 in base::debug::BreakDebugger() ()
at ../../base/debug/debugger_posix.cc:263
warning: (Internal error: pc 0x57211f90f075 in read in CU, but not in symtab.)
warning: (Internal error: pc 0x57211f90f075 in read in CU, but not in symtab.)
#2 0x000057211f90f076 in logging::LogMessage::~LogMessage() ()
at ../../base/logging.cc:876
warning: (Internal error: pc 0x572128b60ced in read in CU, but not in symtab.)
warning: (Internal error: pc 0x572128b60ced in read in CU, but not in symtab.)
#3 0x0000572128b60cee in app_list::(anonymous namespace)::ArcDataSource::AddApps(std::__1::vector<std::__1::unique_ptr<app_list::AppSearchProvider::App, std::__1::default_delete<app_list::AppSearchProvider::App> >, std::__1::allocator<std::__1::unique_ptr<app_list::AppSearchProvider::App, std::__1::default_delete<app_list::AppSearchProvider::App> > > >*) ()
at ../../chrome/browser/ui/app_list/search/app_search_provider.cc:346
warning: (Internal error: pc 0x572128b5c053 in read in CU, but not in symtab.)
warning: (Internal error: pc 0x572128b5c053 in read in CU, but not in symtab.)
#4 0x0000572128b5c054 in app_list::AppSearchProvider::RefreshApps() ()
at ../../chrome/browser/ui/app_list/search/app_search_provider.cc:568
warning: (Internal error: pc 0x572128b5f353 in read in CU, but not in symtab.)
warning: (Internal error: pc 0x572128b5f353 in read in CU, but not in symtab.)
#5 0x0000572128b5f354 in app_list::AppSearchProvider::RefreshAppsAndUpdateResults(bool) ()
at ../../chrome/browser/ui/app_list/search/app_search_provider.cc:685
warning: (Internal error: pc 0x572128b61a09 in read in CU, but not in symtab.)
warning: (Internal error: pc 0x572128b61a09 in read in CU, but not in symtab.)
#6 0x0000572128b61a0a in app_list::(anonymous namespace)::ArcDataSource::OnAppRegistered(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, ArcAppListPrefs::AppInfo const&) ()
at ../../chrome/browser/ui/app_list/search/app_search_provider.cc:372
warning: (Internal error: pc 0x5721286a8870 in read in CU, but not in symtab.)
warning: (Internal error: pc 0x5721286a8870 in read in CU, but not in symtab.)
#7 0x00005721286a8871 in ArcAppListPrefs::AddAppAndShortcut(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool, bool, bool, bool, bool, bool) () at ../../chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc:1101
warning: (Internal error: pc 0x5721286a4e87 in read in CU, but not in symtab.)
warning: (Internal error: pc 0x5721286a4e87 in read in CU, but not in symtab.)
#8 0x00005721286a4e88 in ArcAppListPrefs::RegisterDefaultApps() ()
at ../../chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc:929
warning: (Internal error: pc 0x5721286a42dc in read in CU, but not in symtab.)
warning: (Internal error: pc 0x5721286a42dc in read in CU, but not in symtab.)
#9 0x00005721286a42dd in ArcAppListPrefs::SetDefaultAppsFilterLevel() ()
at ../../chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc:874
warning: (Internal error: pc 0x5721286991e7 in read in CU, but not in symtab.)
warning: (Internal error: pc 0x5721286991e7 in read in CU, but not in symtab.)
#10 0x00005721286991e8 in ArcAppListPrefs::OnDefaultAppsReady() ()
at ../../chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc:890
warning: (Internal error: pc 0x572114512b0c in read in CU, but not in symtab.)
warning: (Internal error: pc 0x572114512b0c in read in CU, but not in symtab.)
etc. (Complete stack trace attached since it's too long)
,
Nov 21
Do you have repro case or failing app_id by a chance?
,
Nov 21
Repo case is just "I try to login" when Linux (Crostini) is installed. Might be same underlying issue as https://bugs.chromium.org/p/chromium/issues/detail?id=907598 which I just ran into trying to login.
,
Nov 21
Well, now I can't repo because I keep hitting https://bugs.chromium.org/p/chromium/issues/detail?id=907598. No idea if one is hidden behind the other, or if they are two manifestations of the same issue, or what. Sorry :-/
,
Nov 27
Alright, I got this again. Reinstalled fresh from ToT as of < 2 hours ago. Linux (Crostini) is *not* enabled yet.
Adding some logging just before the `for (const auto& app_id : app_ids) {` loop and in the `if (!app_info) {` block, I get:
localhost ~ # grep iby /home/chronos/user/log/chrome
[4212:4212:1126/163636.986531:ERROR:app_search_provider.cc(342)] iby: Checking 0 app_ids
[4212:4212:1126/163637.025574:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163637.025637:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id cafegjnmmjpfibnlddppihpnkbkgicbg
[4212:4212:1126/163637.025709:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id dbbihmicnlldbflflckpafphlekmjfnm
[4212:4212:1126/163637.025752:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id ddmmnabaeomoacfpfjgghfpocfolhjlg
[4212:4212:1126/163637.025799:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id fpegfnbgomakooccabncdaelhfppceni
[4212:4212:1126/163637.025836:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id nplnnjkbeijcggmpdcecpabgbjgeiedc
[4212:4212:1126/163637.025874:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id ophbaopahelaolbjliokocojjbgfadfn
[4212:4212:1126/163637.027550:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163637.027615:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id dbbihmicnlldbflflckpafphlekmjfnm
[4212:4212:1126/163637.027640:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id ddmmnabaeomoacfpfjgghfpocfolhjlg
[4212:4212:1126/163637.027664:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id fpegfnbgomakooccabncdaelhfppceni
[4212:4212:1126/163637.027713:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id nplnnjkbeijcggmpdcecpabgbjgeiedc
[4212:4212:1126/163637.027751:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id ophbaopahelaolbjliokocojjbgfadfn
[4212:4212:1126/163637.028641:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163637.028790:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id dbbihmicnlldbflflckpafphlekmjfnm
[4212:4212:1126/163637.028842:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id ddmmnabaeomoacfpfjgghfpocfolhjlg
[4212:4212:1126/163637.028880:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id fpegfnbgomakooccabncdaelhfppceni
[4212:4212:1126/163637.028917:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id nplnnjkbeijcggmpdcecpabgbjgeiedc
[4212:4212:1126/163637.028954:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id ophbaopahelaolbjliokocojjbgfadfn
[4212:4212:1126/163637.031005:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163637.031125:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id ddmmnabaeomoacfpfjgghfpocfolhjlg
[4212:4212:1126/163637.031172:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id fpegfnbgomakooccabncdaelhfppceni
[4212:4212:1126/163637.031212:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id nplnnjkbeijcggmpdcecpabgbjgeiedc
[4212:4212:1126/163637.031250:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id ophbaopahelaolbjliokocojjbgfadfn
[4212:4212:1126/163637.031661:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163637.031854:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id fpegfnbgomakooccabncdaelhfppceni
[4212:4212:1126/163637.031922:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id nplnnjkbeijcggmpdcecpabgbjgeiedc
[4212:4212:1126/163637.031981:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id ophbaopahelaolbjliokocojjbgfadfn
[4212:4212:1126/163637.032119:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163637.032238:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id nplnnjkbeijcggmpdcecpabgbjgeiedc
[4212:4212:1126/163637.032273:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id ophbaopahelaolbjliokocojjbgfadfn
[4212:4212:1126/163637.032632:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163637.033020:ERROR:app_search_provider.cc(347)] iby: Failed to get app_id ophbaopahelaolbjliokocojjbgfadfn
[4212:4212:1126/163637.033604:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163637.230277:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163637.325345:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163639.390832:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163639.888450:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163640.462209:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163640.949478:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163643.687783:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163643.812842:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163644.549847:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163644.790231:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163645.628151:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163646.137064:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163647.138490:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163648.186813:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163648.418572:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163649.592057:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
[4212:4212:1126/163650.028198:ERROR:app_search_provider.cc(342)] iby: Checking 8 app_ids
Each "Checking # app_ids" would be a separate call to AddApps.
Does that help?
,
Nov 27
Got this again with a fresh user. The first time they logged in on a fresh machine, they got the same list of unknown app_ids. Later times, they didn't get any unknown app_ids.
,
Nov 27
Thank you for context. I will take a look.
,
Nov 29
It seems, everything is related to default apps, when they are not yet installed.
,
Nov 29
,
Nov 30
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72b519c2050c88299375ef7249bf616110ae873a commit 72b519c2050c88299375ef7249bf616110ae873a Author: khmel@chromium.org <khmel@chromium.org> Date: Fri Nov 30 22:14:47 2018 arc: Optimize app search provider. App search provider already has optimization that runs update result deferred in certain cases. This also includes cases when new app registered or existing app updated. However in last case we always do refresh apps inline. This CL also defers Refresh app when it possible. Additionally that has protection not to list not yet registered ARC default apps. TEST=Manually, using 2 step fix. On first step verified that ArcAppListPrefs did not return not yet registered default app. At second step verified that app data search provider refreshes apps deferred and functionality is not broken BUG= 907590 Change-Id: I12b015c02e0c59d19e49926f11d5632adf25ad9a Reviewed-on: https://chromium-review.googlesource.com/c/1356012 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612817} [modify] https://crrev.com/72b519c2050c88299375ef7249bf616110ae873a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc [modify] https://crrev.com/72b519c2050c88299375ef7249bf616110ae873a/chrome/browser/ui/app_list/search/app_search_provider.cc [modify] https://crrev.com/72b519c2050c88299375ef7249bf616110ae873a/chrome/browser/ui/app_list/search/app_search_provider.h
,
Nov 30
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by iby@chromium.org
, Nov 2118.2 KB
18.2 KB View Download